Re: patches for staging:media drivers

Re: patches for staging:media drivers

[Neil Armstrong]

Hi,

On 06/11/2022 11:52, Deepak R Varma wrote:
> Greetings to all.
> My name is Deepak R Varma and I was part of the recent Outreachy internship
> round. I learned during this program that patches for the media drivers were
> prohibited to be included in the Outreachy effort due to lack of bandwidth for
> the maintainers to respond on those.
> 
> The Outreachy round is now over but I am continuing to work on code improvement
> and changes. I would like to know if it is okay for me to now identify
> opportunities in the media drivers and send patch proposal for your kind
> consideration. I intend to send couple of Coccinelle identified code
> improvements as patches.
> 
> Please let me know.

I won't say no but since the media maintainers will need to apply them,
the problem is the same.

Neil

> 
> Thank you,
> ./drv
> 
> 

Re: patches for staging:media drivers

[Deepak R Varma]

On Mon, Nov 07, 2022 at 06:29:30PM +0100, Neil Armstrong wrote:
> Hi,
>
> On 06/11/2022 11:52, Deepak R Varma wrote:
> > Greetings to all.
> > My name is Deepak R Varma and I was part of the recent Outreachy internship
> > round. I learned during this program that patches for the media drivers were
> > prohibited to be included in the Outreachy effort due to lack of bandwidth for
> > the maintainers to respond on those.
> >
> > The Outreachy round is now over but I am continuing to work on code improvement
> > and changes. I would like to know if it is okay for me to now identify
> > opportunities in the media drivers and send patch proposal for your kind
> > consideration. I intend to send couple of Coccinelle identified code
> > improvements as patches.
> >
> > Please let me know.
>
> I won't say no but since the media maintainers will need to apply them,
> the problem is the same.

Hello Neil,
Thank you for responding. I will send in the patches. I am sure they will be
reviewed at an appropriate time and responded accordingly.

Have a good day!
./drv

>
> Neil
>
> >
> > Thank you,
> > ./drv
> >
> >
>
>

Re: patches for staging:media drivers

[Dan Carpenter]

On Mon, Nov 07, 2022 at 06:29:30PM +0100, Neil Armstrong wrote:
> Hi,
> 
> On 06/11/2022 11:52, Deepak R Varma wrote:
> > Greetings to all.
> > My name is Deepak R Varma and I was part of the recent Outreachy internship
> > round. I learned during this program that patches for the media drivers were
> > prohibited to be included in the Outreachy effort due to lack of bandwidth for
> > the maintainers to respond on those.
> > 
> > The Outreachy round is now over but I am continuing to work on code improvement
> > and changes. I would like to know if it is okay for me to now identify
> > opportunities in the media drivers and send patch proposal for your kind
> > consideration. I intend to send couple of Coccinelle identified code
> > improvements as patches.
> > 
> > Please let me know.
> 
> I won't say no but since the media maintainers will need to apply them,
> the problem is the same.

Yeah.  Me either.  Those rules are for Outreachy so they don't apply to
anyone else, but at the same time no one is going to Ack your patches
without seeing them and especially for a subsystem they don't maintain.

I always try to think about if maintainers will want my patches.  Like
I sometimes see people returning -1 instead of -ENOMEM but, you know,
unless it reaches user space it's not technically a bug.  You can't go
around fixing everyone's bad taste.  But everyone likes bug fixes.

regards,
dan carpenter

Re: patches for staging:media drivers

[Hans Verkuil]

Hi Deepak,

On 11/8/22 09:10, Dan Carpenter wrote:
> On Mon, Nov 07, 2022 at 06:29:30PM +0100, Neil Armstrong wrote:
>> Hi,
>>
>> On 06/11/2022 11:52, Deepak R Varma wrote:
>>> Greetings to all.
>>> My name is Deepak R Varma and I was part of the recent Outreachy internship
>>> round. I learned during this program that patches for the media drivers were
>>> prohibited to be included in the Outreachy effort due to lack of bandwidth for
>>> the maintainers to respond on those.
>>>
>>> The Outreachy round is now over but I am continuing to work on code improvement
>>> and changes. I would like to know if it is okay for me to now identify
>>> opportunities in the media drivers and send patch proposal for your kind
>>> consideration. I intend to send couple of Coccinelle identified code
>>> improvements as patches.
>>>
>>> Please let me know.
>>
>> I won't say no but since the media maintainers will need to apply them,
>> the problem is the same.
> 
> Yeah.  Me either.  Those rules are for Outreachy so they don't apply to
> anyone else, but at the same time no one is going to Ack your patches
> without seeing them and especially for a subsystem they don't maintain.
> 
> I always try to think about if maintainers will want my patches.  Like
> I sometimes see people returning -1 instead of -ENOMEM but, you know,
> unless it reaches user space it's not technically a bug.  You can't go
> around fixing everyone's bad taste.  But everyone likes bug fixes.
> 
> regards,
> dan carpenter
> 

I don't mind taking patches for media staging drivers as long as:

1) they are not for atomisp, and
2) they are not for deprecated drivers (drivers/staging/media/deprecated/)

Regards,

	Hans

Re: patches for staging:media drivers

[Dan Carpenter]

On Tue, Nov 08, 2022 at 10:35:54AM +0100, Hans Verkuil wrote:
> 
> I don't mind taking patches for media staging drivers as long as:
> 
> 1) they are not for atomisp, and
> 2) they are not for deprecated drivers (drivers/staging/media/deprecated/)
> 

This is unrelated but I somehow misread an email and thought we were
going to create a drivers/deprecated/ directory.  I still think that's a
good idea for future deprecated drivers.  We normally put them in
staging/ but it's not really the ideal place for them.

regards,
dan carpenter

Re: patches for staging:media drivers

[Andrew Lunn]

On Tue, Nov 08, 2022 at 11:10:21AM +0300, Dan Carpenter wrote:
> On Mon, Nov 07, 2022 at 06:29:30PM +0100, Neil Armstrong wrote:
> > Hi,
> > 
> > On 06/11/2022 11:52, Deepak R Varma wrote:
> > > Greetings to all.
> > > My name is Deepak R Varma and I was part of the recent Outreachy internship
> > > round. I learned during this program that patches for the media drivers were
> > > prohibited to be included in the Outreachy effort due to lack of bandwidth for
> > > the maintainers to respond on those.
> > > 
> > > The Outreachy round is now over but I am continuing to work on code improvement
> > > and changes. I would like to know if it is okay for me to now identify
> > > opportunities in the media drivers and send patch proposal for your kind
> > > consideration. I intend to send couple of Coccinelle identified code
> > > improvements as patches.
> > > 
> > > Please let me know.
> > 
> > I won't say no but since the media maintainers will need to apply them,
> > the problem is the same.
> 
> Yeah.  Me either.  Those rules are for Outreachy so they don't apply to
> anyone else, but at the same time no one is going to Ack your patches
> without seeing them and especially for a subsystem they don't maintain.
> 
> I always try to think about if maintainers will want my patches.  Like
> I sometimes see people returning -1 instead of -ENOMEM but, you know,
> unless it reaches user space it's not technically a bug.  You can't go
> around fixing everyone's bad taste.  But everyone likes bug fixes.

I cannot say anything about the media subsystem, but for networking
patches, i will be much more willing to help somebody going from
Outreach to being a full kernel developers if they decide to take on
something more than just some Coccinelle changes. If it looks like you
have the hardware and want to make it better, have a vision where the
driver should go, then you are likely to get more help from me. So if
media drivers are what you interested in, go buy some hardware which
uses one of the drivers in staging, look at the TODO file, and submit
bigger patches than just -1 to -ENOMEM.

     Andrew

Re: patches for staging:media drivers

[Deepak R Varma]

On Tue, Nov 08, 2022 at 09:27:32PM +0100, Andrew Lunn wrote:
> On Tue, Nov 08, 2022 at 11:10:21AM +0300, Dan Carpenter wrote:
>
> I cannot say anything about the media subsystem, but for networking
> patches, i will be much more willing to help somebody going from
> Outreach to being a full kernel developers if they decide to take on
> something more than just some Coccinelle changes. If it looks like you
> have the hardware and want to make it better, have a vision where the
> driver should go, then you are likely to get more help from me. So if
> media drivers are what you interested in, go buy some hardware which
> uses one of the drivers in staging, look at the TODO file, and submit
> bigger patches than just -1 to -ENOMEM.

Hello Andrew,
Thank you so much for your kind advice and willingness to help a newbie
become a valued kernel developer. I am committed to acquire necessary
knowledge and skills to contribute more than current cleanup and minor
correction patches. I am sure that the upcoming Coccinelle based project
work [if I am shortlisted] will be much more complex and meaningful.

I will explore the staging directory to identify a hardware I can afford.
I would welcome suggestion on a driver that is not much expensive and
complex to start with. Anything for the networking subsystem???

Thank you once again!
./drv

>
>      Andrew
>

Re: patches for staging:media drivers

[Andrew Lunn]

On Wed, Nov 09, 2022 at 12:10:37PM +0530, Deepak R Varma wrote:
> On Tue, Nov 08, 2022 at 09:27:32PM +0100, Andrew Lunn wrote:
> > On Tue, Nov 08, 2022 at 11:10:21AM +0300, Dan Carpenter wrote:
> >
> > I cannot say anything about the media subsystem, but for networking
> > patches, i will be much more willing to help somebody going from
> > Outreach to being a full kernel developers if they decide to take on
> > something more than just some Coccinelle changes. If it looks like you
> > have the hardware and want to make it better, have a vision where the
> > driver should go, then you are likely to get more help from me. So if
> > media drivers are what you interested in, go buy some hardware which
> > uses one of the drivers in staging, look at the TODO file, and submit
> > bigger patches than just -1 to -ENOMEM.
> 
> Hello Andrew,
> Thank you so much for your kind advice and willingness to help a newbie
> become a valued kernel developer. I am committed to acquire necessary
> knowledge and skills to contribute more than current cleanup and minor
> correction patches. I am sure that the upcoming Coccinelle based project
> work [if I am shortlisted] will be much more complex and meaningful.
> 
> I will explore the staging directory to identify a hardware I can afford.
> I would welcome suggestion on a driver that is not much expensive and
> complex to start with. Anything for the networking subsystem???

Staging drivers for network tend to be USB dongles for WiFi. Some of
those drivers need throwing away and starting again, others need less
work. If you are interested in that, i would suggest asking on
linux-wireless@vger.kernel.org.

Another option might be pi433? The problem with that is, i don't know
how it fits into the rest of the network stack? Could it maybe fit
under ieee802154? Or is it just unique and needs to do its own thing?

      Andrew

Re: patches for staging:media drivers

[Deepak R Varma]

On Wed, Nov 09, 2022 at 02:49:27PM +0100, Andrew Lunn wrote:
> On Wed, Nov 09, 2022 at 12:10:37PM +0530, Deepak R Varma wrote:
> > On Tue, Nov 08, 2022 at 09:27:32PM +0100, Andrew Lunn wrote:
>
> Staging drivers for network tend to be USB dongles for WiFi. Some of
> those drivers need throwing away and starting again, others need less
> work. If you are interested in that, i would suggest asking on
> linux-wireless@vger.kernel.org.
>
> Another option might be pi433? The problem with that is, i don't know
> how it fits into the rest of the network stack? Could it maybe fit
> under ieee802154? Or is it just unique and needs to do its own thing?

Hello Andrew,
I looked at the pi433 driver and it appears to be a good starting point. I have
started studying more about the hardware, the RF technology etc. There is a TODO
file with reasonable challenges.

Thank you for the recommendation.

Have a nice weekend!
./drv

>
>       Andrew
>