Linux Media Controller development
 help / color / mirror / Atom feed
From: "Nikolay K." <knv418@gmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH] staging: media: omap4iss: code style - avoid macro argument precedence issues
Date: Mon, 22 Feb 2021 00:21:36 +0300	[thread overview]
Message-ID: <YDLO4CZlZH+sxFNV@msi.localdomain> (raw)

Hi Laurent,

Thank you for the review.
I think that if we drop the unneeded parentheses here, we need to drop
them everywhere in the file for consistency, even in places checkpatch.pl
doesn't warn about. It'll increase patch size without actual usefullness 
gain, as for me. I am very (very) novice to the kernel,
but who wants slightly more readable one-line simple macros?

             reply	other threads:[~2021-02-21 21:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-21 21:21 Nikolay K. [this message]
2021-02-21 21:33 ` [PATCH] staging: media: omap4iss: code style - avoid macro argument precedence issues Laurent Pinchart
  -- strict thread matches above, loose matches on Subject: below --
2021-02-21 19:53 Nikolay Kyx
2021-02-21 20:02 ` Laurent Pinchart
2021-02-21 21:33 ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YDLO4CZlZH+sxFNV@msi.localdomain \
    --to=knv418@gmail.com \
    --cc=YDK8RfFUlktIyu7q@pendragon.ideasonboard.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox