From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Nikolay K." <knv418@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH] staging: media: omap4iss: code style - avoid macro argument precedence issues
Date: Sun, 21 Feb 2021 23:33:05 +0200 [thread overview]
Message-ID: <YDLRkUKPo3nCzwPY@pendragon.ideasonboard.com> (raw)
In-Reply-To: <YDLO4CZlZH+sxFNV@msi.localdomain>
Hi Nikolay,
On Mon, Feb 22, 2021 at 12:21:36AM +0300, Nikolay K. wrote:
> Hi Laurent,
>
> Thank you for the review.
> I think that if we drop the unneeded parentheses here, we need to drop
> them everywhere in the file for consistency, even in places checkpatch.pl
That's a good point.
> doesn't warn about. It'll increase patch size without actual usefullness
> gain, as for me. I am very (very) novice to the kernel,
> but who wants slightly more readable one-line simple macros?
Let's keep your patch as-is, we can drop the unneeded parentheses in a
subsequent patch if desired.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-02-21 21:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-21 21:21 [PATCH] staging: media: omap4iss: code style - avoid macro argument precedence issues Nikolay K.
2021-02-21 21:33 ` Laurent Pinchart [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-02-21 19:53 Nikolay Kyx
2021-02-21 20:02 ` Laurent Pinchart
2021-02-21 21:33 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDLRkUKPo3nCzwPY@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knv418@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox