From: Martiros Shakhzadyan <vrzh@vrzh.net>
To: Jacopo Mondi <jacopo@jmondi.org>
Cc: vrzh@vrzh.net
Subject: Re: Re: [PATCH] staging: media: atomisp: Minor code style changes
Date: Mon, 12 Apr 2021 11:41:11 -0400 [thread overview]
Message-ID: <YHRqF6BtoBjqAreL@coplandos.local> (raw)
In-Reply-To: <20210412094048.gxnndzkbqv7tvykc@uno.localdomain>
On Mon, Apr 12, 2021 at 11:40:48AM +0200, Jacopo Mondi wrote:
> Hi Martiros,
>
> On Sun, Apr 11, 2021 at 10:35:58PM -0400, Martiros Shakhzadyan wrote:
> > Fixed line continuation and parenthesis alignment issues.
> >
> > Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net>
> >
> > squashme
>
> This line should probably be dropped :)
>
Oops! :)
> > ---
> > drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> > index 912eadaffc44..90a985ee25fa 100644
> > --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> > +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> > @@ -49,8 +49,8 @@ static int ov2722_read_reg(struct i2c_client *client,
> > return -ENODEV;
> > }
> >
> > - if (data_length != OV2722_8BIT && data_length != OV2722_16BIT
> > - && data_length != OV2722_32BIT) {
> > + if (data_length != OV2722_8BIT && data_length != OV2722_16BIT &&
> > + data_length != OV2722_32BIT) {
>
> Does checkpatch report this one ?
>
It did. Once I moved `&&` on the previous line it stopped complaining.
> > dev_err(&client->dev, "%s error, invalid data length\n",
> > __func__);
> > return -EINVAL;
> > @@ -212,8 +212,8 @@ static int __ov2722_buf_reg_array(struct i2c_client *client,
> > }
> >
> > static int __ov2722_write_reg_is_consecutive(struct i2c_client *client,
> > - struct ov2722_write_ctrl *ctrl,
> > - const struct ov2722_reg *next)
> > + struct ov2722_write_ctrl *ctrl,
> > + const struct ov2722_reg *next)
>
> These are probably 2 separate changes, but give this is just a style
> fix I think it's ok...
>
> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
>
>
>
Thanks for the review - will resubmit with a fixed commit message.
> > {
> > if (ctrl->index == 0)
> > return 1;
> > --
> > 2.31.1
> >
prev parent reply other threads:[~2021-04-12 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 2:35 [PATCH] staging: media: atomisp: Coding style fixes Martiros Shakhzadyan
2021-04-12 2:35 ` [PATCH] staging: media: atomisp: Removed a superfluous else clause Martiros Shakhzadyan
2021-04-12 2:35 ` [PATCH] staging: media: atomisp: Removed a function entry log Martiros Shakhzadyan
2021-04-12 9:28 ` Hans Verkuil
2021-04-12 15:43 ` Martiros Shakhzadyan
2021-04-12 2:35 ` [PATCH] staging: media: atomisp: Minor code style changes Martiros Shakhzadyan
2021-04-12 9:40 ` Jacopo Mondi
2021-04-12 15:41 ` Martiros Shakhzadyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHRqF6BtoBjqAreL@coplandos.local \
--to=vrzh@vrzh.net \
--cc=jacopo@jmondi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox