From: Hans Verkuil <hverkuil@xs4all.nl>
To: Martiros Shakhzadyan <vrzh@vrzh.net>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Subject: Re: [PATCH] staging: media: atomisp: Removed a function entry log
Date: Mon, 12 Apr 2021 11:28:09 +0200 [thread overview]
Message-ID: <e523c55b-9e5b-bbd1-73e8-a6c8dcd832f7@xs4all.nl> (raw)
In-Reply-To: <20210412023558.360103-3-vrzh@vrzh.net>
On 12/04/2021 04:35, Martiros Shakhzadyan wrote:
> Coding style fix.
What exactly is the coding style issue? Please mention that.
Also, by removing the line you change the behavior (i.e. if debugging is
enabled, you no longer see this message). That's more than a coding style
fix...
Regards,
Hans
>
> Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net>
> ---
> drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> index c017e9066b7a..912eadaffc44 100644
> --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> @@ -1175,8 +1175,6 @@ static int ov2722_remove(struct i2c_client *client)
> struct v4l2_subdev *sd = i2c_get_clientdata(client);
> struct ov2722_device *dev = to_ov2722_sensor(sd);
>
> - dev_dbg(&client->dev, "ov2722_remove...\n");
> -
> dev->platform_data->csi_cfg(sd, 0);
> v4l2_ctrl_handler_free(&dev->ctrl_handler);
> v4l2_device_unregister_subdev(sd);
>
next prev parent reply other threads:[~2021-04-12 9:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 2:35 [PATCH] staging: media: atomisp: Coding style fixes Martiros Shakhzadyan
2021-04-12 2:35 ` [PATCH] staging: media: atomisp: Removed a superfluous else clause Martiros Shakhzadyan
2021-04-12 2:35 ` [PATCH] staging: media: atomisp: Removed a function entry log Martiros Shakhzadyan
2021-04-12 9:28 ` Hans Verkuil [this message]
2021-04-12 15:43 ` Martiros Shakhzadyan
2021-04-12 2:35 ` [PATCH] staging: media: atomisp: Minor code style changes Martiros Shakhzadyan
2021-04-12 9:40 ` Jacopo Mondi
2021-04-12 15:41 ` Martiros Shakhzadyan
-- strict thread matches above, loose matches on Subject: below --
2021-04-12 15:59 [PATCH] staging: media: atomisp: Removed a function entry log Martiros Shakhzadyan
2021-04-12 21:28 ` Sakari Ailus
2021-04-13 14:51 ` Hans Verkuil
2021-04-13 17:53 ` Martiros Shakhzadyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e523c55b-9e5b-bbd1-73e8-a6c8dcd832f7@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=vrzh@vrzh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox