Linux Media Controller development
 help / color / mirror / Atom feed
From: Martiros Shakhzadyan <vrzh@vrzh.net>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: sakari.ailus@linux.intel.com, linux-media@vger.kernel.org
Subject: Re: [PATCH] staging: media: atomisp: Removed a function entry log
Date: Tue, 13 Apr 2021 13:53:16 -0400	[thread overview]
Message-ID: <YHXajIGK50uT3M5Y@coplandos.local> (raw)
In-Reply-To: <50b6775f-f6cf-afd2-9a52-c30d02b89832@xs4all.nl>

On Tue, Apr 13, 2021 at 04:51:18PM +0200, Hans Verkuil wrote:
> On 12/04/2021 17:59, Martiros Shakhzadyan wrote:
> > Removed a function entry log in ov2722_remove, as ftrace is a preferred
> > method for function entry/exit tracing.
> 
> It turns out that someone else already made the same fix [1], so marking
> this patch as obsolete.
> 
> There are quite a few atomisp patches pending for 5.13, so it might be
> a good idea to checkout the media subsystem master tree since that is
> more recent than mainline.
> 
> https://git.linuxtv.org/media_tree.git/
> 
> Regards,
> 
> 	Hans
> 
> [1]:
> https://patchwork.linuxtv.org/project/linux-media/patch/20210106181158.2270-1-fil.kolev@gmail.com/
> 
Noted. I will continue to work off of that repo - Thanks!
> > 
> > Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net>
> > ---
> >  drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> > index c017e9066b7a..912eadaffc44 100644
> > --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> > +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> > @@ -1175,8 +1175,6 @@ static int ov2722_remove(struct i2c_client *client)
> >  	struct v4l2_subdev *sd = i2c_get_clientdata(client);
> >  	struct ov2722_device *dev = to_ov2722_sensor(sd);
> >  
> > -	dev_dbg(&client->dev, "ov2722_remove...\n");
> > -
> >  	dev->platform_data->csi_cfg(sd, 0);
> >  	v4l2_ctrl_handler_free(&dev->ctrl_handler);
> >  	v4l2_device_unregister_subdev(sd);
> > 
> 

  reply	other threads:[~2021-04-13 17:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-12 15:59 [PATCH] staging: media: atomisp: Removed a function entry log Martiros Shakhzadyan
2021-04-12 21:28 ` Sakari Ailus
2021-04-13 14:51 ` Hans Verkuil
2021-04-13 17:53   ` Martiros Shakhzadyan [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-04-12  2:35 [PATCH] staging: media: atomisp: Coding style fixes Martiros Shakhzadyan
2021-04-12  2:35 ` [PATCH] staging: media: atomisp: Removed a function entry log Martiros Shakhzadyan
2021-04-12  9:28   ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YHXajIGK50uT3M5Y@coplandos.local \
    --to=vrzh@vrzh.net \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox