Linux Media Controller development
 help / color / mirror / Atom feed
From: Martiros Shakhzadyan <vrzh@vrzh.net>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: sakari.ailus@linux.intel.com, linux-media@vger.kernel.org
Subject: Re: [PATCH] staging: media: atomisp: Minor code style changes
Date: Tue, 13 Apr 2021 13:55:43 -0400	[thread overview]
Message-ID: <YHXbH+EqAm2bE8oE@coplandos.local> (raw)
In-Reply-To: <eda1c459-f654-e9f4-5738-5d611f267a9e@xs4all.nl>

On Tue, Apr 13, 2021 at 04:41:02PM +0200, Hans Verkuil wrote:
> Please repost with a '[PATCHv3]' in the subject.
> 
> This version should have been '[PATCHv2]', but you forgot the v2 part :-)
> 
> It's important, since now I had no indication that the previous patch was superseded
> and I tried to apply both, thus discovering that the older one should have been skipped.
> 
> Regards,
> 
> 	Hans
> 
Got it! Will do that now - thanks for your patience :)
> On 12/04/2021 18:02, Martiros Shakhzadyan wrote:
> > Fixed line continuation and parenthesis alignment issues.
> > 
> > Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net>
> > ---
> >  drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> > index 912eadaffc44..90a985ee25fa 100644
> > --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> > +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> > @@ -49,8 +49,8 @@ static int ov2722_read_reg(struct i2c_client *client,
> >  		return -ENODEV;
> >  	}
> >  
> > -	if (data_length != OV2722_8BIT && data_length != OV2722_16BIT
> > -	    && data_length != OV2722_32BIT) {
> > +	if (data_length != OV2722_8BIT && data_length != OV2722_16BIT &&
> > +	    data_length != OV2722_32BIT) {
> >  		dev_err(&client->dev, "%s error, invalid data length\n",
> >  			__func__);
> >  		return -EINVAL;
> > @@ -212,8 +212,8 @@ static int __ov2722_buf_reg_array(struct i2c_client *client,
> >  }
> >  
> >  static int __ov2722_write_reg_is_consecutive(struct i2c_client *client,
> > -	struct ov2722_write_ctrl *ctrl,
> > -	const struct ov2722_reg *next)
> > +					     struct ov2722_write_ctrl *ctrl,
> > +					     const struct ov2722_reg *next)
> >  {
> >  	if (ctrl->index == 0)
> >  		return 1;
> > 
> 

  reply	other threads:[~2021-04-13 17:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-12 16:02 [PATCH] staging: media: atomisp: Minor code style changes Martiros Shakhzadyan
2021-04-13 14:41 ` Hans Verkuil
2021-04-13 17:55   ` Martiros Shakhzadyan [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-04-12  2:35 [PATCH] staging: media: atomisp: Coding style fixes Martiros Shakhzadyan
2021-04-12  2:35 ` [PATCH] staging: media: atomisp: Minor code style changes Martiros Shakhzadyan
2021-04-12  9:40   ` Jacopo Mondi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YHXbH+EqAm2bE8oE@coplandos.local \
    --to=vrzh@vrzh.net \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox