* [PATCH] staging: media: atomisp: Minor code style changes
@ 2021-04-12 16:02 Martiros Shakhzadyan
2021-04-13 14:41 ` Hans Verkuil
0 siblings, 1 reply; 5+ messages in thread
From: Martiros Shakhzadyan @ 2021-04-12 16:02 UTC (permalink / raw)
To: mchehab; +Cc: sakari.ailus, jacopo, linux-media, vrzh
Fixed line continuation and parenthesis alignment issues.
Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net>
---
drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
index 912eadaffc44..90a985ee25fa 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
@@ -49,8 +49,8 @@ static int ov2722_read_reg(struct i2c_client *client,
return -ENODEV;
}
- if (data_length != OV2722_8BIT && data_length != OV2722_16BIT
- && data_length != OV2722_32BIT) {
+ if (data_length != OV2722_8BIT && data_length != OV2722_16BIT &&
+ data_length != OV2722_32BIT) {
dev_err(&client->dev, "%s error, invalid data length\n",
__func__);
return -EINVAL;
@@ -212,8 +212,8 @@ static int __ov2722_buf_reg_array(struct i2c_client *client,
}
static int __ov2722_write_reg_is_consecutive(struct i2c_client *client,
- struct ov2722_write_ctrl *ctrl,
- const struct ov2722_reg *next)
+ struct ov2722_write_ctrl *ctrl,
+ const struct ov2722_reg *next)
{
if (ctrl->index == 0)
return 1;
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] staging: media: atomisp: Minor code style changes
2021-04-12 16:02 [PATCH] staging: media: atomisp: Minor code style changes Martiros Shakhzadyan
@ 2021-04-13 14:41 ` Hans Verkuil
2021-04-13 17:55 ` Martiros Shakhzadyan
0 siblings, 1 reply; 5+ messages in thread
From: Hans Verkuil @ 2021-04-13 14:41 UTC (permalink / raw)
To: Martiros Shakhzadyan, mchehab; +Cc: sakari.ailus, jacopo, linux-media
Please repost with a '[PATCHv3]' in the subject.
This version should have been '[PATCHv2]', but you forgot the v2 part :-)
It's important, since now I had no indication that the previous patch was superseded
and I tried to apply both, thus discovering that the older one should have been skipped.
Regards,
Hans
On 12/04/2021 18:02, Martiros Shakhzadyan wrote:
> Fixed line continuation and parenthesis alignment issues.
>
> Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net>
> ---
> drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> index 912eadaffc44..90a985ee25fa 100644
> --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> @@ -49,8 +49,8 @@ static int ov2722_read_reg(struct i2c_client *client,
> return -ENODEV;
> }
>
> - if (data_length != OV2722_8BIT && data_length != OV2722_16BIT
> - && data_length != OV2722_32BIT) {
> + if (data_length != OV2722_8BIT && data_length != OV2722_16BIT &&
> + data_length != OV2722_32BIT) {
> dev_err(&client->dev, "%s error, invalid data length\n",
> __func__);
> return -EINVAL;
> @@ -212,8 +212,8 @@ static int __ov2722_buf_reg_array(struct i2c_client *client,
> }
>
> static int __ov2722_write_reg_is_consecutive(struct i2c_client *client,
> - struct ov2722_write_ctrl *ctrl,
> - const struct ov2722_reg *next)
> + struct ov2722_write_ctrl *ctrl,
> + const struct ov2722_reg *next)
> {
> if (ctrl->index == 0)
> return 1;
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] staging: media: atomisp: Minor code style changes
2021-04-13 14:41 ` Hans Verkuil
@ 2021-04-13 17:55 ` Martiros Shakhzadyan
0 siblings, 0 replies; 5+ messages in thread
From: Martiros Shakhzadyan @ 2021-04-13 17:55 UTC (permalink / raw)
To: Hans Verkuil; +Cc: sakari.ailus, linux-media
On Tue, Apr 13, 2021 at 04:41:02PM +0200, Hans Verkuil wrote:
> Please repost with a '[PATCHv3]' in the subject.
>
> This version should have been '[PATCHv2]', but you forgot the v2 part :-)
>
> It's important, since now I had no indication that the previous patch was superseded
> and I tried to apply both, thus discovering that the older one should have been skipped.
>
> Regards,
>
> Hans
>
Got it! Will do that now - thanks for your patience :)
> On 12/04/2021 18:02, Martiros Shakhzadyan wrote:
> > Fixed line continuation and parenthesis alignment issues.
> >
> > Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net>
> > ---
> > drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> > index 912eadaffc44..90a985ee25fa 100644
> > --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> > +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> > @@ -49,8 +49,8 @@ static int ov2722_read_reg(struct i2c_client *client,
> > return -ENODEV;
> > }
> >
> > - if (data_length != OV2722_8BIT && data_length != OV2722_16BIT
> > - && data_length != OV2722_32BIT) {
> > + if (data_length != OV2722_8BIT && data_length != OV2722_16BIT &&
> > + data_length != OV2722_32BIT) {
> > dev_err(&client->dev, "%s error, invalid data length\n",
> > __func__);
> > return -EINVAL;
> > @@ -212,8 +212,8 @@ static int __ov2722_buf_reg_array(struct i2c_client *client,
> > }
> >
> > static int __ov2722_write_reg_is_consecutive(struct i2c_client *client,
> > - struct ov2722_write_ctrl *ctrl,
> > - const struct ov2722_reg *next)
> > + struct ov2722_write_ctrl *ctrl,
> > + const struct ov2722_reg *next)
> > {
> > if (ctrl->index == 0)
> > return 1;
> >
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: media: atomisp: Coding style fixes
@ 2021-04-12 2:35 Martiros Shakhzadyan
2021-04-12 2:35 ` [PATCH] staging: media: atomisp: Minor code style changes Martiros Shakhzadyan
0 siblings, 1 reply; 5+ messages in thread
From: Martiros Shakhzadyan @ 2021-04-12 2:35 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Martiros Shakhzadyan, Sakari Ailus, linux-media
The following set of patches fixes coding style issues in
atomisp-ov2722.
Martiros Shakhzadyan (3):
staging: media: atomisp: Removed a superfluous else clause
staging: media: atomisp: Removed a function entry log
staging: media: atomisp: Minor code style changes
.../media/atomisp/i2c/atomisp-ov2722.c | 20 +++++++++----------
1 file changed, 9 insertions(+), 11 deletions(-)
--
2.31.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: media: atomisp: Minor code style changes
2021-04-12 2:35 [PATCH] staging: media: atomisp: Coding style fixes Martiros Shakhzadyan
@ 2021-04-12 2:35 ` Martiros Shakhzadyan
2021-04-12 9:40 ` Jacopo Mondi
0 siblings, 1 reply; 5+ messages in thread
From: Martiros Shakhzadyan @ 2021-04-12 2:35 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Martiros Shakhzadyan, Sakari Ailus, linux-media
Fixed line continuation and parenthesis alignment issues.
Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net>
squashme
---
drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
index 912eadaffc44..90a985ee25fa 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
@@ -49,8 +49,8 @@ static int ov2722_read_reg(struct i2c_client *client,
return -ENODEV;
}
- if (data_length != OV2722_8BIT && data_length != OV2722_16BIT
- && data_length != OV2722_32BIT) {
+ if (data_length != OV2722_8BIT && data_length != OV2722_16BIT &&
+ data_length != OV2722_32BIT) {
dev_err(&client->dev, "%s error, invalid data length\n",
__func__);
return -EINVAL;
@@ -212,8 +212,8 @@ static int __ov2722_buf_reg_array(struct i2c_client *client,
}
static int __ov2722_write_reg_is_consecutive(struct i2c_client *client,
- struct ov2722_write_ctrl *ctrl,
- const struct ov2722_reg *next)
+ struct ov2722_write_ctrl *ctrl,
+ const struct ov2722_reg *next)
{
if (ctrl->index == 0)
return 1;
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] staging: media: atomisp: Minor code style changes
2021-04-12 2:35 ` [PATCH] staging: media: atomisp: Minor code style changes Martiros Shakhzadyan
@ 2021-04-12 9:40 ` Jacopo Mondi
0 siblings, 0 replies; 5+ messages in thread
From: Jacopo Mondi @ 2021-04-12 9:40 UTC (permalink / raw)
To: Martiros Shakhzadyan; +Cc: Mauro Carvalho Chehab, Sakari Ailus, linux-media
Hi Martiros,
On Sun, Apr 11, 2021 at 10:35:58PM -0400, Martiros Shakhzadyan wrote:
> Fixed line continuation and parenthesis alignment issues.
>
> Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net>
>
> squashme
This line should probably be dropped :)
> ---
> drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> index 912eadaffc44..90a985ee25fa 100644
> --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> @@ -49,8 +49,8 @@ static int ov2722_read_reg(struct i2c_client *client,
> return -ENODEV;
> }
>
> - if (data_length != OV2722_8BIT && data_length != OV2722_16BIT
> - && data_length != OV2722_32BIT) {
> + if (data_length != OV2722_8BIT && data_length != OV2722_16BIT &&
> + data_length != OV2722_32BIT) {
Does checkpatch report this one ?
> dev_err(&client->dev, "%s error, invalid data length\n",
> __func__);
> return -EINVAL;
> @@ -212,8 +212,8 @@ static int __ov2722_buf_reg_array(struct i2c_client *client,
> }
>
> static int __ov2722_write_reg_is_consecutive(struct i2c_client *client,
> - struct ov2722_write_ctrl *ctrl,
> - const struct ov2722_reg *next)
> + struct ov2722_write_ctrl *ctrl,
> + const struct ov2722_reg *next)
These are probably 2 separate changes, but give this is just a style
fix I think it's ok...
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
> {
> if (ctrl->index == 0)
> return 1;
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-13 17:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-12 16:02 [PATCH] staging: media: atomisp: Minor code style changes Martiros Shakhzadyan
2021-04-13 14:41 ` Hans Verkuil
2021-04-13 17:55 ` Martiros Shakhzadyan
-- strict thread matches above, loose matches on Subject: below --
2021-04-12 2:35 [PATCH] staging: media: atomisp: Coding style fixes Martiros Shakhzadyan
2021-04-12 2:35 ` [PATCH] staging: media: atomisp: Minor code style changes Martiros Shakhzadyan
2021-04-12 9:40 ` Jacopo Mondi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox