* [PATCH v1 1/1] media: i2c: max9286: Get rid of duplicate of_node assignment
@ 2021-12-02 21:03 Andy Shevchenko
2021-12-02 21:35 ` Laurent Pinchart
2021-12-03 13:09 ` Kieran Bingham
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2021-12-02 21:03 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Laurent Pinchart, Jacopo Mondi,
Kieran Bingham, linux-media, linux-kernel
Cc: Niklas Söderlund, Mauro Carvalho Chehab, Andy Shevchenko
GPIO library does copy the of_node from the parent device of
the GPIO chip, there is no need to repeat this in the individual
drivers. Remove assignment here.
For the details one may look into the of_gpio_dev_init() implementation.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/media/i2c/max9286.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
index 7c663fd587bb..a662d3aa0641 100644
--- a/drivers/media/i2c/max9286.c
+++ b/drivers/media/i2c/max9286.c
@@ -1055,7 +1055,6 @@ static int max9286_register_gpio(struct max9286_priv *priv)
gpio->label = dev_name(dev);
gpio->parent = dev;
gpio->owner = THIS_MODULE;
- gpio->of_node = dev->of_node;
gpio->ngpio = 2;
gpio->base = -1;
gpio->set = max9286_gpio_set;
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] media: i2c: max9286: Get rid of duplicate of_node assignment
2021-12-02 21:03 [PATCH v1 1/1] media: i2c: max9286: Get rid of duplicate of_node assignment Andy Shevchenko
@ 2021-12-02 21:35 ` Laurent Pinchart
2021-12-03 13:09 ` Kieran Bingham
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2021-12-02 21:35 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Mauro Carvalho Chehab, Jacopo Mondi, Kieran Bingham, linux-media,
linux-kernel, Niklas Söderlund, Mauro Carvalho Chehab
Hi Andy,
Thank you for the patch.
On Thu, Dec 02, 2021 at 11:03:35PM +0200, Andy Shevchenko wrote:
> GPIO library does copy the of_node from the parent device of
> the GPIO chip, there is no need to repeat this in the individual
> drivers. Remove assignment here.
>
> For the details one may look into the of_gpio_dev_init() implementation.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/max9286.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
> index 7c663fd587bb..a662d3aa0641 100644
> --- a/drivers/media/i2c/max9286.c
> +++ b/drivers/media/i2c/max9286.c
> @@ -1055,7 +1055,6 @@ static int max9286_register_gpio(struct max9286_priv *priv)
> gpio->label = dev_name(dev);
> gpio->parent = dev;
> gpio->owner = THIS_MODULE;
> - gpio->of_node = dev->of_node;
> gpio->ngpio = 2;
> gpio->base = -1;
> gpio->set = max9286_gpio_set;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] media: i2c: max9286: Get rid of duplicate of_node assignment
2021-12-02 21:03 [PATCH v1 1/1] media: i2c: max9286: Get rid of duplicate of_node assignment Andy Shevchenko
2021-12-02 21:35 ` Laurent Pinchart
@ 2021-12-03 13:09 ` Kieran Bingham
1 sibling, 0 replies; 3+ messages in thread
From: Kieran Bingham @ 2021-12-03 13:09 UTC (permalink / raw)
To: Andy Shevchenko, Jacopo Mondi, Laurent Pinchart,
Mauro Carvalho Chehab, linux-kernel, linux-media
Cc: Niklas Söderlund, Mauro Carvalho Chehab, Andy Shevchenko
Quoting Andy Shevchenko (2021-12-02 21:03:35)
> GPIO library does copy the of_node from the parent device of
> the GPIO chip, there is no need to repeat this in the individual
> drivers. Remove assignment here.
>
> For the details one may look into the of_gpio_dev_init() implementation.
I see it.
Thanks,
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/media/i2c/max9286.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
> index 7c663fd587bb..a662d3aa0641 100644
> --- a/drivers/media/i2c/max9286.c
> +++ b/drivers/media/i2c/max9286.c
> @@ -1055,7 +1055,6 @@ static int max9286_register_gpio(struct max9286_priv *priv)
> gpio->label = dev_name(dev);
> gpio->parent = dev;
> gpio->owner = THIS_MODULE;
> - gpio->of_node = dev->of_node;
> gpio->ngpio = 2;
> gpio->base = -1;
> gpio->set = max9286_gpio_set;
> --
> 2.33.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-03 13:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-02 21:03 [PATCH v1 1/1] media: i2c: max9286: Get rid of duplicate of_node assignment Andy Shevchenko
2021-12-02 21:35 ` Laurent Pinchart
2021-12-03 13:09 ` Kieran Bingham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox