From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Bingbu Cao <bingbu.cao@intel.com>
Cc: linux-media@vger.kernel.org, shawnx.tu@intel.com,
senozhatsky@chromium.org, tfiga@chromium.org,
bingbu.cao@linux.intel.com, andy.yeh@intel.com
Subject: Re: [PATCH] media: ov5675: use group write to update digital gain
Date: Wed, 29 Dec 2021 11:41:33 +0200 [thread overview]
Message-ID: <YcwtTaenpE1OK0TP@paasikivi.fi.intel.com> (raw)
In-Reply-To: <1640768259-18070-1-git-send-email-bingbu.cao@intel.com>
Hi Bingbu,
On Wed, Dec 29, 2021 at 04:57:39PM +0800, Bingbu Cao wrote:
> MWB gain register are used to set gain for each mwb channel mannually.
> However, it will involve some artifacts at low light environment as gain
> cannot be applied to each channel synchronously. Update the driver to use
> group write for digital gain to make the sure RGB digital gain be applied
> together at frame boundary.
How about the analogue gain and exposure time?
Shouldn't they be applied similarly as well? Adding two more writes
increases the probability of missing a frame there.
This is of course a trick since the control framework doesn't really
support this, but I think this support should be added.
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2021-12-29 9:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 8:57 [PATCH] media: ov5675: use group write to update digital gain Bingbu Cao
2021-12-29 9:41 ` Sakari Ailus [this message]
2021-12-29 10:00 ` Cao, Bingbu
2022-01-10 11:32 ` Sakari Ailus
2022-01-11 3:22 ` Bingbu Cao
2022-01-11 4:27 ` Tomasz Figa
2022-01-27 3:14 ` Bingbu Cao
2022-01-28 9:42 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcwtTaenpE1OK0TP@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andy.yeh@intel.com \
--cc=bingbu.cao@intel.com \
--cc=bingbu.cao@linux.intel.com \
--cc=linux-media@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=shawnx.tu@intel.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox