From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Bingbu Cao <bingbu.cao@linux.intel.com>
Cc: Tomasz Figa <tfiga@chromium.org>,
"Cao, Bingbu" <bingbu.cao@intel.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"Tu, ShawnX" <shawnx.tu@intel.com>,
"senozhatsky@chromium.org" <senozhatsky@chromium.org>,
"Yeh, Andy" <andy.yeh@intel.com>
Subject: Re: [PATCH] media: ov5675: use group write to update digital gain
Date: Fri, 28 Jan 2022 11:42:57 +0200 [thread overview]
Message-ID: <YfO6ofAOSwquG2FW@paasikivi.fi.intel.com> (raw)
In-Reply-To: <c52bf111-41c3-4591-cc0e-1c64d7ec6e41@linux.intel.com>
Hi Bingbu,
On Thu, Jan 27, 2022 at 11:14:56AM +0800, Bingbu Cao wrote:
> Sakari,
>
> I agree with Tomasz, the group write will not cause timing issues, instead it will help
> on that. So we did not need to group hold exposure and digital gain along with analog
> gain. Driver can not make the policy that the exposure, a-gain and d-gain are applied
> together.
I'll take the patch but we're leaving some technical debt here, admittedly
much of which was there to begin with.
Please wrap before 80.
--
Kind regards,
Sakari Ailus
prev parent reply other threads:[~2022-01-28 9:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 8:57 [PATCH] media: ov5675: use group write to update digital gain Bingbu Cao
2021-12-29 9:41 ` Sakari Ailus
2021-12-29 10:00 ` Cao, Bingbu
2022-01-10 11:32 ` Sakari Ailus
2022-01-11 3:22 ` Bingbu Cao
2022-01-11 4:27 ` Tomasz Figa
2022-01-27 3:14 ` Bingbu Cao
2022-01-28 9:42 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfO6ofAOSwquG2FW@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andy.yeh@intel.com \
--cc=bingbu.cao@intel.com \
--cc=bingbu.cao@linux.intel.com \
--cc=linux-media@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=shawnx.tu@intel.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox