[PATCH RESEND] media: i2c: Fix pixel array positions in ov8865

[PATCH RESEND] media: i2c: Fix pixel array positions in ov8865

[Daniel Scally]

The ov8865's datasheet gives the pixel array as 3296x2528, and the
active portion as the centre 3264x2448. This makes for a top offset
of 40 and a left offset of 16, not 32 and 80.

Fixes: acd25e220921 ("media: i2c: Add .get_selection() support to ov8865")

Reported-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
Signed-off-by: Daniel Scally <djrscally@gmail.com>
---

Apologies; sent to the wrong list initially

 drivers/media/i2c/ov8865.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c
index d9d016cfa9ac..53e21ae8e886 100644
--- a/drivers/media/i2c/ov8865.c
+++ b/drivers/media/i2c/ov8865.c
@@ -457,8 +457,8 @@
 
 #define OV8865_NATIVE_WIDTH			3296
 #define OV8865_NATIVE_HEIGHT			2528
-#define OV8865_ACTIVE_START_TOP			32
-#define OV8865_ACTIVE_START_LEFT		80
+#define OV8865_ACTIVE_START_TOP			40
+#define OV8865_ACTIVE_START_LEFT		16
 #define OV8865_ACTIVE_WIDTH			3264
 #define OV8865_ACTIVE_HEIGHT			2448
 
-- 
2.25.1

Re: [PATCH RESEND] media: i2c: Fix pixel array positions in ov8865

[Paul Kocialkowski]

[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]

Hi Daniel,

On Thu 03 Feb 22, 21:33, Daniel Scally wrote:
> The ov8865's datasheet gives the pixel array as 3296x2528, and the
> active portion as the centre 3264x2448. This makes for a top offset
> of 40 and a left offset of 16, not 32 and 80.

Yep that makes better sense to me!

Could you also invert the lines so we have left first, matching
width being defined first in other instances?

Thanks!

Paul

> Fixes: acd25e220921 ("media: i2c: Add .get_selection() support to ov8865")
> 
> Reported-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
> Signed-off-by: Daniel Scally <djrscally@gmail.com>
> ---
> 
> Apologies; sent to the wrong list initially
> 
>  drivers/media/i2c/ov8865.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c
> index d9d016cfa9ac..53e21ae8e886 100644
> --- a/drivers/media/i2c/ov8865.c
> +++ b/drivers/media/i2c/ov8865.c
> @@ -457,8 +457,8 @@
>  
>  #define OV8865_NATIVE_WIDTH			3296
>  #define OV8865_NATIVE_HEIGHT			2528
> -#define OV8865_ACTIVE_START_TOP			32
> -#define OV8865_ACTIVE_START_LEFT		80
> +#define OV8865_ACTIVE_START_TOP			40
> +#define OV8865_ACTIVE_START_LEFT		16
>  #define OV8865_ACTIVE_WIDTH			3264
>  #define OV8865_ACTIVE_HEIGHT			2448
>  
> -- 
> 2.25.1
> 

-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH RESEND] media: i2c: Fix pixel array positions in ov8865

[Daniel Scally]

Hi Paul

On 04/02/2022 09:04, Paul Kocialkowski wrote:
> Hi Daniel,
>
> On Thu 03 Feb 22, 21:33, Daniel Scally wrote:
>> The ov8865's datasheet gives the pixel array as 3296x2528, and the
>> active portion as the centre 3264x2448. This makes for a top offset
>> of 40 and a left offset of 16, not 32 and 80.
> Yep that makes better sense to me!
>
> Could you also invert the lines so we have left first, matching
> width being defined first in other instances?


Sure thing - I'll post another shortly

>
> Thanks!
>
> Paul
>
>> Fixes: acd25e220921 ("media: i2c: Add .get_selection() support to ov8865")
>>
>> Reported-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
>> Signed-off-by: Daniel Scally <djrscally@gmail.com>
>> ---
>>
>> Apologies; sent to the wrong list initially
>>
>>  drivers/media/i2c/ov8865.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c
>> index d9d016cfa9ac..53e21ae8e886 100644
>> --- a/drivers/media/i2c/ov8865.c
>> +++ b/drivers/media/i2c/ov8865.c
>> @@ -457,8 +457,8 @@
>>  
>>  #define OV8865_NATIVE_WIDTH			3296
>>  #define OV8865_NATIVE_HEIGHT			2528
>> -#define OV8865_ACTIVE_START_TOP			32
>> -#define OV8865_ACTIVE_START_LEFT		80
>> +#define OV8865_ACTIVE_START_TOP			40
>> +#define OV8865_ACTIVE_START_LEFT		16
>>  #define OV8865_ACTIVE_WIDTH			3264
>>  #define OV8865_ACTIVE_HEIGHT			2448
>>  
>> -- 
>> 2.25.1
>>