Linux Media Controller development
 help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org, Jacopo Mondi <jacopo@jmondi.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH] media: platform: imx-mipi-csis: Add dependency on VIDEO_DEV
Date: Sat, 2 Apr 2022 08:43:16 -0300	[thread overview]
Message-ID: <Ykg21DbuHMRvJrcK@eze-laptop> (raw)
In-Reply-To: <20220331123151.1953-1-laurent.pinchart@ideasonboard.com>

Hi Laurent,

On Thu, Mar 31, 2022 at 03:31:51PM +0300, Laurent Pinchart wrote:
> The imx-mipi-csis driver (VIDEO_IMX_MIPI_CSIS) lost its dependency on
> VIDEO_DEV in commit 63fe3d27b226 ("media: platform/*/Kconfig: make
> manufacturer menus more uniform"). This causes build failures with
> configurations that don't have VIDEO_DEV set. Fix it by restoring the
> dependency.
> 
> Fixes: 63fe3d27b226 ("media: platform/*/Kconfig: make manufacturer menus more uniform")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>

Thanks,
Ezequiel

> ---
> Mauro, this fixes a regression in Linus' master branch, and is thus a
> candidate fix for v5.18.
> ---
>  drivers/media/platform/nxp/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/nxp/Kconfig b/drivers/media/platform/nxp/Kconfig
> index 28f2bafc14d2..5afa373e534f 100644
> --- a/drivers/media/platform/nxp/Kconfig
> +++ b/drivers/media/platform/nxp/Kconfig
> @@ -7,6 +7,7 @@ comment "NXP media platform drivers"
>  config VIDEO_IMX_MIPI_CSIS
>  	tristate "NXP MIPI CSI-2 CSIS receiver found on i.MX7 and i.MX8 models"
>  	depends on ARCH_MXC || COMPILE_TEST
> +	depends on VIDEO_DEV
>  	select MEDIA_CONTROLLER
>  	select V4L2_FWNODE
>  	select VIDEO_V4L2_SUBDEV_API
> 
> base-commit: 787af64d05cd528aac9ad16752d11bb1c6061bb9
> -- 
> Regards,
> 
> Laurent Pinchart
> 

      reply	other threads:[~2022-04-02 11:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31 12:31 [PATCH] media: platform: imx-mipi-csis: Add dependency on VIDEO_DEV Laurent Pinchart
2022-04-02 11:43 ` Ezequiel Garcia [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ykg21DbuHMRvJrcK@eze-laptop \
    --to=ezequiel@vanguardiasur.com.ar \
    --cc=jacopo@jmondi.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox