* [PATCH] media: platform: imx-mipi-csis: Add dependency on VIDEO_DEV
@ 2022-03-31 12:31 Laurent Pinchart
2022-04-02 11:43 ` Ezequiel Garcia
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Pinchart @ 2022-03-31 12:31 UTC (permalink / raw)
To: linux-media; +Cc: Jacopo Mondi, Mauro Carvalho Chehab
The imx-mipi-csis driver (VIDEO_IMX_MIPI_CSIS) lost its dependency on
VIDEO_DEV in commit 63fe3d27b226 ("media: platform/*/Kconfig: make
manufacturer menus more uniform"). This causes build failures with
configurations that don't have VIDEO_DEV set. Fix it by restoring the
dependency.
Fixes: 63fe3d27b226 ("media: platform/*/Kconfig: make manufacturer menus more uniform")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Mauro, this fixes a regression in Linus' master branch, and is thus a
candidate fix for v5.18.
---
drivers/media/platform/nxp/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/nxp/Kconfig b/drivers/media/platform/nxp/Kconfig
index 28f2bafc14d2..5afa373e534f 100644
--- a/drivers/media/platform/nxp/Kconfig
+++ b/drivers/media/platform/nxp/Kconfig
@@ -7,6 +7,7 @@ comment "NXP media platform drivers"
config VIDEO_IMX_MIPI_CSIS
tristate "NXP MIPI CSI-2 CSIS receiver found on i.MX7 and i.MX8 models"
depends on ARCH_MXC || COMPILE_TEST
+ depends on VIDEO_DEV
select MEDIA_CONTROLLER
select V4L2_FWNODE
select VIDEO_V4L2_SUBDEV_API
base-commit: 787af64d05cd528aac9ad16752d11bb1c6061bb9
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] media: platform: imx-mipi-csis: Add dependency on VIDEO_DEV
2022-03-31 12:31 [PATCH] media: platform: imx-mipi-csis: Add dependency on VIDEO_DEV Laurent Pinchart
@ 2022-04-02 11:43 ` Ezequiel Garcia
0 siblings, 0 replies; 2+ messages in thread
From: Ezequiel Garcia @ 2022-04-02 11:43 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-media, Jacopo Mondi, Mauro Carvalho Chehab
Hi Laurent,
On Thu, Mar 31, 2022 at 03:31:51PM +0300, Laurent Pinchart wrote:
> The imx-mipi-csis driver (VIDEO_IMX_MIPI_CSIS) lost its dependency on
> VIDEO_DEV in commit 63fe3d27b226 ("media: platform/*/Kconfig: make
> manufacturer menus more uniform"). This causes build failures with
> configurations that don't have VIDEO_DEV set. Fix it by restoring the
> dependency.
>
> Fixes: 63fe3d27b226 ("media: platform/*/Kconfig: make manufacturer menus more uniform")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Thanks,
Ezequiel
> ---
> Mauro, this fixes a regression in Linus' master branch, and is thus a
> candidate fix for v5.18.
> ---
> drivers/media/platform/nxp/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/nxp/Kconfig b/drivers/media/platform/nxp/Kconfig
> index 28f2bafc14d2..5afa373e534f 100644
> --- a/drivers/media/platform/nxp/Kconfig
> +++ b/drivers/media/platform/nxp/Kconfig
> @@ -7,6 +7,7 @@ comment "NXP media platform drivers"
> config VIDEO_IMX_MIPI_CSIS
> tristate "NXP MIPI CSI-2 CSIS receiver found on i.MX7 and i.MX8 models"
> depends on ARCH_MXC || COMPILE_TEST
> + depends on VIDEO_DEV
> select MEDIA_CONTROLLER
> select V4L2_FWNODE
> select VIDEO_V4L2_SUBDEV_API
>
> base-commit: 787af64d05cd528aac9ad16752d11bb1c6061bb9
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-02 11:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-31 12:31 [PATCH] media: platform: imx-mipi-csis: Add dependency on VIDEO_DEV Laurent Pinchart
2022-04-02 11:43 ` Ezequiel Garcia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox