From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: linux-media@vger.kernel.org, Rui Miguel Silva <rmfrfs@gmail.com>,
Steve Longerbeam <slongerbeam@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Paul Elder <paul.elder@ideasonboard.com>,
Jacopo Mondi <jacopo@jmondi.org>,
kernel@pengutronix.de, linux-imx@nxp.com
Subject: Re: [PATCH 1/6] media: imx: Decouple imx8mq-mipi-csi2 from imx7-media-csi
Date: Tue, 13 Sep 2022 18:26:09 +0300 [thread overview]
Message-ID: <YyChEb5jevzr73C2@pendragon.ideasonboard.com> (raw)
In-Reply-To: <c61ad1e9c2ab54d7416bd4efbb9d92924530ab11.camel@puri.sm>
Hi Martin,
On Tue, Sep 13, 2022 at 05:10:12PM +0200, Martin Kepplinger wrote:
> Am Freitag, dem 09.09.2022 um 21:22 +0300 schrieb Laurent Pinchart:
> > Hi Martin,
> >
> > It seems I forgot to CC you on this patch, sorry about that. Could you
> > give it a look ? I'd like to send a pull request for the series next week.
>
> hi Laurent,
>
> this change should be ok. thanks for the config-change warning. I'm
> very much looking forward to seeing some of these drivers moved to
> drivers/media.
>
> Depeding on how that goes I'll follow with the imx8mq-mipi-csi2 driver
> (if you don't want to do it).
I don't have plans to address that driver, so I'll be happy to let you
handle it :-)
> thanks again,
> martin
>
> > On Wed, Sep 07, 2022 at 11:04:19PM +0300, Laurent Pinchart wrote:
> > > The imx8mq-mipi-csi2 driver targets SoCs that also run the
> > > imx7-media-csi driver, but they are distinct. Decouple them in
> > > Kconfig
> > > to prepare for destaging of the imx7-media-csi driver.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > ---
> > > drivers/staging/media/imx/Kconfig | 10 ++++++++++
> > > drivers/staging/media/imx/Makefile | 2 +-
> > > 2 files changed, 11 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/media/imx/Kconfig
> > > b/drivers/staging/media/imx/Kconfig
> > > index 0bacac302d7e..bfb849701489 100644
> > > --- a/drivers/staging/media/imx/Kconfig
> > > +++ b/drivers/staging/media/imx/Kconfig
> > > @@ -32,3 +32,13 @@ config VIDEO_IMX7_CSI
> > > i.MX6UL/L, i.MX7 or i.MX8M.
> > > endmenu
> > > endif
> > > +
> > > +config VIDEO_IMX8MQ_MIPI_CSI2
> > > + tristate "NXP i.MX8MQ MIPI CSI-2 receiver"
> > > + depends on ARCH_MXC || COMPILE_TEST
> > > + depends on VIDEO_DEV
> > > + select MEDIA_CONTROLLER
> > > + select V4L2_FWNODE
> > > + select VIDEO_V4L2_SUBDEV_API
> > > + help
> > > + V4L2 driver for the MIPI CSI-2 receiver found in the
> > > i.MX8MQ SoC.
> > > diff --git a/drivers/staging/media/imx/Makefile
> > > b/drivers/staging/media/imx/Makefile
> > > index d82be898145b..cef9f30eb401 100644
> > > --- a/drivers/staging/media/imx/Makefile
> > > +++ b/drivers/staging/media/imx/Makefile
> > > @@ -15,4 +15,4 @@ obj-$(CONFIG_VIDEO_IMX_CSI) += imx6-media-csi.o
> > > obj-$(CONFIG_VIDEO_IMX_CSI) += imx6-mipi-csi2.o
> > >
> > > obj-$(CONFIG_VIDEO_IMX7_CSI) += imx7-media-csi.o
> > > -obj-$(CONFIG_VIDEO_IMX7_CSI) += imx8mq-mipi-csi2.o
> > > +obj-$(CONFIG_VIDEO_IMX8MQ_MIPI_CSI2) += imx8mq-mipi-csi2.o
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-09-13 16:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 20:04 [PATCH 0/6] media: imx: imx7-media-csi: Destage driver Laurent Pinchart
2022-09-07 20:04 ` [PATCH 1/6] media: imx: Decouple imx8mq-mipi-csi2 from imx7-media-csi Laurent Pinchart
2022-09-08 3:58 ` paul.elder
2022-09-09 18:22 ` Laurent Pinchart
2022-09-13 15:10 ` Martin Kepplinger
2022-09-13 15:26 ` Laurent Pinchart [this message]
2022-09-07 20:04 ` [PATCH 2/6] media: imx: Unstage the imx7-media-csi driver Laurent Pinchart
2022-09-08 4:04 ` paul.elder
2022-09-08 15:06 ` Rui Miguel Silva
2022-09-08 15:18 ` Laurent Pinchart
2022-09-08 15:46 ` Rui Miguel Silva
2022-09-07 20:04 ` [PATCH 3/6] staging: media: imx: Drop imx_media_subdev_bound() Laurent Pinchart
2022-09-08 4:08 ` paul.elder
2022-09-07 20:04 ` [PATCH 4/6] staging: media: imx: Drop IMX_MEDIA_GRP_ID_CSI Laurent Pinchart
2022-09-08 4:10 ` paul.elder
2022-09-07 20:04 ` [PATCH 5/6] staging: media: imx: Drop unused helper functions Laurent Pinchart
2022-09-08 4:12 ` paul.elder
2022-09-07 20:04 ` [PATCH 6/6] staging: media: imx: Make imx_media_of_add_csi() static Laurent Pinchart
2022-09-08 4:16 ` paul.elder
2022-09-13 9:48 ` [PATCH 0/6] media: imx: imx7-media-csi: Destage driver Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyChEb5jevzr73C2@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=jacopo@jmondi.org \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-media@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
--cc=p.zabel@pengutronix.de \
--cc=paul.elder@ideasonboard.com \
--cc=rmfrfs@gmail.com \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox