From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Alexander Stein <alexander.stein@ew.tq-group.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 1/1] media: i2c: imx290: Add missing \n on dev_err_probe() message
Date: Fri, 7 Apr 2023 21:35:48 +0300 [thread overview]
Message-ID: <ZDBihOhzZInuHM42@kekkonen.localdomain> (raw)
In-Reply-To: <20230407014407.GC31272@pendragon.ideasonboard.com>
On Fri, Apr 07, 2023 at 04:44:07AM +0300, Laurent Pinchart wrote:
> Hi Alexander,
>
> Thank you for the patch.
>
> On Thu, Apr 06, 2023 at 11:55:51AM +0200, Alexander Stein wrote:
> > Also dev_err_probe message require a trailing \n.
>
> There should be a blank line here.
>
> > Fixes: 63127235bebd ("media: i2c: imx290: Use dev_err_probe()")
> >
>
> And none here.
>
> But the bug wasn't introduced in the above commit, the \n was missing
> before that, right from the start when the driver was merged in commit
> 828dbc299278 ("media: i2c: Add IMX290 CMOS image sensor driver"). I
> would use that commit in the Fixes tag, or drop the Fixes tag
> altogether.
I dropped it. This is not a grave problem.
>
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks!
--
Sakari Ailus
prev parent reply other threads:[~2023-04-07 18:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 9:55 [PATCH 1/1] media: i2c: imx290: Add missing \n on dev_err_probe() message Alexander Stein
2023-04-07 1:44 ` Laurent Pinchart
2023-04-07 18:35 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDBihOhzZInuHM42@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox