* [PATCH 1/1] media: i2c: imx290: Add missing \n on dev_err_probe() message
@ 2023-04-06 9:55 Alexander Stein
2023-04-07 1:44 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Stein @ 2023-04-06 9:55 UTC (permalink / raw)
To: Manivannan Sadhasivam, Mauro Carvalho Chehab, Sakari Ailus,
Laurent Pinchart
Cc: Alexander Stein, linux-media
Also dev_err_probe message require a trailing \n.
Fixes: 63127235bebd ("media: i2c: imx290: Use dev_err_probe()")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
drivers/media/i2c/imx290.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
index 94bba482af38..5ea25b7acc55 100644
--- a/drivers/media/i2c/imx290.c
+++ b/drivers/media/i2c/imx290.c
@@ -1602,7 +1602,7 @@ static int imx290_probe(struct i2c_client *client)
imx290->xclk = devm_clk_get(dev, "xclk");
if (IS_ERR(imx290->xclk))
return dev_err_probe(dev, PTR_ERR(imx290->xclk),
- "Could not get xclk");
+ "Could not get xclk\n");
ret = imx290_get_regulators(dev, imx290);
if (ret < 0)
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] media: i2c: imx290: Add missing \n on dev_err_probe() message
2023-04-06 9:55 [PATCH 1/1] media: i2c: imx290: Add missing \n on dev_err_probe() message Alexander Stein
@ 2023-04-07 1:44 ` Laurent Pinchart
2023-04-07 18:35 ` Sakari Ailus
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2023-04-07 1:44 UTC (permalink / raw)
To: Alexander Stein
Cc: Manivannan Sadhasivam, Mauro Carvalho Chehab, Sakari Ailus,
linux-media
Hi Alexander,
Thank you for the patch.
On Thu, Apr 06, 2023 at 11:55:51AM +0200, Alexander Stein wrote:
> Also dev_err_probe message require a trailing \n.
There should be a blank line here.
> Fixes: 63127235bebd ("media: i2c: imx290: Use dev_err_probe()")
>
And none here.
But the bug wasn't introduced in the above commit, the \n was missing
before that, right from the start when the driver was merged in commit
828dbc299278 ("media: i2c: Add IMX290 CMOS image sensor driver"). I
would use that commit in the Fixes tag, or drop the Fixes tag
altogether.
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/imx290.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
> index 94bba482af38..5ea25b7acc55 100644
> --- a/drivers/media/i2c/imx290.c
> +++ b/drivers/media/i2c/imx290.c
> @@ -1602,7 +1602,7 @@ static int imx290_probe(struct i2c_client *client)
> imx290->xclk = devm_clk_get(dev, "xclk");
> if (IS_ERR(imx290->xclk))
> return dev_err_probe(dev, PTR_ERR(imx290->xclk),
> - "Could not get xclk");
> + "Could not get xclk\n");
>
> ret = imx290_get_regulators(dev, imx290);
> if (ret < 0)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] media: i2c: imx290: Add missing \n on dev_err_probe() message
2023-04-07 1:44 ` Laurent Pinchart
@ 2023-04-07 18:35 ` Sakari Ailus
0 siblings, 0 replies; 3+ messages in thread
From: Sakari Ailus @ 2023-04-07 18:35 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Alexander Stein, Manivannan Sadhasivam, Mauro Carvalho Chehab,
linux-media
On Fri, Apr 07, 2023 at 04:44:07AM +0300, Laurent Pinchart wrote:
> Hi Alexander,
>
> Thank you for the patch.
>
> On Thu, Apr 06, 2023 at 11:55:51AM +0200, Alexander Stein wrote:
> > Also dev_err_probe message require a trailing \n.
>
> There should be a blank line here.
>
> > Fixes: 63127235bebd ("media: i2c: imx290: Use dev_err_probe()")
> >
>
> And none here.
>
> But the bug wasn't introduced in the above commit, the \n was missing
> before that, right from the start when the driver was merged in commit
> 828dbc299278 ("media: i2c: Add IMX290 CMOS image sensor driver"). I
> would use that commit in the Fixes tag, or drop the Fixes tag
> altogether.
I dropped it. This is not a grave problem.
>
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks!
--
Sakari Ailus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-07 18:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-06 9:55 [PATCH 1/1] media: i2c: imx290: Add missing \n on dev_err_probe() message Alexander Stein
2023-04-07 1:44 ` Laurent Pinchart
2023-04-07 18:35 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox