* [PATCH 00/10] Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON @ 2023-11-18 18:04 Heiner Kallweit 2023-11-18 18:05 ` [PATCH 08/10] drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c: " Heiner Kallweit 0 siblings, 1 reply; 4+ messages in thread From: Heiner Kallweit @ 2023-11-18 18:04 UTC (permalink / raw) To: Wolfram Sang, linuxppc-dev Cc: linux-i2c, Heiner Kallweit, Christophe Leroy, Nicholas Piggin, linux-kernel, greybus-dev, linux-staging, linux-media After removal of the legacy eeprom driver the only remaining I2C client device driver supporting I2C_CLASS_SPD is jc42. Because this driver also supports I2C_CLASS_HWMON, adapters don't have to declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON. It's one step towards getting rid of I2C_CLASS_SPD mid-term. Series was created supported by Coccinelle and its splitpatch. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/i2c/busses/i2c-ali1535.c | 2 +- drivers/i2c/busses/i2c-ali1563.c | 2 +- drivers/i2c/busses/i2c-ali15x3.c | 2 +- drivers/i2c/busses/i2c-amd756.c | 2 +- drivers/i2c/busses/i2c-amd8111.c | 2 +- drivers/i2c/busses/i2c-elektor.c | 2 +- drivers/i2c/busses/i2c-gpio.c | 2 +- drivers/i2c/busses/i2c-ibm_iic.c | 2 +- drivers/i2c/busses/i2c-iop3xx.c | 2 +- drivers/i2c/busses/i2c-isch.c | 2 +- drivers/i2c/busses/i2c-kempld.c | 4 ++-- drivers/i2c/busses/i2c-mlxcpld.c | 2 +- drivers/i2c/busses/i2c-nforce2.c | 2 +- drivers/i2c/busses/i2c-pasemi-pci.c | 2 +- drivers/i2c/busses/i2c-piix4.c | 2 +- drivers/i2c/busses/i2c-scmi.c | 2 +- drivers/i2c/busses/i2c-sh7760.c | 2 +- drivers/i2c/busses/i2c-sibyte.c | 4 ++-- drivers/i2c/busses/i2c-sis5595.c | 2 +- drivers/i2c/busses/i2c-sis630.c | 2 +- drivers/i2c/busses/i2c-sis96x.c | 2 +- drivers/i2c/busses/i2c-via.c | 2 +- drivers/i2c/busses/i2c-viapro.c | 2 +- drivers/i2c/busses/scx200_acb.c | 2 +- drivers/i2c/i2c-stub.c | 2 +- drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c | 2 +- drivers/staging/greybus/i2c.c | 2 +- 27 files changed, 29 insertions(+), 29 deletions(-) ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 08/10] drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON 2023-11-18 18:04 [PATCH 00/10] Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON Heiner Kallweit @ 2023-11-18 18:05 ` Heiner Kallweit 2023-11-23 20:55 ` Wolfram Sang 0 siblings, 1 reply; 4+ messages in thread From: Heiner Kallweit @ 2023-11-18 18:05 UTC (permalink / raw) To: Wolfram Sang, Sergey Kozlov Cc: linux-i2c, Heiner Kallweit, Abylay Ospan, Mauro Carvalho Chehab, linux-media, linux-kernel After removal of the legacy eeprom driver the only remaining I2C client device driver supporting I2C_CLASS_SPD is jc42. Because this driver also supports I2C_CLASS_HWMON, adapters don't have to declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON. It's one step towards getting rid of I2C_CLASS_SPD mid-term. Series was created supported by Coccinelle and its splitpatch. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c index bd38ce444..46676f2c8 100644 --- a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c +++ b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c @@ -289,7 +289,7 @@ static const struct i2c_algorithm netup_i2c_algorithm = { static const struct i2c_adapter netup_i2c_adapter = { .owner = THIS_MODULE, .name = NETUP_UNIDVB_NAME, - .class = I2C_CLASS_HWMON | I2C_CLASS_SPD, + .class = I2C_CLASS_HWMON, .algo = &netup_i2c_algorithm, }; ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 08/10] drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON 2023-11-18 18:05 ` [PATCH 08/10] drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c: " Heiner Kallweit @ 2023-11-23 20:55 ` Wolfram Sang 2023-11-24 10:15 ` Heiner Kallweit 0 siblings, 1 reply; 4+ messages in thread From: Wolfram Sang @ 2023-11-23 20:55 UTC (permalink / raw) To: Heiner Kallweit Cc: Sergey Kozlov, linux-i2c, Abylay Ospan, Mauro Carvalho Chehab, linux-media, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1388 bytes --] On Sat, Nov 18, 2023 at 07:05:02PM +0100, Heiner Kallweit wrote: > After removal of the legacy eeprom driver the only remaining I2C > client device driver supporting I2C_CLASS_SPD is jc42. Because this > driver also supports I2C_CLASS_HWMON, adapters don't have to > declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON. > It's one step towards getting rid of I2C_CLASS_SPD mid-term. > > Series was created supported by Coccinelle and its splitpatch. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> As I want to apply this cleanup early in the cycle, could we have an ack for me to modify this subsystem, please? > > --- > drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c > index bd38ce444..46676f2c8 100644 > --- a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c > +++ b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c > @@ -289,7 +289,7 @@ static const struct i2c_algorithm netup_i2c_algorithm = { > static const struct i2c_adapter netup_i2c_adapter = { > .owner = THIS_MODULE, > .name = NETUP_UNIDVB_NAME, > - .class = I2C_CLASS_HWMON | I2C_CLASS_SPD, > + .class = I2C_CLASS_HWMON, > .algo = &netup_i2c_algorithm, > }; > > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 08/10] drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON 2023-11-23 20:55 ` Wolfram Sang @ 2023-11-24 10:15 ` Heiner Kallweit 0 siblings, 0 replies; 4+ messages in thread From: Heiner Kallweit @ 2023-11-24 10:15 UTC (permalink / raw) To: Wolfram Sang, Sergey Kozlov, linux-i2c, Abylay Ospan, Mauro Carvalho Chehab, linux-media, linux-kernel On 23.11.2023 21:55, Wolfram Sang wrote: > On Sat, Nov 18, 2023 at 07:05:02PM +0100, Heiner Kallweit wrote: >> After removal of the legacy eeprom driver the only remaining I2C >> client device driver supporting I2C_CLASS_SPD is jc42. Because this >> driver also supports I2C_CLASS_HWMON, adapters don't have to >> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON. >> It's one step towards getting rid of I2C_CLASS_SPD mid-term. >> >> Series was created supported by Coccinelle and its splitpatch. >> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > > As I want to apply this cleanup early in the cycle, could we have an ack > for me to modify this subsystem, please? > Looking at the git history for this driver, there has been no sign of life from the official maintainers for years. Hopefully Mauro can ack this. >> >> --- >> drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c >> index bd38ce444..46676f2c8 100644 >> --- a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c >> +++ b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c >> @@ -289,7 +289,7 @@ static const struct i2c_algorithm netup_i2c_algorithm = { >> static const struct i2c_adapter netup_i2c_adapter = { >> .owner = THIS_MODULE, >> .name = NETUP_UNIDVB_NAME, >> - .class = I2C_CLASS_HWMON | I2C_CLASS_SPD, >> + .class = I2C_CLASS_HWMON, >> .algo = &netup_i2c_algorithm, >> }; >> >> ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-24 10:15 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-11-18 18:04 [PATCH 00/10] Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON Heiner Kallweit 2023-11-18 18:05 ` [PATCH 08/10] drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c: " Heiner Kallweit 2023-11-23 20:55 ` Wolfram Sang 2023-11-24 10:15 ` Heiner Kallweit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox