From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Yan, Dongcheng" <dongcheng.yan@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Dongcheng Yan <dongcheng.yan@intel.com>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
sakari.ailus@linux.intel.com, hverkuil@xs4all.nl,
u.kleine-koenig@baylibre.com, ricardo.ribalda@gmail.com,
bingbu.cao@linux.intel.com, stable@vger.kernel.org,
hao.yao@intel.com
Subject: Re: [PATCH v1 1/2] platform/x86: int3472: add hpd pin support
Date: Mon, 14 Apr 2025 11:11:05 +0300 [thread overview]
Message-ID: <Z_zDGYD1QXZYWwI9@smile.fi.intel.com> (raw)
In-Reply-To: <c8ae2d43-157c-408a-af89-7248b30d52d1@linux.intel.com>
On Mon, Apr 14, 2025 at 03:52:50PM +0800, Yan, Dongcheng wrote:
> On 4/11/2025 4:33 PM, Hans de Goede wrote:
> > On 11-Apr-25 10:23 AM, Dongcheng Yan wrote:
...
> >> + case INT3472_GPIO_TYPE_HOTPLUG_DETECT:
> >> + *con_id = "hpd";
> >> + *gpio_flags = GPIO_LOOKUP_FLAGS_DEFAULT;
> >
> > This looks wrong, we really need to clearly provide a polarity
> > here since the ACPI GPIO resources do not provide one.
> >
> I tested gpio_flags=GPIO_LOOKUP_FLAGS_DEFAULT/HIGH/LOW, the lt6911uxe
> driver can pass the test and work normally.
I doubt you tested that correctly. It's impossible to have level triggered
event to work with either polarity. It might be also a bug in the code lurking
somewhere, but it would be unlikely (taking into account amount of systems
relying on this).
Is it edge triggered event?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-04-14 8:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 8:23 [PATCH v1 1/2] platform/x86: int3472: add hpd pin support Dongcheng Yan
2025-04-11 8:23 ` [PATCH v1 2/2] media: i2c: change lt6911uxe irq_gpio name to "hpd" Dongcheng Yan
2025-04-11 8:34 ` Hans de Goede
2025-04-14 7:54 ` Yan, Dongcheng
2025-04-11 8:33 ` [PATCH v1 1/2] platform/x86: int3472: add hpd pin support Hans de Goede
2025-04-14 7:52 ` Yan, Dongcheng
2025-04-14 8:11 ` Andy Shevchenko [this message]
2025-04-14 8:40 ` Yan, Dongcheng
2025-04-14 8:49 ` Andy Shevchenko
2025-04-14 9:59 ` Yan, Dongcheng
2025-04-14 11:04 ` Hans de Goede
2025-04-14 11:09 ` Hans de Goede
2025-04-14 11:43 ` Sakari Ailus
2025-04-14 12:21 ` Hans de Goede
2025-04-14 12:32 ` Sakari Ailus
2025-04-14 12:37 ` Hans de Goede
2025-04-14 12:54 ` Sakari Ailus
2025-04-14 14:24 ` Hans de Goede
2025-04-14 8:52 ` Sakari Ailus
2025-04-14 10:01 ` Yan, Dongcheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_zDGYD1QXZYWwI9@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bingbu.cao@linux.intel.com \
--cc=dongcheng.yan@intel.com \
--cc=dongcheng.yan@linux.intel.com \
--cc=hao.yao@intel.com \
--cc=hdegoede@redhat.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=ricardo.ribalda@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox