public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4l-utils] keytable: meson: Restrict the installation of 50-rc_keymap.conf
@ 2024-01-12  3:17 Fabio Estevam
  2024-01-12  8:52 ` Sean Young
  0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2024-01-12  3:17 UTC (permalink / raw)
  To: hverkuil-cisco; +Cc: sean, raj.khem, linux-media, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

Currently, meson tries to install 50-rc_keymap.conf even if systemd
is not used.

Commit 01f2c6c58e6f ("keytable: restrict installation of 50-rc_keymap.conf"),
only allowed 50-rc_keymap.conf to be installed when both BPF and systemd
were used.

Apply the same logic in meson to fix the problem.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 utils/keytable/meson.build | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/utils/keytable/meson.build b/utils/keytable/meson.build
index 4130a4bea514..76ce329eae8e 100644
--- a/utils/keytable/meson.build
+++ b/utils/keytable/meson.build
@@ -69,6 +69,8 @@ ir_keytable_udev_rules = files(
 install_data(ir_keytable_udev_rules,
              install_dir : ir_keytable_system_dir / 'rules.d')
 
+if ir_bpf_enabled
+if dep_systemd.found()
 if have_udevdsyscallfilter
     ir_keytable_systemd_files = files(
         '50-rc_keymap.conf',
@@ -76,6 +78,8 @@ if have_udevdsyscallfilter
     install_data(ir_keytable_systemd_files,
                  install_dir : systemd_systemdir / 'systemd-udevd.service.d')
 endif
+endif
+endif
 
 # Install non-existing directory to create empty directory structure
 # See: https://github.com/mesonbuild/meson/issues/2904
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v4l-utils] keytable: meson: Restrict the installation of 50-rc_keymap.conf
  2024-01-12  3:17 [PATCH v4l-utils] keytable: meson: Restrict the installation of 50-rc_keymap.conf Fabio Estevam
@ 2024-01-12  8:52 ` Sean Young
  0 siblings, 0 replies; 2+ messages in thread
From: Sean Young @ 2024-01-12  8:52 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: hverkuil-cisco, raj.khem, linux-media, Fabio Estevam

On Fri, Jan 12, 2024 at 12:17:14AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Currently, meson tries to install 50-rc_keymap.conf even if systemd
> is not used.
> 
> Commit 01f2c6c58e6f ("keytable: restrict installation of 50-rc_keymap.conf"),
> only allowed 50-rc_keymap.conf to be installed when both BPF and systemd
> were used.
> 
> Apply the same logic in meson to fix the problem.

Thanks, applied!

Sean

> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  utils/keytable/meson.build | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/utils/keytable/meson.build b/utils/keytable/meson.build
> index 4130a4bea514..76ce329eae8e 100644
> --- a/utils/keytable/meson.build
> +++ b/utils/keytable/meson.build
> @@ -69,6 +69,8 @@ ir_keytable_udev_rules = files(
>  install_data(ir_keytable_udev_rules,
>               install_dir : ir_keytable_system_dir / 'rules.d')
>  
> +if ir_bpf_enabled
> +if dep_systemd.found()
>  if have_udevdsyscallfilter
>      ir_keytable_systemd_files = files(
>          '50-rc_keymap.conf',
> @@ -76,6 +78,8 @@ if have_udevdsyscallfilter
>      install_data(ir_keytable_systemd_files,
>                   install_dir : systemd_systemdir / 'systemd-udevd.service.d')
>  endif
> +endif
> +endif
>  
>  # Install non-existing directory to create empty directory structure
>  # See: https://github.com/mesonbuild/meson/issues/2904
> -- 
> 2.34.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-01-12  8:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-12  3:17 [PATCH v4l-utils] keytable: meson: Restrict the installation of 50-rc_keymap.conf Fabio Estevam
2024-01-12  8:52 ` Sean Young

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox