Linux Media Controller development
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Max Staudt <mstaudt@chromium.org>
Cc: Bingbu Cao <bingbu.cao@intel.com>,
	Tianshu Qiu <tian.shu.qiu@intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ricardo Ribalda <ribalda@chromium.org>
Subject: Re: Fixing IPU3 IMGU warnings due to extraneous calls to s_stream()
Date: Tue, 27 Aug 2024 06:56:44 +0000	[thread overview]
Message-ID: <Zs14rHA2lGQibhRX@kekkonen.localdomain> (raw)
In-Reply-To: <20240620145820.3910239-1-mstaudt@chromium.org>

Hi Max,

On Thu, Jun 20, 2024 at 11:45:40PM +0900, Max Staudt wrote:
> Dear IPU3 driver maintainers,
> 
> The Intel IPU3 IMGU driver no longer shuts down cleanly since v6.7,
> because vb2 now complains if s_stream() is called multiple times on
> the same object:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=009905ec50433259c05f474251000b040098564e
> 
> This series attempts to fix this, but needs a review from someone more
> intimate with IPU3 and its driver. Could you please have a look at this?

Thanks for the patches. They seem good to me, I've taken them to my tree
(devel branch).

-- 
Kind regards,

Sakari Ailus

  parent reply	other threads:[~2024-08-27  6:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20 14:45 Fixing IPU3 IMGU warnings due to extraneous calls to s_stream() Max Staudt
2024-06-20 14:45 ` [PATCH v1 1/3] staging: media: ipu3: Drop superfluous check in imgu_vb2_stop_streaming() Max Staudt
2024-06-20 14:45 ` [PATCH v1 2/3] staging: media: ipu3: Return buffers outside of needless locking Max Staudt
2024-06-20 14:45 ` [PATCH v1 3/3] staging: media: ipu3: Stop streaming in inverse order of starting Max Staudt
2024-07-04  7:03   ` Bingbu Cao
2024-07-05  1:54     ` Max Staudt
2024-07-05  4:03       ` Bingbu Cao
2024-07-05  5:27         ` Max Staudt
2024-08-26 13:25 ` Fixing IPU3 IMGU warnings due to extraneous calls to s_stream() Ricardo Ribalda
2024-08-27  6:56 ` Sakari Ailus [this message]
2025-06-18  7:14   ` Max Staudt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zs14rHA2lGQibhRX@kekkonen.localdomain \
    --to=sakari.ailus@linux.intel.com \
    --cc=bingbu.cao@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mstaudt@chromium.org \
    --cc=ribalda@chromium.org \
    --cc=tian.shu.qiu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox