From: Max Staudt <mstaudt@chromium.org>
To: Bingbu Cao <bingbu.cao@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Bingbu Cao <bingbu.cao@intel.com>,
Tianshu Qiu <tian.shu.qiu@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Ricardo Ribalda <ribalda@chromium.org>
Subject: Re: [PATCH v1 3/3] staging: media: ipu3: Stop streaming in inverse order of starting
Date: Fri, 5 Jul 2024 14:27:53 +0900 [thread overview]
Message-ID: <f3b86a0f-54ea-4a41-869e-643cbbad8192@chromium.org> (raw)
In-Reply-To: <594c28e3-67f6-bb80-4751-ae6dc9f34c7c@linux.intel.com>
On 7/5/24 1:03 PM, Bingbu Cao wrote:
> I guess the real problem is the subdev s_stream cannot be called multiple
> times, please correct me if I am wrong as I have not touch IPU3 for long
> time. :)
>
> You can ignore my previous comment - 's_stream' is fine here.
Yes, indeed the multiple calls were what the newer V4L2 versions are
screaming about, and what made me write this patch...
> Just a nit, stop_stream and s_stream only happen after imgu_s_stream(), so I
> think they can be together and no need 'stop_streaming'. I think the mutex
> is mainly for imgu_s_stream, subdev stream on/off should work without it.
> It depends on you. :)
>
> It'll be better that others who is still working on IPU3 devices can review.
Okay, let's wait for their feedback then before I send a v2.
> Besides,
> Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
Appreciated! Let's do a v2, when other Intel folks have had a chance to
chime in.
Max
next prev parent reply other threads:[~2024-07-05 5:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 14:45 Fixing IPU3 IMGU warnings due to extraneous calls to s_stream() Max Staudt
2024-06-20 14:45 ` [PATCH v1 1/3] staging: media: ipu3: Drop superfluous check in imgu_vb2_stop_streaming() Max Staudt
2024-06-20 14:45 ` [PATCH v1 2/3] staging: media: ipu3: Return buffers outside of needless locking Max Staudt
2024-06-20 14:45 ` [PATCH v1 3/3] staging: media: ipu3: Stop streaming in inverse order of starting Max Staudt
2024-07-04 7:03 ` Bingbu Cao
2024-07-05 1:54 ` Max Staudt
2024-07-05 4:03 ` Bingbu Cao
2024-07-05 5:27 ` Max Staudt [this message]
2024-08-26 13:25 ` Fixing IPU3 IMGU warnings due to extraneous calls to s_stream() Ricardo Ribalda
2024-08-27 6:56 ` Sakari Ailus
2025-06-18 7:14 ` Max Staudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3b86a0f-54ea-4a41-869e-643cbbad8192@chromium.org \
--to=mstaudt@chromium.org \
--cc=bingbu.cao@intel.com \
--cc=bingbu.cao@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox