* Re: [PATCH] media: uvcvideo: Remove unused active field
2026-06-30 10:28 [PATCH] media: uvcvideo: Remove unused active field Ricardo Ribalda
@ 2026-06-30 10:40 ` Laurent Pinchart
2026-10-02 0:46 ` Laurent Pinchart
2026-06-30 13:10 ` Hans de Goede
2026-09-29 14:18 ` Hans de Goede
2 siblings, 1 reply; 5+ messages in thread
From: Laurent Pinchart @ 2026-06-30 10:40 UTC (permalink / raw)
To: Ricardo Ribalda
Cc: Hans de Goede, Mauro Carvalho Chehab, Hans Verkuil, linux-media,
linux-kernel
On Tue, Jun 30, 2026 at 10:28:50AM +0000, Ricardo Ribalda wrote:
> The active field in struct uvc_streaming is not used anymore, drop it.
Easy one, I like that :-)
> Reported-by: Hans de Goede <hansg@kernel.org>
> Closes: https://lore.kernel.org/linux-media/20260629-uvc-racemeta-v2-0-10e91d2afba0@chromium.org/T/#m3078f0d5fd71435b5cfacaa5c99f23a446db581f
> Fixes: c93d73c9c2cf ("media: uvcvideo: Use vb2 ioctl and fop helpers")
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/usb/uvc/uvc_video.c | 2 --
> drivers/media/usb/uvc/uvcvideo.h | 1 -
> 2 files changed, 3 deletions(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c
> index fc3536a4399f..0167f0f8e846 100644
> --- a/drivers/media/usb/uvc/uvc_video.c
> +++ b/drivers/media/usb/uvc/uvc_video.c
> @@ -2229,8 +2229,6 @@ int uvc_video_init(struct uvc_streaming *stream)
> return -EINVAL;
> }
>
> - atomic_set(&stream->active, 0);
> -
> /*
> * Alternate setting 0 should be the default, yet the XBox Live Vision
> * Cam (and possibly other devices) crash or otherwise misbehave if
> diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h
> index b6bcee4a222f..021fd9af78b5 100644
> --- a/drivers/media/usb/uvc/uvcvideo.h
> +++ b/drivers/media/usb/uvc/uvcvideo.h
> @@ -456,7 +456,6 @@ struct uvc_streaming {
> struct list_head list;
> struct uvc_device *dev;
> struct uvc_video_chain *chain;
> - atomic_t active;
>
> struct usb_interface *intf;
> int intfnum;
>
> ---
> base-commit: 253355887a1ab0ac8f33b356c7c1140eee554d18
> change-id: 20260630-uvc-remove-active-8843181bcbb4
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] media: uvcvideo: Remove unused active field
2026-06-30 10:40 ` Laurent Pinchart
@ 2026-10-02 0:46 ` Laurent Pinchart
0 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2026-10-02 0:46 UTC (permalink / raw)
To: Ricardo Ribalda
Cc: Hans de Goede, Mauro Carvalho Chehab, Hans Verkuil, linux-media,
linux-kernel
On Tue, Jun 30, 2026 at 01:40:39PM +0300, Laurent Pinchart wrote:
> On Tue, Jun 30, 2026 at 10:28:50AM +0000, Ricardo Ribalda wrote:
> > The active field in struct uvc_streaming is not used anymore, drop it.
>
> Easy one, I like that :-)
>
> > Reported-by: Hans de Goede <hansg@kernel.org>
> > Closes: https://lore.kernel.org/linux-media/20260629-uvc-racemeta-v2-0-10e91d2afba0@chromium.org/T/#m3078f0d5fd71435b5cfacaa5c99f23a446db581f
> > Fixes: c93d73c9c2cf ("media: uvcvideo: Use vb2 ioctl and fop helpers")
CI has flagged that this requires a Cc: stable. As I don't think there's
a need to backport this, I'll drop the Fixes tag.
> > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > ---
> > drivers/media/usb/uvc/uvc_video.c | 2 --
> > drivers/media/usb/uvc/uvcvideo.h | 1 -
> > 2 files changed, 3 deletions(-)
> >
> > diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c
> > index fc3536a4399f..0167f0f8e846 100644
> > --- a/drivers/media/usb/uvc/uvc_video.c
> > +++ b/drivers/media/usb/uvc/uvc_video.c
> > @@ -2229,8 +2229,6 @@ int uvc_video_init(struct uvc_streaming *stream)
> > return -EINVAL;
> > }
> >
> > - atomic_set(&stream->active, 0);
> > -
> > /*
> > * Alternate setting 0 should be the default, yet the XBox Live Vision
> > * Cam (and possibly other devices) crash or otherwise misbehave if
> > diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h
> > index b6bcee4a222f..021fd9af78b5 100644
> > --- a/drivers/media/usb/uvc/uvcvideo.h
> > +++ b/drivers/media/usb/uvc/uvcvideo.h
> > @@ -456,7 +456,6 @@ struct uvc_streaming {
> > struct list_head list;
> > struct uvc_device *dev;
> > struct uvc_video_chain *chain;
> > - atomic_t active;
> >
> > struct usb_interface *intf;
> > int intfnum;
> >
> > ---
> > base-commit: 253355887a1ab0ac8f33b356c7c1140eee554d18
> > change-id: 20260630-uvc-remove-active-8843181bcbb4
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] media: uvcvideo: Remove unused active field
2026-06-30 10:28 [PATCH] media: uvcvideo: Remove unused active field Ricardo Ribalda
2026-06-30 10:40 ` Laurent Pinchart
@ 2026-06-30 13:10 ` Hans de Goede
2026-09-29 14:18 ` Hans de Goede
2 siblings, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2026-06-30 13:10 UTC (permalink / raw)
To: Ricardo Ribalda, Laurent Pinchart, Mauro Carvalho Chehab,
Hans Verkuil
Cc: linux-media, linux-kernel
Hi,
On 30-Jun-26 12:28, Ricardo Ribalda wrote:
> The active field in struct uvc_streaming is not used anymore, drop it.
>
> Reported-by: Hans de Goede <hansg@kernel.org>
> Closes: https://lore.kernel.org/linux-media/20260629-uvc-racemeta-v2-0-10e91d2afba0@chromium.org/T/#m3078f0d5fd71435b5cfacaa5c99f23a446db581f
> Fixes: c93d73c9c2cf ("media: uvcvideo: Use vb2 ioctl and fop helpers")
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Regards,
Hans
> ---
> drivers/media/usb/uvc/uvc_video.c | 2 --
> drivers/media/usb/uvc/uvcvideo.h | 1 -
> 2 files changed, 3 deletions(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c
> index fc3536a4399f..0167f0f8e846 100644
> --- a/drivers/media/usb/uvc/uvc_video.c
> +++ b/drivers/media/usb/uvc/uvc_video.c
> @@ -2229,8 +2229,6 @@ int uvc_video_init(struct uvc_streaming *stream)
> return -EINVAL;
> }
>
> - atomic_set(&stream->active, 0);
> -
> /*
> * Alternate setting 0 should be the default, yet the XBox Live Vision
> * Cam (and possibly other devices) crash or otherwise misbehave if
> diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h
> index b6bcee4a222f..021fd9af78b5 100644
> --- a/drivers/media/usb/uvc/uvcvideo.h
> +++ b/drivers/media/usb/uvc/uvcvideo.h
> @@ -456,7 +456,6 @@ struct uvc_streaming {
> struct list_head list;
> struct uvc_device *dev;
> struct uvc_video_chain *chain;
> - atomic_t active;
>
> struct usb_interface *intf;
> int intfnum;
>
> ---
> base-commit: 253355887a1ab0ac8f33b356c7c1140eee554d18
> change-id: 20260630-uvc-remove-active-8843181bcbb4
>
> Best regards,
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] media: uvcvideo: Remove unused active field
2026-06-30 10:28 [PATCH] media: uvcvideo: Remove unused active field Ricardo Ribalda
2026-06-30 10:40 ` Laurent Pinchart
2026-06-30 13:10 ` Hans de Goede
@ 2026-09-29 14:18 ` Hans de Goede
2 siblings, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2026-09-29 14:18 UTC (permalink / raw)
To: Ricardo Ribalda, Laurent Pinchart, Mauro Carvalho Chehab,
Hans Verkuil
Cc: linux-media, linux-kernel
Hi,
On 30-Jun-26 12:28, Ricardo Ribalda wrote:
> The active field in struct uvc_streaming is not used anymore, drop it.
>
> Reported-by: Hans de Goede <hansg@kernel.org>
> Closes: https://lore.kernel.org/linux-media/20260629-uvc-racemeta-v2-0-10e91d2afba0@chromium.org/T/#m3078f0d5fd71435b5cfacaa5c99f23a446db581f
> Fixes: c93d73c9c2cf ("media: uvcvideo: Use vb2 ioctl and fop helpers")
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Thank you for your patch.
I have merged this into:
https://gitlab.freedesktop.org/linux-media/users/uvc/-/commits/for-next/
Regards,
Hans
> ---
> drivers/media/usb/uvc/uvc_video.c | 2 --
> drivers/media/usb/uvc/uvcvideo.h | 1 -
> 2 files changed, 3 deletions(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c
> index fc3536a4399f..0167f0f8e846 100644
> --- a/drivers/media/usb/uvc/uvc_video.c
> +++ b/drivers/media/usb/uvc/uvc_video.c
> @@ -2229,8 +2229,6 @@ int uvc_video_init(struct uvc_streaming *stream)
> return -EINVAL;
> }
>
> - atomic_set(&stream->active, 0);
> -
> /*
> * Alternate setting 0 should be the default, yet the XBox Live Vision
> * Cam (and possibly other devices) crash or otherwise misbehave if
> diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h
> index b6bcee4a222f..021fd9af78b5 100644
> --- a/drivers/media/usb/uvc/uvcvideo.h
> +++ b/drivers/media/usb/uvc/uvcvideo.h
> @@ -456,7 +456,6 @@ struct uvc_streaming {
> struct list_head list;
> struct uvc_device *dev;
> struct uvc_video_chain *chain;
> - atomic_t active;
>
> struct usb_interface *intf;
> int intfnum;
>
> ---
> base-commit: 253355887a1ab0ac8f33b356c7c1140eee554d18
> change-id: 20260630-uvc-remove-active-8843181bcbb4
>
> Best regards,
^ permalink raw reply [flat|nested] 5+ messages in thread