[PATCH 1/1] media: ov02c10: Use div_u64 to divide a 64-bit number

[PATCH 1/1] media: ov02c10: Use div_u64 to divide a 64-bit number

[Sakari Ailus]

The ov02c10 driver divides a 64-bit number but reply relies on division
operator to do that. Use div_u64() so this will compile everywhere.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/media/i2c/ov02c10.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/i2c/ov02c10.c b/drivers/media/i2c/ov02c10.c
index 9e3d4a4e12ce..089a4fd9627c 100644
--- a/drivers/media/i2c/ov02c10.c
+++ b/drivers/media/i2c/ov02c10.c
@@ -497,8 +497,8 @@ static int ov02c10_init_controls(struct ov02c10 *ov02c10)
 		ov02c10->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
 
 	/* MIPI lanes are DDR -> use link-freq * 2 */
-	pixel_rate = link_freq_menu_items[ov02c10->link_freq_index] * 2 *
-		     ov02c10->mipi_lanes / OV02C10_RGB_DEPTH;
+	pixel_rate = div_u64(link_freq_menu_items[ov02c10->link_freq_index] *
+			     2 * ov02c10->mipi_lanes, OV02C10_RGB_DEPTH);
 
 	ov02c10->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, &ov02c10_ctrl_ops,
 						V4L2_CID_PIXEL_RATE, 0,
-- 
2.39.5

Re: [PATCH 1/1] media: ov02c10: Use div_u64 to divide a 64-bit number

[Stanislaw Gruszka]

On Fri, May 09, 2025 at 09:25:11AM +0300, Sakari Ailus wrote:
> The ov02c10 driver divides a 64-bit number but reply relies on division
> operator to do that. Use div_u64() so this will compile everywhere.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>

> ---
>  drivers/media/i2c/ov02c10.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov02c10.c b/drivers/media/i2c/ov02c10.c
> index 9e3d4a4e12ce..089a4fd9627c 100644
> --- a/drivers/media/i2c/ov02c10.c
> +++ b/drivers/media/i2c/ov02c10.c
> @@ -497,8 +497,8 @@ static int ov02c10_init_controls(struct ov02c10 *ov02c10)
>  		ov02c10->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
>  
>  	/* MIPI lanes are DDR -> use link-freq * 2 */
> -	pixel_rate = link_freq_menu_items[ov02c10->link_freq_index] * 2 *
> -		     ov02c10->mipi_lanes / OV02C10_RGB_DEPTH;
> +	pixel_rate = div_u64(link_freq_menu_items[ov02c10->link_freq_index] *
> +			     2 * ov02c10->mipi_lanes, OV02C10_RGB_DEPTH);
>  
>  	ov02c10->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, &ov02c10_ctrl_ops,
>  						V4L2_CID_PIXEL_RATE, 0,
> -- 
> 2.39.5
> 
> 

Re: [PATCH 1/1] media: ov02c10: Use div_u64 to divide a 64-bit number

[Hans de Goede]

Hi,

On 9-May-25 8:25 AM, Sakari Ailus wrote:
> The ov02c10 driver divides a 64-bit number but reply relies on division
> operator to do that. Use div_u64() so this will compile everywhere.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

I was just going to start working on fixing this myself, thank you,
patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans




> ---
>  drivers/media/i2c/ov02c10.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov02c10.c b/drivers/media/i2c/ov02c10.c
> index 9e3d4a4e12ce..089a4fd9627c 100644
> --- a/drivers/media/i2c/ov02c10.c
> +++ b/drivers/media/i2c/ov02c10.c
> @@ -497,8 +497,8 @@ static int ov02c10_init_controls(struct ov02c10 *ov02c10)
>  		ov02c10->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
>  
>  	/* MIPI lanes are DDR -> use link-freq * 2 */
> -	pixel_rate = link_freq_menu_items[ov02c10->link_freq_index] * 2 *
> -		     ov02c10->mipi_lanes / OV02C10_RGB_DEPTH;
> +	pixel_rate = div_u64(link_freq_menu_items[ov02c10->link_freq_index] *
> +			     2 * ov02c10->mipi_lanes, OV02C10_RGB_DEPTH);
>  
>  	ov02c10->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, &ov02c10_ctrl_ops,
>  						V4L2_CID_PIXEL_RATE, 0,