Re: [PATCH 06/13] media: v4l2-subdev: Mark both streams of a route enabled

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hi Laurent,

On Thu, Jun 19, 2025 at 07:56:04PM +0300, Laurent Pinchart wrote:
> Hi Sakari,
> 
> Thank you for the patch.

Thanks for the review.

> 
> On Thu, Jun 19, 2025 at 11:15:39AM +0300, Sakari Ailus wrote:
> > Streams are stored in sink-source pairs in sub-device state.
> 
> Is it really this simple ? Don't we support for instance stream merging
> where two streams on possibly different sink pads are routed to a single
> stream on a source pad ?

As far as I'm concerned, yes. Each route has a sink and a source pad, you
may have multiple routes from a pad or to a pad, but these are all separate
routes. The UAPI as well as v4l2-subdev.c is aligned with this and I
wouldn't expect it to be otherwise.

I'd like to have Tomi's view on this, too.

> 
> > When a stream
> > was marked enabled (or disabled), only the state of one end of the stream
> > was modified, leaving the stream in an incoherent state. Mark both ends of
> > the stream enabled (or disabled).

This should discuss "route" in fact, not "stream".

-- 
Regards,

Sakari Ailus