Re: [PATCH 08/13] media: v4l2-subdev: Print early in v4l2_subdev_{enable,disable}_streams()

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hi Laurent,

On Thu, Jun 19, 2025 at 08:03:20PM +0300, Laurent Pinchart wrote:
> Hi Sakari,
> 
> On Thu, Jun 19, 2025 at 11:15:41AM +0300, Sakari Ailus wrote:
> > Print debug messages early in v4l2_subdev_enable_streams() and
> > v4l2_subdev_disable_streams(), before sanity checks take place. This can
> > help figuring out why something goes wrong, in driver development or
> > otherwise.
> > 
> > Also print the name of the sub-device where streaming is to be enabled or
> > disabled.
> > 
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > ---
> >  drivers/media/v4l2-core/v4l2-subdev.c | 10 ++++++----
> >  1 file changed, 6 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
> > index 5afdd9d548b5..6bc855058ca6 100644
> > --- a/drivers/media/v4l2-core/v4l2-subdev.c
> > +++ b/drivers/media/v4l2-core/v4l2-subdev.c
> > @@ -2273,6 +2273,9 @@ int v4l2_subdev_enable_streams(struct v4l2_subdev *sd, u32 pad,
> >  	bool use_s_stream;
> >  	int ret;
> >  
> > +	dev_dbg(dev, "enable streams %s:%u/%#llx\n", sd->entity.name, pad,
> > +		streams_mask);
> 
> I suppose there can be multiple subdevs per struct device, so printing
> the entity name can be useful. I'd put quotes around '%s' as the entity
> name can contain spaces. Apart from that,

I'll use double quotes as that is how sub-device (or entity) name is
typically quoted in debug prints.

> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thank you.

-- 
Regards,

Sakari Ailus