From: Mehdi Djait <mehdi.djait@linux.intel.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: v4l2-common: Always register clock with device-specific name
Date: Mon, 30 Mar 2026 18:24:55 +0200 [thread overview]
Message-ID: <acqjbSoLCyemQmnm@mdjait-mobl> (raw)
In-Reply-To: <acqilV_y6FxIgBbY@mdjait-mobl>
On Mon, Mar 30, 2026 at 06:21:56PM +0200, Mehdi Djait wrote:
[..]
>
> How about this, for drivers calling this without id:
>
> if (id)
> clk_id = kasprintf(GFP_KERNEL, "clk-%s-%s", dev_name(dev), id);
> else
> clk_id = kasprintf(GFP_KERNEL, "clk-%s-%s", dev_name(dev));
|
+-> of course
without this %s
>
> if (!clk_id)
> return ERR_PTR(-ENOMEM);
--
Kind Regards
Mehdi Djait
next prev parent reply other threads:[~2026-03-30 16:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 22:57 [PATCH v2] media: v4l2-common: Always register clock with device-specific name Paul Cercueil
2026-03-30 16:21 ` Mehdi Djait
2026-03-30 16:24 ` Mehdi Djait [this message]
2026-03-30 16:50 ` Paul Cercueil
2026-03-31 8:12 ` Mehdi Djait
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acqjbSoLCyemQmnm@mdjait-mobl \
--to=mehdi.djait@linux.intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox