From: Mehdi Djait <mehdi.djait@linux.intel.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: v4l2-common: Always register clock with device-specific name
Date: Tue, 31 Mar 2026 10:12:05 +0200 [thread overview]
Message-ID: <acuBpll9hMFB2yh-@mdjait-mobl> (raw)
In-Reply-To: <cbb88a06a4570c6e33b2125819572647efcd5b1a.camel@crapouillou.net>
Hi Paul,
[..]
> > if (id)
> > clk_id = kasprintf(GFP_KERNEL, "clk-%s-%s",
> > dev_name(dev), id);
> > else
> > clk_id = kasprintf(GFP_KERNEL, "clk-%s-%s",
> > dev_name(dev));
> >
> > if (!clk_id)
> > return ERR_PTR(-ENOMEM);
>
> In the case where "id" is NULL then the name will be e.g.
> "clk-ov2680@1c-(null)" which I assumed was fine - even with a valid
> "id" the clock name wouldn't be very pretty anyway.
>
> But I can't update it to your suggestion and send a v3.
Yes, please.
--
Kind Regards
Mehdi Djait
prev parent reply other threads:[~2026-03-31 8:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 22:57 [PATCH v2] media: v4l2-common: Always register clock with device-specific name Paul Cercueil
2026-03-30 16:21 ` Mehdi Djait
2026-03-30 16:24 ` Mehdi Djait
2026-03-30 16:50 ` Paul Cercueil
2026-03-31 8:12 ` Mehdi Djait [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acuBpll9hMFB2yh-@mdjait-mobl \
--to=mehdi.djait@linux.intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox