From: Sumit Garg <sumit.garg@kernel.org>
To: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Cc: andersson@kernel.org, konradybcio@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-media@vger.kernel.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, ath12k@lists.infradead.org,
linux-remoteproc@vger.kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
robin.clark@oss.qualcomm.com, sean@poorly.run,
akhilpo@oss.qualcomm.com, lumag@kernel.org,
abhinav.kumar@linux.dev, jesszhan0024@gmail.com,
marijn.suijten@somainline.org, airlied@gmail.com,
simona@ffwll.ch, vikash.garodia@oss.qualcomm.com,
dikshita.agarwal@oss.qualcomm.com, bod@kernel.org,
mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, jjohnson@kernel.org,
mathieu.poirier@linaro.org, trilokkumar.soni@oss.qualcomm.com,
pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com,
tonyh@qti.qualcomm.com, vignesh.viswanathan@oss.qualcomm.com,
srinivas.kandagatla@oss.qualcomm.com,
amirreza.zarrabi@oss.qualcomm.com, jens.wiklander@linaro.org,
op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com,
skare@qti.qualcomm.com, linux-kernel@vger.kernel.org,
Sumit Garg <sumit.garg@oss.qualcomm.com>
Subject: Re: [PATCH v4 05/15] remoteproc: qcom_q6v5_pas: Switch over to generic PAS TZ APIs
Date: Fri, 1 May 2026 19:27:03 +0530 [thread overview]
Message-ID: <afSxLxDPHh6Ajpi6@sumit-xelite> (raw)
In-Reply-To: <20260429132512.aki4vqkhpil7awc3@hu-mojha-hyd.qualcomm.com>
On Wed, Apr 29, 2026 at 06:55:12PM +0530, Mukesh Ojha wrote:
> On Mon, Apr 27, 2026 at 03:25:53PM +0530, Sumit Garg wrote:
> > From: Sumit Garg <sumit.garg@oss.qualcomm.com>
> >
> > Switch qcom_q6v5_pas client driver over to generic PAS TZ APIs. Generic PAS
> > TZ service allows to support multiple TZ implementation backends like QTEE
> > based SCM PAS service, OP-TEE based PAS service and any further future TZ
> > backend service.
> >
> > Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
> > ---
> > drivers/remoteproc/qcom_q6v5_pas.c | 51 +++++++++++++++---------------
> > 1 file changed, 26 insertions(+), 25 deletions(-)
> >
> > diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> > index da27d1d3c9da..847249c28c1b 100644
> > --- a/drivers/remoteproc/qcom_q6v5_pas.c
> > +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> > @@ -20,6 +20,7 @@
> > #include <linux/platform_device.h>
> > #include <linux/pm_domain.h>
> > #include <linux/pm_runtime.h>
> > +#include <linux/firmware/qcom/qcom_pas.h>
> > #include <linux/firmware/qcom/qcom_scm.h>
>
> Can you check do we really need this header ?
Yeah it's needed for qcom_scm_assign_mem() API.
>
> > #include <linux/regulator/consumer.h>
> > #include <linux/remoteproc.h>
> > @@ -118,8 +119,8 @@ struct qcom_pas {
> > struct qcom_rproc_ssr ssr_subdev;
> > struct qcom_sysmon *sysmon;
> >
> > - struct qcom_scm_pas_context *pas_ctx;
> > - struct qcom_scm_pas_context *dtb_pas_ctx;
> > + struct qcom_pas_context *pas_ctx;
> > + struct qcom_pas_context *dtb_pas_ctx;
> > };
> >
> > static void qcom_pas_segment_dump(struct rproc *rproc,
> > @@ -196,7 +197,7 @@ static int qcom_pas_shutdown_poll_decrypt(struct qcom_pas *pas)
> >
> > do {
> > msleep(QCOM_PAS_DECRYPT_SHUTDOWN_DELAY_MS);
> > - ret = qcom_scm_pas_shutdown(pas->pas_id);
> > + ret = qcom_pas_shutdown(pas->pas_id);
> > } while (ret == -EINVAL && --retry_num);
> >
> > return ret;
> > @@ -212,9 +213,9 @@ static int qcom_pas_unprepare(struct rproc *rproc)
> > * auth_and_reset() was successful, but in other cases clean it up
> > * here.
> > */
> > - qcom_scm_pas_metadata_release(pas->pas_ctx);
> > + qcom_pas_metadata_release(pas->pas_ctx);
> > if (pas->dtb_pas_id)
> > - qcom_scm_pas_metadata_release(pas->dtb_pas_ctx);
> > + qcom_pas_metadata_release(pas->dtb_pas_ctx);
> >
> > return 0;
> > }
> > @@ -228,9 +229,9 @@ static int qcom_pas_load(struct rproc *rproc, const struct firmware *fw)
> > pas->firmware = fw;
> >
> > if (pas->lite_pas_id)
> > - qcom_scm_pas_shutdown(pas->lite_pas_id);
> > + qcom_pas_shutdown(pas->lite_pas_id);
> > if (pas->lite_dtb_pas_id)
> > - qcom_scm_pas_shutdown(pas->lite_dtb_pas_id);
> > + qcom_pas_shutdown(pas->lite_dtb_pas_id);
> >
> > if (pas->dtb_pas_id) {
> > ret = request_firmware(&pas->dtb_firmware, pas->dtb_firmware_name, pas->dev);
> > @@ -250,7 +251,7 @@ static int qcom_pas_load(struct rproc *rproc, const struct firmware *fw)
> > return 0;
> >
> > release_dtb_metadata:
> > - qcom_scm_pas_metadata_release(pas->dtb_pas_ctx);
> > + qcom_pas_metadata_release(pas->dtb_pas_ctx);
> > release_firmware(pas->dtb_firmware);
> >
> > return ret;
> > @@ -310,7 +311,7 @@ static int qcom_pas_start(struct rproc *rproc)
> > if (ret)
> > goto disable_px_supply;
> >
> > - ret = qcom_scm_pas_prepare_and_auth_reset(pas->dtb_pas_ctx);
> > + ret = qcom_pas_prepare_and_auth_reset(pas->dtb_pas_ctx);
> > if (ret) {
> > dev_err(pas->dev,
> > "failed to authenticate dtb image and release reset\n");
> > @@ -329,7 +330,7 @@ static int qcom_pas_start(struct rproc *rproc)
> > if (ret)
> > goto release_pas_metadata;
> >
> > - ret = qcom_scm_pas_prepare_and_auth_reset(pas->pas_ctx);
> > + ret = qcom_pas_prepare_and_auth_reset(pas->pas_ctx);
> > if (ret) {
> > dev_err(pas->dev,
> > "failed to authenticate image and release reset\n");
> > @@ -339,13 +340,13 @@ static int qcom_pas_start(struct rproc *rproc)
> > ret = qcom_q6v5_wait_for_start(&pas->q6v5, msecs_to_jiffies(5000));
> > if (ret == -ETIMEDOUT) {
> > dev_err(pas->dev, "start timed out\n");
> > - qcom_scm_pas_shutdown(pas->pas_id);
> > + qcom_pas_shutdown(pas->pas_id);
> > goto unmap_carveout;
> > }
> >
> > - qcom_scm_pas_metadata_release(pas->pas_ctx);
> > + qcom_pas_metadata_release(pas->pas_ctx);
> > if (pas->dtb_pas_id)
> > - qcom_scm_pas_metadata_release(pas->dtb_pas_ctx);
> > + qcom_pas_metadata_release(pas->dtb_pas_ctx);
> >
> > /* firmware is used to pass reference from qcom_pas_start(), drop it now */
> > pas->firmware = NULL;
> > @@ -355,9 +356,9 @@ static int qcom_pas_start(struct rproc *rproc)
> > unmap_carveout:
> > qcom_pas_unmap_carveout(rproc, pas->mem_phys, pas->mem_size);
> > release_pas_metadata:
> > - qcom_scm_pas_metadata_release(pas->pas_ctx);
> > + qcom_pas_metadata_release(pas->pas_ctx);
> > if (pas->dtb_pas_id)
> > - qcom_scm_pas_metadata_release(pas->dtb_pas_ctx);
> > + qcom_pas_metadata_release(pas->dtb_pas_ctx);
> >
> > unmap_dtb_carveout:
> > if (pas->dtb_pas_id)
> > @@ -406,7 +407,7 @@ static int qcom_pas_stop(struct rproc *rproc)
> > if (ret == -ETIMEDOUT)
> > dev_err(pas->dev, "timed out on wait\n");
> >
> > - ret = qcom_scm_pas_shutdown(pas->pas_id);
> > + ret = qcom_pas_shutdown(pas->pas_id);
> > if (ret && pas->decrypt_shutdown)
> > ret = qcom_pas_shutdown_poll_decrypt(pas);
> >
> > @@ -414,7 +415,7 @@ static int qcom_pas_stop(struct rproc *rproc)
> > dev_err(pas->dev, "failed to shutdown: %d\n", ret);
> >
> > if (pas->dtb_pas_id) {
> > - ret = qcom_scm_pas_shutdown(pas->dtb_pas_id);
> > + ret = qcom_pas_shutdown(pas->dtb_pas_id);
> > if (ret)
> > dev_err(pas->dev, "failed to shutdown dtb: %d\n", ret);
> >
> > @@ -484,11 +485,11 @@ static int qcom_pas_parse_firmware(struct rproc *rproc, const struct firmware *f
> > *
> > * Here, we call rproc_elf_load_rsc_table() to check firmware binary has resources
> > * or not and if it is not having then we pass NULL and zero as input resource
> > - * table pointer and size respectively to the argument of qcom_scm_pas_get_rsc_table()
> > + * table pointer and size respectively to the argument of qcom_pas_get_rsc_table()
> > * and this is even true for Qualcomm remote processor who does follow remoteproc
> > * framework.
> > */
> > - output_rt = qcom_scm_pas_get_rsc_table(pas->pas_ctx, table, table_sz, &output_rt_size);
> > + output_rt = qcom_pas_get_rsc_table(pas->pas_ctx, table, table_sz, &output_rt_size);
> > ret = IS_ERR(output_rt) ? PTR_ERR(output_rt) : 0;
> > if (ret) {
> > dev_err(pas->dev, "Error in getting resource table: %d\n", ret);
> > @@ -746,7 +747,7 @@ static int qcom_pas_probe(struct platform_device *pdev)
> > if (!desc)
> > return -EINVAL;
> >
> > - if (!qcom_scm_is_available())
> > + if (!qcom_pas_is_available())
> > return -EPROBE_DEFER;
> >
> > fw_name = desc->firmware_name;
> > @@ -838,16 +839,16 @@ static int qcom_pas_probe(struct platform_device *pdev)
> >
> > qcom_add_ssr_subdev(rproc, &pas->ssr_subdev, desc->ssr_name);
> >
> > - pas->pas_ctx = devm_qcom_scm_pas_context_alloc(pas->dev, pas->pas_id,
> > - pas->mem_phys, pas->mem_size);
> > + pas->pas_ctx = devm_qcom_pas_context_alloc(pas->dev, pas->pas_id,
> > + pas->mem_phys, pas->mem_size);
> > if (IS_ERR(pas->pas_ctx)) {
> > ret = PTR_ERR(pas->pas_ctx);
> > goto remove_ssr_sysmon;
> > }
> >
> > - pas->dtb_pas_ctx = devm_qcom_scm_pas_context_alloc(pas->dev, pas->dtb_pas_id,
> > - pas->dtb_mem_phys,
> > - pas->dtb_mem_size);
> > + pas->dtb_pas_ctx = devm_qcom_pas_context_alloc(pas->dev, pas->dtb_pas_id,
> > + pas->dtb_mem_phys,
> > + pas->dtb_mem_size);
> > if (IS_ERR(pas->dtb_pas_ctx)) {
> > ret = PTR_ERR(pas->dtb_pas_ctx);
> > goto remove_ssr_sysmon;
> > --
> > 2.51.0
> >
>
> Reviewed-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Thanks.
-Sumit
next prev parent reply other threads:[~2026-05-01 13:57 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 9:55 [PATCH v4 00/15] firmware: qcom: Add OP-TEE PAS service support Sumit Garg
2026-04-27 9:55 ` [PATCH v4 01/15] arm64: dts: qcom: kodiak: Add EL2 overlay Sumit Garg
2026-04-27 9:55 ` [PATCH v4 02/15] firmware: qcom: Add a generic PAS service Sumit Garg
2026-04-28 21:11 ` Mukesh Ojha
2026-05-01 13:33 ` Sumit Garg
2026-04-27 9:55 ` [PATCH v4 03/15] firmware: qcom_scm: Migrate to " Sumit Garg
2026-04-29 10:48 ` Mukesh Ojha
2026-05-01 13:41 ` Sumit Garg
2026-04-27 9:55 ` [PATCH v4 04/15] firmware: qcom: Add a PAS TEE service Sumit Garg
2026-04-29 13:20 ` Mukesh Ojha
2026-05-01 13:54 ` Sumit Garg
2026-04-27 9:55 ` [PATCH v4 05/15] remoteproc: qcom_q6v5_pas: Switch over to generic PAS TZ APIs Sumit Garg
2026-04-29 13:25 ` Mukesh Ojha
2026-05-01 13:57 ` Sumit Garg [this message]
2026-04-27 9:55 ` [PATCH v4 06/15] remoteproc: qcom_q6v5_mss: Switch " Sumit Garg
2026-04-29 13:31 ` Mukesh Ojha
2026-05-01 13:58 ` Sumit Garg
2026-04-27 9:55 ` [PATCH v4 07/15] soc: qcom: mdtloader: " Sumit Garg
2026-04-29 13:42 ` Mukesh Ojha
2026-05-01 13:59 ` Sumit Garg
2026-04-27 9:55 ` [PATCH v4 08/15] remoteproc: qcom_wcnss: " Sumit Garg
2026-04-29 13:43 ` Mukesh Ojha
2026-04-27 9:55 ` [PATCH v4 09/15] remoteproc: qcom: Select QCOM_PAS generic service Sumit Garg
2026-04-29 13:52 ` Mukesh Ojha
2026-05-01 14:08 ` Sumit Garg
2026-04-27 9:55 ` [PATCH v4 10/15] drm/msm: Switch to generic PAS TZ APIs Sumit Garg
2026-04-29 13:59 ` Mukesh Ojha
2026-05-01 14:11 ` Sumit Garg
2026-04-27 9:55 ` [PATCH v4 11/15] media: qcom: " Sumit Garg
2026-04-28 19:37 ` Mukesh Ojha
2026-05-01 13:26 ` Sumit Garg
2026-04-27 9:56 ` [PATCH v4 12/15] net: ipa: " Sumit Garg
2026-04-28 16:54 ` Alex Elder
2026-04-27 9:56 ` [PATCH v4 13/15] wifi: ath12k: " Sumit Garg
2026-04-27 9:56 ` [PATCH v4 14/15] firmware: qcom_scm: Remove SCM PAS wrappers Sumit Garg
2026-04-29 14:04 ` Mukesh Ojha
2026-04-27 9:56 ` [PATCH v4 15/15] MAINTAINERS: Add maintainer entry for Qualcomm PAS TZ service Sumit Garg
2026-04-29 6:59 ` [PATCH v4 00/15] firmware: qcom: Add OP-TEE PAS service support Mukesh Ojha
2026-05-01 13:34 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afSxLxDPHh6Ajpi6@sumit-xelite \
--to=sumit.garg@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=akhilpo@oss.qualcomm.com \
--cc=amirreza.zarrabi@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=apurupa@qti.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=bod@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jens.wiklander@linaro.org \
--cc=jesszhan0024@gmail.com \
--cc=jjohnson@kernel.org \
--cc=jorge.ramirez@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mathieu.poirier@linaro.org \
--cc=mchehab@kernel.org \
--cc=mukesh.ojha@oss.qualcomm.com \
--cc=netdev@vger.kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=pabeni@redhat.com \
--cc=pavan.kondeti@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=skare@qti.qualcomm.com \
--cc=srinivas.kandagatla@oss.qualcomm.com \
--cc=sumit.garg@oss.qualcomm.com \
--cc=tonyh@qti.qualcomm.com \
--cc=trilokkumar.soni@oss.qualcomm.com \
--cc=vignesh.viswanathan@oss.qualcomm.com \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox