Linux Media Controller development
 help / color / mirror / Atom feed
* [PATCH] staging: media: atomisp: fix typo in rx.c
@ 2026-05-23 11:15 Marlon Trujillo
  2026-05-27  5:32 ` Andy Shevchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Marlon Trujillo @ 2026-05-23 11:15 UTC (permalink / raw)
  To: hansg, mchehab, gregkh
  Cc: sakari.ailus, andy, linux-media, linux-staging, linux-kernel

Fix spelling mistake: inptu -> input

Signed-off-by: Marlon Trujillo <marl0rd1080@gmail.com>
---
 drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c b/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c
index 9cfb8bc97e24..ce7035ce8606 100644
--- a/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c
+++ b/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c
@@ -55,7 +55,7 @@ void ia_css_isys_rx_enable_all_interrupts(enum mipi_port_id port)
  * */
 enum mipi_port_id ia_css_isys_port_to_mipi_port(enum mipi_port_id api_port)
 {
-	/* In this module the validity of the inptu variable should
+	/* In this module the validity of the input variable should
 	 * have been checked already, so we do not check for erroneous
 	 * values. */
 	enum mipi_port_id port = MIPI_PORT0_ID;
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: media: atomisp: fix typo in rx.c
  2026-05-23 11:15 [PATCH] staging: media: atomisp: fix typo in rx.c Marlon Trujillo
@ 2026-05-27  5:32 ` Andy Shevchenko
  2026-06-03 11:25   ` Marlon Trujillo
  0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2026-05-27  5:32 UTC (permalink / raw)
  To: Marlon Trujillo
  Cc: hansg, mchehab, gregkh, sakari.ailus, andy, linux-media,
	linux-staging, linux-kernel

On Sat, May 23, 2026 at 1:15 PM Marlon Trujillo <marl0rd1080@gmail.com> wrote:
>
> Fix spelling mistake: inptu -> input

Is this the only one single typo in the whole driver?


> -       /* In this module the validity of the inptu variable should
> +       /* In this module the validity of the input variable should
>          * have been checked already, so we do not check for erroneous
>          * values. */

/*
 * While at it, fix the multi-line comment
 * style as shown in this example.
 */

But before doing that, invest your time into reading linux-media@
mailing list archive and see what others already sent
(lore.kernel.org/linux-media).

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: media: atomisp: fix typo in rx.c
  2026-05-27  5:32 ` Andy Shevchenko
@ 2026-06-03 11:25   ` Marlon Trujillo
  0 siblings, 0 replies; 3+ messages in thread
From: Marlon Trujillo @ 2026-06-03 11:25 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: hansg, mchehab, gregkh, sakari.ailus, andy, linux-media,
	linux-staging, linux-kernel

On Wed, May 27, 2026 at 07:32:30AM +0200, Andy Shevchenko wrote:
> Is this the only one single typo in the whole driver?

No, I took a closer look and found multiple similar typos across
the driver.

> 
> But before doing that, invest your time into reading linux-media@

Thanks, that was helpful. I checked the linux-media archives and
noticed others have already been sending similar typo and comment
style fixes as well.

Given that, I can scan for additional typos and fix them together
with their surrounding comment blocks.

Would you prefer a v2 of this patch, or a separate cleanup patch
(or small series) covering these fixes?

Thanks,
Marlon

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-06-03 11:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-23 11:15 [PATCH] staging: media: atomisp: fix typo in rx.c Marlon Trujillo
2026-05-27  5:32 ` Andy Shevchenko
2026-06-03 11:25   ` Marlon Trujillo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox