Re: Linking Patchwork with Sashiko?

["Theodore Tso" <tytso@mit.edu>]

On Wed, Jul 15, 2026 at 10:06:54PM -0500, Laurent Pinchart wrote:
> This came from a consideration on the impact of false positives
> and other hallucinations on junior developers.

You keep claiming that there is an awful lot of false positives and
other hallucinations.  That's an assertion that needs to be tested to
make sure that we're not relying on a few pieces of anecdata.  How
does this compare with false positives and bogus recommendations from
certain human reviewers?

After all, I can think of at *least* one human reviewer whose reviews
are far worse than Sashiko's in false positives.  That might or might
not be the same person as the one Mark has said that he has a stock
e-mail reply telling a junior developer that they should be free to
ignore reviews from that particular human being.  :-)

Each maintainer can decide how much they trust Shashiko reviews.  At
least for my subsystem, I haven't seen the hallucionations that you
are continually citing, certainly not as a common case.  I will note
that even experienced human reviewers have occasionally flagged an
issue, only to say, "my bad, you're right, it's fine" after a
discussion with the patch author.  And that's OK.  When a human being
makes a false positive criticism, no one responds with "I am feeling
demeaned as a human being!"  Perhaps we should be giving
tool-generated reviews (whether it is via checkpatch or Sashiko) with
a similar level of grace?

At least with tool-generated reviews, we can send bug reports asking
that the tool can be improved.  At least with one particular human
reviewer that I have in mind, no attempts asking that person to
improve their reviews hasn't been helpful.

Bottom line --- if you are making the claim the Sashiko reviews are
rife with false positives, all I can say is <<Citation Needed>>.
 
					- Ted