* unnecessary tests?
@ 2018-06-06 12:41 Julia Lawall
0 siblings, 0 replies; only message in thread
From: Julia Lawall @ 2018-06-06 12:41 UTC (permalink / raw)
To: mchehab, hans.verkuil; +Cc: linux-media, linux-kernel
In the file drivers/media/tuners/mxl5005s.c, the function MXL_BlockInit
contains:
status += MXL_ControlWrite(fe,
RFSYN_EN_CHP_HIGAIN, state->Mode ? 1 : 1);
status += MXL_ControlWrite(fe, EN_CHP_LIN_B, state->Mode ? 0 : 0);
Could the second arguments just be 1 and 0, respectively? It's true that
the preceeding call contains state->Mode, but in a more useful way, so
perhaps it could be useful for uniformity?
thanks,
julia
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-06-06 12:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-06 12:41 unnecessary tests? Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox