* [PATCH v5 1/5] media: rzg2l-cru: Align bytesperline to hardware DMA stride requirement
2026-07-29 10:55 [PATCH v5 0/5] media: rzg2l-cru: Fix DMA stride alignment Tommaso Merciai
@ 2026-07-29 10:55 ` Tommaso Merciai
2026-07-30 19:50 ` Jacopo Mondi
2026-07-29 10:55 ` [PATCH v5 2/5] media: v4l2-common: Convert v4l2_fill_pixfmt_mp() to static inline wrapper Tommaso Merciai
` (3 subsequent siblings)
4 siblings, 1 reply; 7+ messages in thread
From: Tommaso Merciai @ 2026-07-29 10:55 UTC (permalink / raw)
To: tomm.merciai
Cc: linux-renesas-soc, biju.das.jz, Tommaso Merciai, Lad Prabhakar,
Jacopo Mondi, Mauro Carvalho Chehab, Hans Verkuil,
Nicolas Dufresne, Sakari Ailus, Laurent Pinchart,
Sven Püschel, Nas Chung, Mehdi Djait, Isaac Scott,
Paul Cercueil, Daniel Scally, linux-media, linux-kernel, stable
The RZ/G3E CRU programs the line stride via the AMnIS register, whose
IS field encodes the value in units of 128 bytes. If bytesperline is
not a multiple of 128, the division truncates and the hardware uses a
wrong stride, causing horizontal banding.
Commit ace92ccef0c9 ("media: platform: rzg2l-cru: Use v4l2_fill_pixfmt()")
replaced the open-coded aligned calculation with v4l2_fill_pixfmt(),
which sets no alignment, reintroducing the issue.
Round bytesperline up to RZG2L_CRU_STRIDE_ALIGN and recompute
sizeimage when info->has_stride is set. RZ/G2L has no AMnIS register
and keeps the values from v4l2_fill_pixfmt() unchanged.
Fixes: ace92ccef0c9 ("media: platform: rzg2l-cru: Use v4l2_fill_pixfmt()")
Cc: stable@vger.kernel.org
Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
---
v4->v5:
- New patch.
drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
index 5185a547461d..91eda5034248 100644
--- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
+++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
@@ -851,6 +851,11 @@ static void rzg2l_cru_format_align(struct rzg2l_cru_dev *cru,
v4l2_fill_pixfmt(pix, pix->pixelformat, pix->width, pix->height);
+ if (info->has_stride) {
+ pix->bytesperline = ALIGN(pix->bytesperline, RZG2L_CRU_STRIDE_ALIGN);
+ pix->sizeimage = pix->bytesperline * pix->height;
+ }
+
dev_dbg(cru->dev, "Format %ux%u bpl: %u size: %u\n",
pix->width, pix->height, pix->bytesperline, pix->sizeimage);
}
--
2.54.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v5 1/5] media: rzg2l-cru: Align bytesperline to hardware DMA stride requirement
2026-07-29 10:55 ` [PATCH v5 1/5] media: rzg2l-cru: Align bytesperline to hardware DMA stride requirement Tommaso Merciai
@ 2026-07-30 19:50 ` Jacopo Mondi
0 siblings, 0 replies; 7+ messages in thread
From: Jacopo Mondi @ 2026-07-30 19:50 UTC (permalink / raw)
To: Tommaso Merciai
Cc: tomm.merciai, linux-renesas-soc, biju.das.jz, Lad Prabhakar,
Jacopo Mondi, Mauro Carvalho Chehab, Hans Verkuil,
Nicolas Dufresne, Sakari Ailus, Laurent Pinchart,
Sven Püschel, Nas Chung, Mehdi Djait, Isaac Scott,
Paul Cercueil, Daniel Scally, linux-media, linux-kernel, stable
Hi Tommaso
On Wed, Jul 29, 2026 at 12:55:46PM +0200, Tommaso Merciai wrote:
> The RZ/G3E CRU programs the line stride via the AMnIS register, whose
> IS field encodes the value in units of 128 bytes. If bytesperline is
> not a multiple of 128, the division truncates and the hardware uses a
> wrong stride, causing horizontal banding.
>
> Commit ace92ccef0c9 ("media: platform: rzg2l-cru: Use v4l2_fill_pixfmt()")
> replaced the open-coded aligned calculation with v4l2_fill_pixfmt(),
> which sets no alignment, reintroducing the issue.
>
> Round bytesperline up to RZG2L_CRU_STRIDE_ALIGN and recompute
> sizeimage when info->has_stride is set. RZ/G2L has no AMnIS register
> and keeps the values from v4l2_fill_pixfmt() unchanged.
>
> Fixes: ace92ccef0c9 ("media: platform: rzg2l-cru: Use v4l2_fill_pixfmt()")
> Cc: stable@vger.kernel.org
> Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> ---
> v4->v5:
> - New patch.
>
> drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> index 5185a547461d..91eda5034248 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> @@ -851,6 +851,11 @@ static void rzg2l_cru_format_align(struct rzg2l_cru_dev *cru,
>
> v4l2_fill_pixfmt(pix, pix->pixelformat, pix->width, pix->height);
>
> + if (info->has_stride) {
> + pix->bytesperline = ALIGN(pix->bytesperline, RZG2L_CRU_STRIDE_ALIGN);
> + pix->sizeimage = pix->bytesperline * pix->height;
> + }
> +
Ack! I think this does what is expected for the single planar formats
the CRU supports!
I think after this cycle you could send a patch to replace the above
back-portable change with the usage of v4l2_fill_pixfmt_aligned().
When you do so, could you consider, replacing "has_stride" with a per
struct rzg2l_cru_info .stride field ?
I think it would look nicer as you could here unconditionally align
(assuming the new .stride will be set to 1 for G2L which currently has
.has_stride = 0).
Also, RZG2L_CRU_STRIDE_ALIGN is a bit of a mis-nomer, as only G3E and
V2H has a AMnIS register and alignments constraints as far as I see.
The only other user of 'has_stride' I see is:
rzg2l_cru_initialize_axi()
if (info->has_stride) {
u32 stride = cru->format.bytesperline;
u32 amnis;
stride /= RZG2L_CRU_STRIDE_ALIGN;
amnis = rzg2l_cru_read(cru, AMnIS) & ~AMnIS_IS_MASK;
rzg2l_cru_write(cru, AMnIS, amnis | AMnIS_IS(stride));
}
the G2L has no register AMnIS, so we can't write it unconditionally
but rather replace the check with:
if (info->stride > 1)
As a bonus, if any other variant will get a different stride, it will
be automatically supported.
What do you think ?
In the meantime for this patch
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Thanks
j
> dev_dbg(cru->dev, "Format %ux%u bpl: %u size: %u\n",
> pix->width, pix->height, pix->bytesperline, pix->sizeimage);
> }
> --
> 2.54.0
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v5 2/5] media: v4l2-common: Convert v4l2_fill_pixfmt_mp() to static inline wrapper
2026-07-29 10:55 [PATCH v5 0/5] media: rzg2l-cru: Fix DMA stride alignment Tommaso Merciai
2026-07-29 10:55 ` [PATCH v5 1/5] media: rzg2l-cru: Align bytesperline to hardware DMA stride requirement Tommaso Merciai
@ 2026-07-29 10:55 ` Tommaso Merciai
2026-07-29 10:55 ` [PATCH v5 3/5] media: v4l2-common: Add v4l2_fill_pixfmt_aligned() helper Tommaso Merciai
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Tommaso Merciai @ 2026-07-29 10:55 UTC (permalink / raw)
To: tomm.merciai
Cc: linux-renesas-soc, biju.das.jz, Tommaso Merciai, Lad Prabhakar,
Jacopo Mondi, Mauro Carvalho Chehab, Hans Verkuil,
Nicolas Dufresne, Sakari Ailus, Laurent Pinchart,
Sven Püschel, Nas Chung, Mehdi Djait, Isaac Scott,
Paul Cercueil, Daniel Scally, linux-media, linux-kernel,
Jacopo Mondi
Convert v4l2_fill_pixfmt_mp() to static inline wrapper: drop the exported
v4l2_fill_pixfmt_mp() function from v4l2-common.c and replace it with
an equivalent static inline in the header that delegates to
v4l2_fill_pixfmt_mp_aligned() with stride_alignment=1.
Reviewed-by: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
---
v4->v5:
- No changes.
v3->v4:
- Collected tag.
v2->v3:
- No changes
v1->v2:
- New patch
drivers/media/v4l2-core/v4l2-common.c | 8 --------
include/media/v4l2-common.h | 9 +++++++--
2 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c
index 65db7340ad38..54995ba8c20d 100644
--- a/drivers/media/v4l2-core/v4l2-common.c
+++ b/drivers/media/v4l2-core/v4l2-common.c
@@ -537,14 +537,6 @@ int v4l2_fill_pixfmt_mp_aligned(struct v4l2_pix_format_mplane *pixfmt,
}
EXPORT_SYMBOL_GPL(v4l2_fill_pixfmt_mp_aligned);
-int v4l2_fill_pixfmt_mp(struct v4l2_pix_format_mplane *pixfmt,
- u32 pixelformat, u32 width, u32 height)
-{
- return v4l2_fill_pixfmt_mp_aligned(pixfmt, pixelformat,
- width, height, 1);
-}
-EXPORT_SYMBOL_GPL(v4l2_fill_pixfmt_mp);
-
int v4l2_fill_pixfmt(struct v4l2_pix_format *pixfmt, u32 pixelformat,
u32 width, u32 height)
{
diff --git a/include/media/v4l2-common.h b/include/media/v4l2-common.h
index edd416178c33..749fe38c134e 100644
--- a/include/media/v4l2-common.h
+++ b/include/media/v4l2-common.h
@@ -556,13 +556,18 @@ void v4l2_apply_frmsize_constraints(u32 *width, u32 *height,
const struct v4l2_frmsize_stepwise *frmsize);
int v4l2_fill_pixfmt(struct v4l2_pix_format *pixfmt, u32 pixelformat,
u32 width, u32 height);
-int v4l2_fill_pixfmt_mp(struct v4l2_pix_format_mplane *pixfmt, u32 pixelformat,
- u32 width, u32 height);
+
/* @stride_alignment is a power of 2 value in bytes */
int v4l2_fill_pixfmt_mp_aligned(struct v4l2_pix_format_mplane *pixfmt,
u32 pixelformat, u32 width, u32 height,
u8 stride_alignment);
+static inline int v4l2_fill_pixfmt_mp(struct v4l2_pix_format_mplane *pixfmt,
+ u32 pixelformat, u32 width, u32 height)
+{
+ return v4l2_fill_pixfmt_mp_aligned(pixfmt, pixelformat, width, height, 1);
+}
+
/**
* v4l2_get_link_freq - Get link rate from transmitter
*
--
2.54.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v5 3/5] media: v4l2-common: Add v4l2_fill_pixfmt_aligned() helper
2026-07-29 10:55 [PATCH v5 0/5] media: rzg2l-cru: Fix DMA stride alignment Tommaso Merciai
2026-07-29 10:55 ` [PATCH v5 1/5] media: rzg2l-cru: Align bytesperline to hardware DMA stride requirement Tommaso Merciai
2026-07-29 10:55 ` [PATCH v5 2/5] media: v4l2-common: Convert v4l2_fill_pixfmt_mp() to static inline wrapper Tommaso Merciai
@ 2026-07-29 10:55 ` Tommaso Merciai
2026-07-29 10:55 ` [PATCH v5 4/5] media: v4l2-common: Add kernel-doc for v4l2_fill_pixfmt_mp_aligned() Tommaso Merciai
2026-07-29 10:55 ` [PATCH v5 5/5] media: rzg2l-cru: Use v4l2_fill_pixfmt_aligned() for stride alignment Tommaso Merciai
4 siblings, 0 replies; 7+ messages in thread
From: Tommaso Merciai @ 2026-07-29 10:55 UTC (permalink / raw)
To: tomm.merciai
Cc: linux-renesas-soc, biju.das.jz, Tommaso Merciai, Lad Prabhakar,
Jacopo Mondi, Mauro Carvalho Chehab, Hans Verkuil,
Nicolas Dufresne, Sakari Ailus, Laurent Pinchart,
Sven Püschel, Nas Chung, Mehdi Djait, Isaac Scott,
Paul Cercueil, Daniel Scally, linux-media, linux-kernel,
Jacopo Mondi
Add v4l2_fill_pixfmt_aligned(), a variant of v4l2_fill_pixfmt()
that accepts a stride_alignment parameter, mirroring the existing
v4l2_fill_pixfmt_mp() / v4l2_fill_pixfmt_mp_aligned() pair.
v4l2_fill_pixfmt() is refactored to call v4l2_fill_pixfmt_aligned()
with stride_alignment=1, preserving its existing behaviour.
The new helper is needed by drivers whose DMA engine requires the
line stride to be a multiple of a specific value, such as the
Renesas RZ/G3E CRU which requires 128-byte alignment.
Reviewed-by: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
---
v4->v5:
- No changes.
v3->v4:
- Collected tag.
- Removed "." at the end of the function's brief description
- Removed "component" from @pixfmt->sizeimage line
- Removed wrong tab
- Fixed example (e.g NV12) -> (e.g. YUV420) into function description
v2->v3:
- No changes, just moved to from PATCH 3/4 to PATCH 2/4
v1->v2:
- Move v4l2_fill_pixfmt() into v4l2-common.h as inline wrapper
- Add v4l2_fill_pixfmt_aligned() helper documentation.
drivers/media/v4l2-core/v4l2-common.c | 12 +++++----
include/media/v4l2-common.h | 38 +++++++++++++++++++++++++--
2 files changed, 43 insertions(+), 7 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c
index 54995ba8c20d..2ce4f1c20fbc 100644
--- a/drivers/media/v4l2-core/v4l2-common.c
+++ b/drivers/media/v4l2-core/v4l2-common.c
@@ -537,8 +537,8 @@ int v4l2_fill_pixfmt_mp_aligned(struct v4l2_pix_format_mplane *pixfmt,
}
EXPORT_SYMBOL_GPL(v4l2_fill_pixfmt_mp_aligned);
-int v4l2_fill_pixfmt(struct v4l2_pix_format *pixfmt, u32 pixelformat,
- u32 width, u32 height)
+int v4l2_fill_pixfmt_aligned(struct v4l2_pix_format *pixfmt, u32 pixelformat,
+ u32 width, u32 height, u8 stride_alignment)
{
const struct v4l2_format_info *info;
int i;
@@ -554,15 +554,17 @@ int v4l2_fill_pixfmt(struct v4l2_pix_format *pixfmt, u32 pixelformat,
pixfmt->width = width;
pixfmt->height = height;
pixfmt->pixelformat = pixelformat;
- pixfmt->bytesperline = v4l2_format_plane_stride(info, 0, width, 1);
+ pixfmt->bytesperline = v4l2_format_plane_stride(info, 0, width,
+ stride_alignment);
pixfmt->sizeimage = 0;
for (i = 0; i < info->comp_planes; i++)
pixfmt->sizeimage +=
- v4l2_format_plane_size(info, i, width, height, 1);
+ v4l2_format_plane_size(info, i, width, height,
+ stride_alignment);
return 0;
}
-EXPORT_SYMBOL_GPL(v4l2_fill_pixfmt);
+EXPORT_SYMBOL_GPL(v4l2_fill_pixfmt_aligned);
#ifdef CONFIG_MEDIA_CONTROLLER
static s64 v4l2_get_link_freq_ctrl(struct v4l2_ctrl_handler *handler,
diff --git a/include/media/v4l2-common.h b/include/media/v4l2-common.h
index 749fe38c134e..4e5c5ffaf651 100644
--- a/include/media/v4l2-common.h
+++ b/include/media/v4l2-common.h
@@ -554,8 +554,42 @@ static inline bool v4l2_is_format_bayer(const struct v4l2_format_info *f)
const struct v4l2_format_info *v4l2_format_info(u32 format);
void v4l2_apply_frmsize_constraints(u32 *width, u32 *height,
const struct v4l2_frmsize_stepwise *frmsize);
-int v4l2_fill_pixfmt(struct v4l2_pix_format *pixfmt, u32 pixelformat,
- u32 width, u32 height);
+
+/**
+ * v4l2_fill_pixfmt_aligned - Fill in a &struct v4l2_pix_format with stride
+ * alignment requirements
+ *
+ * @pixfmt: pointer to the &struct v4l2_pix_format to be filled
+ * @pixelformat: the V4L2 pixel format (V4L2_PIX_FMT_*)
+ * @width: image width in pixels
+ * @height: image height in pixels
+ * @stride_alignment: stride alignment in bytes, must be a power of 2
+ *
+ * Fills all fields of @pixfmt for the given pixel format, dimensions, and
+ * stride alignment. Only formats stored in a single memory plane are
+ * supported; returns -EINVAL for multi-memory-plane formats.
+ *
+ * @pixfmt->bytesperline is set to the stride of the primary (plane 0) plane,
+ * rounded up to a multiple of @stride_alignment. For formats that store
+ * multiple component planes in a single memory buffer (e.g. YUV420), the
+ * alignment applied to each component plane's stride is scaled relative to
+ * @stride_alignment so that the chroma stride remains consistently derivable
+ * from the luma stride. @pixfmt->bytesperline therefore reflects only the
+ * primary plane stride.
+ *
+ * @pixfmt->sizeimage is set to the total size in bytes of all planes.
+ *
+ * Return: 0 on success, -EINVAL if @pixelformat is unknown or uses multiple
+ * memory planes.
+ */
+int v4l2_fill_pixfmt_aligned(struct v4l2_pix_format *pixfmt, u32 pixelformat,
+ u32 width, u32 height, u8 stride_alignment);
+
+static inline int v4l2_fill_pixfmt(struct v4l2_pix_format *pixfmt,
+ u32 pixelformat, u32 width, u32 height)
+{
+ return v4l2_fill_pixfmt_aligned(pixfmt, pixelformat, width, height, 1);
+}
/* @stride_alignment is a power of 2 value in bytes */
int v4l2_fill_pixfmt_mp_aligned(struct v4l2_pix_format_mplane *pixfmt,
--
2.54.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v5 4/5] media: v4l2-common: Add kernel-doc for v4l2_fill_pixfmt_mp_aligned()
2026-07-29 10:55 [PATCH v5 0/5] media: rzg2l-cru: Fix DMA stride alignment Tommaso Merciai
` (2 preceding siblings ...)
2026-07-29 10:55 ` [PATCH v5 3/5] media: v4l2-common: Add v4l2_fill_pixfmt_aligned() helper Tommaso Merciai
@ 2026-07-29 10:55 ` Tommaso Merciai
2026-07-29 10:55 ` [PATCH v5 5/5] media: rzg2l-cru: Use v4l2_fill_pixfmt_aligned() for stride alignment Tommaso Merciai
4 siblings, 0 replies; 7+ messages in thread
From: Tommaso Merciai @ 2026-07-29 10:55 UTC (permalink / raw)
To: tomm.merciai
Cc: linux-renesas-soc, biju.das.jz, Tommaso Merciai, Lad Prabhakar,
Jacopo Mondi, Mauro Carvalho Chehab, Hans Verkuil,
Nicolas Dufresne, Sakari Ailus, Laurent Pinchart,
Sven Püschel, Nas Chung, Mehdi Djait, Isaac Scott,
Paul Cercueil, Daniel Scally, linux-media, linux-kernel,
Jacopo Mondi
Replace the bare placeholder comment with a full kernel-doc block
documenting all parameters, the function behaviour for both single
memory plane (mem_planes == 1) and multiple memory plane (mem_planes > 1)
formats, and the return value.
Reviewed-by: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
---
v4->v5:
- No changes.
v3->v4:
- Collected tag.
- Fixed function documentation.
v2->v3:
- Moved to PATCH 3/4
- Fixed documentation as suggested by Sven Püschel
v1->v2:
- New patch
include/media/v4l2-common.h | 28 +++++++++++++++++++++++++++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/include/media/v4l2-common.h b/include/media/v4l2-common.h
index 4e5c5ffaf651..33f5713734cb 100644
--- a/include/media/v4l2-common.h
+++ b/include/media/v4l2-common.h
@@ -591,7 +591,33 @@ static inline int v4l2_fill_pixfmt(struct v4l2_pix_format *pixfmt,
return v4l2_fill_pixfmt_aligned(pixfmt, pixelformat, width, height, 1);
}
-/* @stride_alignment is a power of 2 value in bytes */
+/**
+ * v4l2_fill_pixfmt_mp_aligned - Fill in a &struct v4l2_pix_format_mplane with
+ * stride alignment requirements.
+ *
+ * @pixfmt: pointer to the &struct v4l2_pix_format_mplane to be filled
+ * @pixelformat: the V4L2 pixel format (V4L2_PIX_FMT_*)
+ * @width: image width in pixels
+ * @height: image height in pixels
+ * @stride_alignment: stride alignment in bytes; must be a power of 2
+ *
+ * Fills all fields of @pixfmt for the given pixel format, dimensions, and
+ * stride alignment.
+ *
+ * For formats stored in a single memory plane (mem_planes == 1), the
+ * behaviour matches v4l2_fill_pixfmt_aligned(): plane_fmt[0].bytesperline
+ * is set to the primary plane stride. The strides of all components are
+ * aligned to the @stride_alignment. To keep the chroma strides consistently
+ * derivable from the luma stride, strides may be aligned to a multiple of
+ * the @stride_alignment instead. plane_fmt[0].sizeimage covers all
+ * component planes.
+ *
+ * For formats with multiple memory planes (mem_planes > 1), each plane's
+ * bytesperline is independently rounded up to @stride_alignment, and each
+ * plane's sizeimage is set to bytesperline multiplied by the plane height.
+ *
+ * Return: 0 on success, -EINVAL if @pixelformat is unknown.
+ */
int v4l2_fill_pixfmt_mp_aligned(struct v4l2_pix_format_mplane *pixfmt,
u32 pixelformat, u32 width, u32 height,
u8 stride_alignment);
--
2.54.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v5 5/5] media: rzg2l-cru: Use v4l2_fill_pixfmt_aligned() for stride alignment
2026-07-29 10:55 [PATCH v5 0/5] media: rzg2l-cru: Fix DMA stride alignment Tommaso Merciai
` (3 preceding siblings ...)
2026-07-29 10:55 ` [PATCH v5 4/5] media: v4l2-common: Add kernel-doc for v4l2_fill_pixfmt_mp_aligned() Tommaso Merciai
@ 2026-07-29 10:55 ` Tommaso Merciai
4 siblings, 0 replies; 7+ messages in thread
From: Tommaso Merciai @ 2026-07-29 10:55 UTC (permalink / raw)
To: tomm.merciai
Cc: linux-renesas-soc, biju.das.jz, Tommaso Merciai, Lad Prabhakar,
Jacopo Mondi, Mauro Carvalho Chehab, Hans Verkuil,
Nicolas Dufresne, Sakari Ailus, Laurent Pinchart,
Sven Püschel, Nas Chung, Mehdi Djait, Isaac Scott,
Paul Cercueil, Daniel Scally, linux-media, linux-kernel
Replace the open-coded bytesperline/sizeimage rounding with the newly
added v4l2_fill_pixfmt_aligned().
No functional change intended.
Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
---
v4->v5:
- Split the fix so it no longer depends on v4l2_fill_pixfmt_aligned()
and moved it first in the series, so it can be backported to stable
on its own (This the old v4 PATCH 4/4).
drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
index 91eda5034248..27a35ef2a6df 100644
--- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
+++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
@@ -849,12 +849,8 @@ static void rzg2l_cru_format_align(struct rzg2l_cru_dev *cru,
v4l_bound_align_image(&pix->width, 320, info->max_width, 1,
&pix->height, 240, info->max_height, 2, 0);
- v4l2_fill_pixfmt(pix, pix->pixelformat, pix->width, pix->height);
-
- if (info->has_stride) {
- pix->bytesperline = ALIGN(pix->bytesperline, RZG2L_CRU_STRIDE_ALIGN);
- pix->sizeimage = pix->bytesperline * pix->height;
- }
+ v4l2_fill_pixfmt_aligned(pix, pix->pixelformat, pix->width, pix->height,
+ info->has_stride ? RZG2L_CRU_STRIDE_ALIGN : 1);
dev_dbg(cru->dev, "Format %ux%u bpl: %u size: %u\n",
pix->width, pix->height, pix->bytesperline, pix->sizeimage);
--
2.54.0
^ permalink raw reply related [flat|nested] 7+ messages in thread