* [PATCH] staging: media: atomisp: align * on comment
@ 2026-07-23 16:18 Julieta Goria
2026-08-06 23:02 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Julieta Goria @ 2026-07-23 16:18 UTC (permalink / raw)
To: hansg, mchehab, sakari.ailus, andy, gregkh, linux-media,
linux-kernel, linux-staging
Cc: ~lkcamp/patches, koike, Julieta Goria
fixed the following checkpatch warning:
WARNING: Block comments should align the * on each line
in staging/drivers/staging/media/atomisp/pci/isp/kernels/ctc/ctc2/ia_css_ctc2.host.c:80:
Signed-off-by: Julieta Goria <jgoria@dc.uba.ar>
---
Hey, this is my first patch contribution, I would appreciate any feedback. Thanks!
---
.../atomisp/pci/isp/kernels/ctc/ctc2/ia_css_ctc2.host.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/ctc/ctc2/ia_css_ctc2.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/ctc/ctc2/ia_css_ctc2.host.c
index 177487b6b237..28fe34f2a848 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/ctc/ctc2/ia_css_ctc2.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/ctc/ctc2/ia_css_ctc2.host.c
@@ -77,9 +77,9 @@ void ia_css_ctc2_vmem_encode(struct ia_css_isp_ctc2_vmem_params *to,
(void)size;
/*
- * Calculation of slopes of lines interconnecting
- * 0.0 -> y_x1 -> y_x2 -> y _x3 -> y_x4 -> 1.0
- */
+ * Calculation of slopes of lines interconnecting
+ * 0.0 -> y_x1 -> y_x2 -> y _x3 -> y_x4 -> 1.0
+ */
dydx0 = ctc2_slope(from->y_y1, from->y_y0,
from->y_x1, 0);
dydx1 = ctc2_slope(from->y_y2, from->y_y1,
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: media: atomisp: align * on comment
2026-07-23 16:18 [PATCH] staging: media: atomisp: align * on comment Julieta Goria
@ 2026-08-06 23:02 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2026-08-06 23:02 UTC (permalink / raw)
To: Julieta Goria
Cc: hansg, mchehab, sakari.ailus, andy, gregkh, linux-media,
linux-kernel, linux-staging, ~lkcamp/patches, koike
On Thu, Jul 23, 2026 at 01:18:12PM -0300, Julieta Goria wrote:
> fixed the following checkpatch warning:
> WARNING: Block comments should align the * on each line
> in staging/drivers/staging/media/atomisp/pci/isp/kernels/ctc/ctc2/ia_css_ctc2.host.c:80:
>
> Signed-off-by: Julieta Goria <jgoria@dc.uba.ar>
>
> ---
>
> Hey, this is my first patch contribution, I would appreciate any feedback. Thanks!
Right.
Please, read lore.kernel.org linux-media@ archives against this driver to
understand why this patch is no-go.
Also, if you are in a group that is mentored, tell to the mentors to stop
looking into this driver by a newbie. This driver has much more urgent tasks
to do and it's not trivial, it also requires a real HW to be at hand to test.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-06 23:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-23 16:18 [PATCH] staging: media: atomisp: align * on comment Julieta Goria
2026-08-06 23:02 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox