[RFC PATCH] media: ti: cal: Deprecate non-MC API usage

[RFC PATCH] media: ti: cal: Deprecate non-MC API usage

[Laurent Pinchart]

The MC API was introduced in the CAL driver more than five years ago in
commit 38e89e790fe2 ("media: ti-vpe: cal: Implement media controller
centric API") as a disabled by default option. Five years later, it's
time to give users another nudge to move to the MC API. Deprecate non-MC
API usage by printing a warning at probe time, and defaulting to the MC
API. The legacy API can still be selected through the mc_api module
parameter.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/media/platform/ti/Kconfig   | 11 -----------
 drivers/media/platform/ti/cal/cal.c | 10 +++-------
 2 files changed, 3 insertions(+), 18 deletions(-)

diff --git a/drivers/media/platform/ti/Kconfig b/drivers/media/platform/ti/Kconfig
index 1a020b2bbb4f..03df5617e99d 100644
--- a/drivers/media/platform/ti/Kconfig
+++ b/drivers/media/platform/ti/Kconfig
@@ -30,17 +30,6 @@ config VIDEO_TI_CAL
 	  In TI Technical Reference Manual this module is referred as
 	  Camera Interface Subsystem (CAMSS).
 
-config VIDEO_TI_CAL_MC
-	bool "Media Controller centric mode by default"
-	depends on VIDEO_TI_CAL
-	default n
-	help
-	  Enables Media Controller centric mode by default.
-
-	  If set, CAL driver will start in Media Controller mode by
-	  default. Note that this behavior can be overridden via
-	  module parameter 'mc_api'.
-
 config VIDEO_TI_VIP
         tristate "TI Video Input Port"
         depends on VIDEO_DEV
diff --git a/drivers/media/platform/ti/cal/cal.c b/drivers/media/platform/ti/cal/cal.c
index b7e77b6b8950..5c82378d1eee 100644
--- a/drivers/media/platform/ti/cal/cal.c
+++ b/drivers/media/platform/ti/cal/cal.c
@@ -43,13 +43,7 @@ unsigned int cal_debug;
 module_param_named(debug, cal_debug, uint, 0644);
 MODULE_PARM_DESC(debug, "activates debug info");
 
-#ifdef CONFIG_VIDEO_TI_CAL_MC
-#define CAL_MC_API_DEFAULT 1
-#else
-#define CAL_MC_API_DEFAULT 0
-#endif
-
-bool cal_mc_api = CAL_MC_API_DEFAULT;
+bool cal_mc_api = 1;
 module_param_named(mc_api, cal_mc_api, bool, 0444);
 MODULE_PARM_DESC(mc_api, "activates the MC API");
 
@@ -1228,6 +1222,8 @@ static int cal_probe(struct platform_device *pdev)
 
 	/* Create contexts. */
 	if (!cal_mc_api) {
+		dev_warn(cal->dev, "The legacy non-MC API is deprecated\n");
+
 		for (i = 0; i < cal->data->num_csi2_phy; ++i) {
 			struct cal_ctx *ctx;
 

base-commit: a52e6f7923c17a672135b485ffd96fbd72f46267
-- 
Regards,

Laurent Pinchart

Re: [RFC PATCH] media: ti: cal: Deprecate non-MC API usage

[Tomi Valkeinen]

Hi,

On 23/07/2026 14:19, Laurent Pinchart wrote:
> The MC API was introduced in the CAL driver more than five years ago in
> commit 38e89e790fe2 ("media: ti-vpe: cal: Implement media controller
> centric API") as a disabled by default option. Five years later, it's
> time to give users another nudge to move to the MC API. Deprecate non-MC
> API usage by printing a warning at probe time, and defaulting to the MC
> API. The legacy API can still be selected through the mc_api module
> parameter.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>   drivers/media/platform/ti/Kconfig   | 11 -----------
>   drivers/media/platform/ti/cal/cal.c | 10 +++-------
>   2 files changed, 3 insertions(+), 18 deletions(-)
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

  Tomi

Re: [RFC PATCH] media: ti: cal: Deprecate non-MC API usage

[Laurent Pinchart]

Yemike, are you fine with this patch ?

On Tue, Jul 28, 2026 at 03:26:47PM +0300, Tomi Valkeinen wrote:
> On 23/07/2026 14:19, Laurent Pinchart wrote:
> > The MC API was introduced in the CAL driver more than five years ago in
> > commit 38e89e790fe2 ("media: ti-vpe: cal: Implement media controller
> > centric API") as a disabled by default option. Five years later, it's
> > time to give users another nudge to move to the MC API. Deprecate non-MC
> > API usage by printing a warning at probe time, and defaulting to the MC
> > API. The legacy API can still be selected through the mc_api module
> > parameter.
> > 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> >   drivers/media/platform/ti/Kconfig   | 11 -----------
> >   drivers/media/platform/ti/cal/cal.c | 10 +++-------
> >   2 files changed, 3 insertions(+), 18 deletions(-)
> 
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

-- 
Regards,

Laurent Pinchart

Re: [RFC PATCH] media: ti: cal: Deprecate non-MC API usage

[Yemike Abhilash Chandra]

Hi Laurent,
Thanks for the patch.

On 02/09/26 17:54, Laurent Pinchart wrote:
> Yemike, are you fine with this patch ?
> 

Yes, I apologize for missing this.

Reviewed-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>

Thanks and regards,
Yemike Abhilash Chandra

> On Tue, Jul 28, 2026 at 03:26:47PM +0300, Tomi Valkeinen wrote:
>> On 23/07/2026 14:19, Laurent Pinchart wrote:
>>> The MC API was introduced in the CAL driver more than five years ago in
>>> commit 38e89e790fe2 ("media: ti-vpe: cal: Implement media controller
>>> centric API") as a disabled by default option. Five years later, it's
>>> time to give users another nudge to move to the MC API. Deprecate non-MC
>>> API usage by printing a warning at probe time, and defaulting to the MC
>>> API. The legacy API can still be selected through the mc_api module
>>> parameter.
>>>
>>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>> ---
>>>    drivers/media/platform/ti/Kconfig   | 11 -----------
>>>    drivers/media/platform/ti/cal/cal.c | 10 +++-------
>>>    2 files changed, 3 insertions(+), 18 deletions(-)
>>
>> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> 

Re: [RFC PATCH] media: ti: cal: Deprecate non-MC API usage

[Laurent Pinchart]

On Wed, Sep 02, 2026 at 08:23:16PM +0530, Yemike Abhilash Chandra wrote:
> Hi Laurent,
> Thanks for the patch.
> 
> On 02/09/26 17:54, Laurent Pinchart wrote:
> > Yemike, are you fine with this patch ?
> > 
> 
> Yes, I apologize for missing this.

No worries. Thanks for the reply.

> Reviewed-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
> 
> Thanks and regards,
> Yemike Abhilash Chandra
> 
> > On Tue, Jul 28, 2026 at 03:26:47PM +0300, Tomi Valkeinen wrote:
> >> On 23/07/2026 14:19, Laurent Pinchart wrote:
> >>> The MC API was introduced in the CAL driver more than five years ago in
> >>> commit 38e89e790fe2 ("media: ti-vpe: cal: Implement media controller
> >>> centric API") as a disabled by default option. Five years later, it's
> >>> time to give users another nudge to move to the MC API. Deprecate non-MC
> >>> API usage by printing a warning at probe time, and defaulting to the MC
> >>> API. The legacy API can still be selected through the mc_api module
> >>> parameter.
> >>>
> >>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >>> ---
> >>>    drivers/media/platform/ti/Kconfig   | 11 -----------
> >>>    drivers/media/platform/ti/cal/cal.c | 10 +++-------
> >>>    2 files changed, 3 insertions(+), 18 deletions(-)
> >>
> >> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

-- 
Regards,

Laurent Pinchart

Re: [RFC PATCH] media: ti: cal: Deprecate non-MC API usage

[Sakari Ailus]

On Thu, Jul 23, 2026 at 02:19:03PM +0300, Laurent Pinchart wrote:
> The MC API was introduced in the CAL driver more than five years ago in
> commit 38e89e790fe2 ("media: ti-vpe: cal: Implement media controller
> centric API") as a disabled by default option. Five years later, it's
> time to give users another nudge to move to the MC API. Deprecate non-MC
> API usage by printing a warning at probe time, and defaulting to the MC
> API. The legacy API can still be selected through the mc_api module
> parameter.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

-- 
Sakari Ailus