Re: [PATCH v3 15/29] media: v4l2-subdev: Return dynamically allocated pass-through routes

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hej Linus,

On Wed, Sep 02, 2026 at 07:44:32AM +0200, Linus Walleij wrote:
> Hi Sakari,
> 
> thanks for your patch!
> 
> On Mon, Aug 24, 2026 at 2:15 PM Sakari Ailus
> <sakari.ailus@linux.intel.com> wrote:
> 
> > Count the number of pass-through routes, allocate memory and then return
> > the full table to the caller.
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> (...)
> > +       if (num_entries > V4L2_FRAME_DESC_ENTRY_PREALLOC) {
> > +               fd->entry = kzalloc_objs(*fd->entry, num_entries, GFP_KERNEL);
> 
> So if it's more entries than the preallocated ones we kzalloc_ new ones.
> 
> And from this point in the code we want to clean up:
> 
> > +                                       goto err_free;
> (...)
> > +err_free:
> > +       kfree(fd->entry);
> 
> But what happens if the preallocated descs are enough?
> 
> Then you just kfree():ed the preallocated entries, which are
> stored in the same pointer.

Oops. I'll fix that for v4.

-- 
Med trevliga hälsningar,

Sakari Ailus