* [PATCH 1/1] media: ipu6: Make ipu6_dma_{un,}map_sg() static
@ 2026-11-18 9:57 Sakari Ailus
2026-11-18 11:42 ` Mehdi Djait
0 siblings, 1 reply; 2+ messages in thread
From: Sakari Ailus @ 2026-11-18 9:57 UTC (permalink / raw)
To: linux-media; +Cc: Antti Laakso, Sapre, Sarang, Divyamani Tripathi, Manik Bajpai
Make ipu6_dma_map_sg() and ipu6_dma_unmap_sg() static as they are only
used within the same file.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/media/pci/intel/ipu6/ipu6-dma.c | 14 ++++++--------
drivers/media/pci/intel/ipu6/ipu6-dma.h | 6 ------
2 files changed, 6 insertions(+), 14 deletions(-)
diff --git a/drivers/media/pci/intel/ipu6/ipu6-dma.c b/drivers/media/pci/intel/ipu6/ipu6-dma.c
index 90f530a93779..ea13a58a80f8 100644
--- a/drivers/media/pci/intel/ipu6/ipu6-dma.c
+++ b/drivers/media/pci/intel/ipu6/ipu6-dma.c
@@ -327,9 +327,9 @@ int ipu6_dma_mmap(struct ipu6_bus_device *sys, struct vm_area_struct *vma,
return 0;
}
-void ipu6_dma_unmap_sg(struct ipu6_bus_device *sys, struct scatterlist *sglist,
- int nents, enum dma_data_direction dir,
- unsigned long attrs)
+static void ipu6_dma_unmap_sg(struct ipu6_bus_device *sys,
+ struct scatterlist *sglist, int nents,
+ enum dma_data_direction dir, unsigned long attrs)
{
struct device *dev = &sys->auxdev.dev;
struct ipu6_mmu *mmu = sys->mmu;
@@ -369,7 +369,6 @@ void ipu6_dma_unmap_sg(struct ipu6_bus_device *sys, struct scatterlist *sglist,
mmu->ops->tlb_invalidate(mmu);
__free_iova(&mmu->dmap->iovad, iova);
}
-EXPORT_SYMBOL_NS_GPL(ipu6_dma_unmap_sg, "INTEL_IPU6");
static struct iova *ipu7_get_fw_code_region(struct ipu6_bus_device *sys)
{
@@ -382,9 +381,9 @@ static struct iova *ipu7_get_fw_code_region(struct ipu6_bus_device *sys)
return reserve_iova(&mmu->dmap->iovad, lo, hi);
}
-int ipu6_dma_map_sg(struct ipu6_bus_device *sys, struct scatterlist *sglist,
- int nents, enum dma_data_direction dir,
- unsigned long attrs)
+static int ipu6_dma_map_sg(struct ipu6_bus_device *sys,
+ struct scatterlist *sglist, int nents,
+ enum dma_data_direction dir, unsigned long attrs)
{
struct device *dev = &sys->auxdev.dev;
struct ipu6_mmu *mmu = sys->mmu;
@@ -448,7 +447,6 @@ int ipu6_dma_map_sg(struct ipu6_bus_device *sys, struct scatterlist *sglist,
return 0;
}
-EXPORT_SYMBOL_NS_GPL(ipu6_dma_map_sg, "INTEL_IPU6");
int ipu6_dma_map_sgtable(struct ipu6_bus_device *sys, struct sg_table *sgt,
enum dma_data_direction dir, unsigned long attrs)
diff --git a/drivers/media/pci/intel/ipu6/ipu6-dma.h b/drivers/media/pci/intel/ipu6/ipu6-dma.h
index e5e0e7860423..bd1a0481f1ac 100644
--- a/drivers/media/pci/intel/ipu6/ipu6-dma.h
+++ b/drivers/media/pci/intel/ipu6/ipu6-dma.h
@@ -32,12 +32,6 @@ void ipu6_dma_free(struct ipu6_bus_device *sys, size_t size, void *vaddr,
int ipu6_dma_mmap(struct ipu6_bus_device *sys, struct vm_area_struct *vma,
void *addr, dma_addr_t iova, size_t size,
unsigned long attrs);
-int ipu6_dma_map_sg(struct ipu6_bus_device *sys, struct scatterlist *sglist,
- int nents, enum dma_data_direction dir,
- unsigned long attrs);
-void ipu6_dma_unmap_sg(struct ipu6_bus_device *sys, struct scatterlist *sglist,
- int nents, enum dma_data_direction dir,
- unsigned long attrs);
int ipu6_dma_map_sgtable(struct ipu6_bus_device *sys, struct sg_table *sgt,
enum dma_data_direction dir, unsigned long attrs);
void ipu6_dma_unmap_sgtable(struct ipu6_bus_device *sys, struct sg_table *sgt,
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] media: ipu6: Make ipu6_dma_{un,}map_sg() static
2026-11-18 9:57 [PATCH 1/1] media: ipu6: Make ipu6_dma_{un,}map_sg() static Sakari Ailus
@ 2026-11-18 11:42 ` Mehdi Djait
0 siblings, 0 replies; 2+ messages in thread
From: Mehdi Djait @ 2026-11-18 11:42 UTC (permalink / raw)
To: Sakari Ailus
Cc: linux-media, Antti Laakso, Sapre, Sarang, Divyamani Tripathi,
Manik Bajpai
Hi Sakari,
On Wed, Nov 18, 2026 at 11:57:40AM +0200, Sakari Ailus wrote:
> Make ipu6_dma_map_sg() and ipu6_dma_unmap_sg() static as they are only
> used within the same file.
This is also the case for ipu6_dma_sync_sg()
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Kind Regards
Mehdi Djait
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-18 11:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18 9:57 [PATCH 1/1] media: ipu6: Make ipu6_dma_{un,}map_sg() static Sakari Ailus
2026-11-18 11:42 ` Mehdi Djait
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox