Linux Media Controller development
 help / color / mirror / Atom feed
* [PATCH v2] media: rcar-vin: Return unused buffers correctly
@ 2026-11-21 11:54 Niklas Söderlund
  2026-11-22 18:25 ` Jacopo Mondi
  0 siblings, 1 reply; 2+ messages in thread
From: Niklas Söderlund @ 2026-11-21 11:54 UTC (permalink / raw)
  To: Niklas Söderlund, Mauro Carvalho Chehab, Geert Uytterhoeven,
	Magnus Damm, Jacopo Mondi
  Cc: linux-media, linux-renesas-soc, linux-kernel,
	Niklas Söderlund

Unused VB2 buffers should be returned with state DONE not ERROR when
stopping.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
Changes in v2:
- Link to v1: https://patch.msgid.link/20260828-vin-fix-vb2-v1-1-97eb1f4f75c9@ragnatech.se
---
* Changes since v1
- Fix unused buffers returned in rvin_stop_streaming() too.
---
 drivers/media/platform/renesas/rcar-vin/rcar-dma.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
index 5e515d16c164..d3d1af47f8b1 100644
--- a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
+++ b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
@@ -1434,7 +1434,7 @@ void rvin_stop_streaming(struct rvin_dev *vin)
 	for (unsigned int i = 0; i < HW_BUFFER_NUM; i++) {
 		if (vin->buf_hw[i].buffer)
 			vb2_buffer_done(&vin->buf_hw[i].buffer->vb2_buf,
-					VB2_BUF_STATE_ERROR);
+					VB2_BUF_STATE_DONE);
 	}
 
 }
@@ -1449,7 +1449,7 @@ static void rvin_stop_streaming_vq(struct vb2_queue *vq)
 	dma_free_coherent(vin->dev, vin->format.sizeimage, vin->scratch,
 			  vin->scratch_phys);
 
-	return_unused_buffers(vin, VB2_BUF_STATE_ERROR);
+	return_unused_buffers(vin, VB2_BUF_STATE_DONE);
 }
 
 static const struct vb2_ops rvin_qops = {

---
base-commit: aa0f4c41d4870a18e65772a1817af16427200371
change-id: 20260828-vin-fix-vb2-28e1bb24a618

Best regards,
--  
Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-22 18:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-21 11:54 [PATCH v2] media: rcar-vin: Return unused buffers correctly Niklas Söderlund
2026-11-22 18:25 ` Jacopo Mondi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox