Linux Media Controller development
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bod@kernel.org>
To: Jesse Casco <jesse.casco@gmail.com>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	Loic Poulain <loic.poulain@oss.qualcomm.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>,
	Allan Siriani <allan@fatecpompeia.edu.br>,
	linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/2] media: qcom: camss: Map each CSID to the VFE it feeds
Date: Sun, 22 Nov 2026 02:14:17 +0000	[thread overview]
Message-ID: <bdc56ab4-bdfc-4fca-90e9-d062492d5bb4@kernel.org> (raw)
In-Reply-To: <9e5bee0dbc1c116672ba0020013ef0a346385c29.1795196107.git.jesse.casco@gmail.com>

On 20/11/2026 17:40, Jesse Casco wrote:
> CAMSS assumes that CSID n feeds VFE n: csid_set_power() powers the VFE
> with the CSID's index through parent_dev_ops, camss_buf_done() is passed
> a CSID index and completes the buffer on the VFE of that index, and
> camss_reg_update() is passed a VFE index and updates the CSID of that
> index.
> 
> That holds as long as a SoC has the same number of full CSIDs and full
> VFEs, with the lite blocks after them. X1E80100 has three full CSIDs but
> only two full VFEs:
> 
>    CSID:  0, 1, 2, LITE0 (3), LITE1 (4)
>    VFE:   0, 1, LITE0 (2), LITE1 (3)
> 
> so CSID2 powers VFE_LITE0, CSID_LITE0 powers VFE_LITE1, and CSID_LITE1
> fails to stream with "Failed to power up pipeline: -22" because there is
> no VFE 4.

That _should_ be the case so in fact having the CSID2 declaration is a 
waste of time/effort - it is dead silicon that can't deliver data to 
user-space.

Better to drop it and tidy up our code. If someone comes up with a real 
use-case for it we can switch it back on and do the surgery to route things.

In the meantime keep it simple.

20261122-camss-routing-fixes-v1-0-0deeeaca2622@kernel.org

I'll take patch #1 from your series and skip this one. Dropping CSID2 is 
IMO the correct path.

bod

  parent reply	other threads:[~2026-11-22  2:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 17:40 [PATCH 0/2] media: qcom: camss: Fix the X1E80100 lite CSID paths Jesse Casco
2026-11-20 17:40 ` [PATCH 1/2] media: qcom: camss: x1e80100: Use the lite clocks for the lite CSIDs Jesse Casco
2026-11-20 19:29   ` Loic Poulain
2026-11-21  9:44   ` Bryan O'Donoghue
2026-11-20 17:40 ` [PATCH 2/2] media: qcom: camss: Map each CSID to the VFE it feeds Jesse Casco
2026-11-20 19:39   ` Loic Poulain
2026-11-20 19:56     ` Gjorgji Rosikopulos (Consultant)
2026-11-20 20:32       ` Gjorgji Rosikopulos (Consultant)
2026-11-20 20:51   ` Gjorgji Rosikopulos (Consultant)
2026-11-20 22:00     ` Allan Siriani
2026-11-22  0:28       ` Jesse Casco
2026-11-22  2:14   ` Bryan O'Donoghue [this message]
2026-11-20 20:01 ` [PATCH 0/2] media: qcom: camss: Fix the X1E80100 lite CSID paths Gjorgji Rosikopulos (Consultant)
2026-11-20 23:55   ` Jesse Casco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bdc56ab4-bdfc-4fca-90e9-d062492d5bb4@kernel.org \
    --to=bod@kernel.org \
    --cc=allan@fatecpompeia.edu.br \
    --cc=jesse.casco@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=mchehab@kernel.org \
    --cc=nihal.gupta@oss.qualcomm.com \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox