public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: media: qcom,x1e80100-camss: Sort interconnects alphabetically
Date: Tue, 24 Jun 2025 16:29:28 +0300	[thread overview]
Message-ID: <c29385d4-30ea-4774-9cf9-699b08e29800@linaro.org> (raw)
In-Reply-To: <5a5b78f7-e156-4c5e-8407-b249040e227d@kernel.org>

On 6/24/25 15:04, Krzysztof Kozlowski wrote:
> On 24/06/2025 13:38, Vladimir Zapolskiy wrote:
>> On 6/24/25 13:10, Krzysztof Kozlowski wrote:
>>> On 24/06/2025 11:42, Vladimir Zapolskiy wrote:
>>>> Sort the entries of interconnect and interconnect-names lists in the
>>>> alphabetical order of values in the latter property.
>>>
>>> We do not sort these entries alphabetically and you did not explain why
>>> you are doing this.
>>
>> I did it, because I assume that the preference is to sort all named
>> values alphanumerically.
> 
> Where is such preference documented?

There is no such preference documented, as I stated it was my assumption
and it was based on your firm insistance to apply a particular sorting
order for regs, clocks and interrupts properties. Apparently you are
fine with out of the same sort order for 'interconnects' values, the
criteria of picked properties remains unclear for me.

>>
>> Since my assumption is incorrect, I kindly ask to let me know, which
>> properties should have values sorted by alphanumerical order of
>> ${property}-names values and which are not, there should be a method
>> to distinguish such different properties.
> 
> None of them "should" as in "break ABI" or "change something later". I
> don't understand why again we keep discussing such trivialities which

A triviality for you is not a universal triviality, that's why people
ask questions to remove uncertainty, the question asked above has never
been discussed with me, and the answer is not given also.

Regarding "breaking the ABI", it's been discussed earlier that no dt
binding user in the upstream implies no ABI break practically.

I believe this change shall be dropped from the series, it's not
important at all.

-- 
Best wishes,
Vladimir

  reply	other threads:[~2025-06-24 13:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-24  9:42 [PATCH v2 0/2] dt-bindings: media: qcom,x1e80100-camss: two minor changes Vladimir Zapolskiy
2025-06-24  9:42 ` [PATCH v2 1/2] dt-bindings: media: qcom,x1e80100-camss: Sort interconnects alphabetically Vladimir Zapolskiy
2025-06-24 10:10   ` Krzysztof Kozlowski
2025-06-24 11:38     ` Vladimir Zapolskiy
2025-06-24 12:04       ` Krzysztof Kozlowski
2025-06-24 13:29         ` Vladimir Zapolskiy [this message]
2025-06-25  6:58           ` Krzysztof Kozlowski
2025-06-25  7:01             ` Krzysztof Kozlowski
2025-06-25 14:07               ` Vladimir Zapolskiy
2025-06-25 15:56                 ` Bryan O'Donoghue
2025-06-26  9:11                 ` Krzysztof Kozlowski
2025-06-26  9:34                   ` Bryan O'Donoghue
2025-06-24  9:42 ` [PATCH v2 2/2] dt-bindings: media: qcom,x1e80100-camss: Fix isp unit address Vladimir Zapolskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c29385d4-30ea-4774-9cf9-699b08e29800@linaro.org \
    --to=vladimir.zapolskiy@linaro.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=todor.too@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox