Re: [PATCH v3 6/6] media: qcom: iris: vdec: allow GEN2 decoding into 10bit format

[Vikash Garodia <vikash.garodia@oss.qualcomm.com>]

On 5/11/2026 2:50 PM, Neil Armstrong wrote:
> Add the necessary bits into the gen2 platforms tables and handlers
> to allow decoding streams into 10bit pixel formats.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>   .../media/platform/qcom/iris/iris_hfi_gen2_response.c    | 16 +++++++++++++++-
>   drivers/media/platform/qcom/iris/iris_instance.h         |  2 ++
>   drivers/media/platform/qcom/iris/iris_platform_gen2.c    |  8 +++++---
>   drivers/media/platform/qcom/iris/iris_vdec.c             |  8 ++++++++
>   4 files changed, 30 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
> index 0541e02d7507..b6d815c01f1d 100644
> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
> @@ -542,6 +542,15 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
>   	pixmp_ip->width = width;
>   	pixmp_ip->height = height;
>   
> +	if (subsc_params.bit_depth == BIT_DEPTH_8 &&
> +	    pixmp_op->pixelformat != V4L2_PIX_FMT_NV12 &&
> +	    pixmp_op->pixelformat != V4L2_PIX_FMT_QC08C)
> +		pixmp_op->pixelformat = V4L2_PIX_FMT_NV12;
> +	else if (subsc_params.bit_depth == BIT_DEPTH_10 &&
> +		 pixmp_op->pixelformat != V4L2_PIX_FMT_P010 &&
> +		 pixmp_op->pixelformat != V4L2_PIX_FMT_QC10C)
> +		pixmp_op->pixelformat = V4L2_PIX_FMT_P010;
> +
>   	switch (pixmp_op->pixelformat) {
>   	case V4L2_PIX_FMT_P010:
>   		pixmp_op->width = ALIGN(width, 128);
> @@ -625,7 +634,12 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
>   	inst->fw_caps[POC].value = subsc_params.pic_order_cnt;
>   	inst->fw_caps[TIER].value = subsc_params.tier;
>   
> -	if (subsc_params.bit_depth != BIT_DEPTH_8 ||
> +	if (subsc_params.bit_depth == BIT_DEPTH_8)
> +		inst->fw_caps[BIT_DEPTH].value = BIT_DEPTH_8;
> +	else
> +		inst->fw_caps[BIT_DEPTH].value = BIT_DEPTH_10;
> +
> +	if ((subsc_params.bit_depth != BIT_DEPTH_8 && subsc_params.bit_depth != BIT_DEPTH_10) ||
>   	    !(subsc_params.coded_frames & HFI_BITMASK_FRAME_MBS_ONLY_FLAG)) {
>   		dev_err(core->dev, "unsupported content, bit depth: %x, pic_struct = %x\n",
>   			subsc_params.bit_depth, subsc_params.coded_frames);
> diff --git a/drivers/media/platform/qcom/iris/iris_instance.h b/drivers/media/platform/qcom/iris/iris_instance.h
> index 16965150f427..16424d1e94a6 100644
> --- a/drivers/media/platform/qcom/iris/iris_instance.h
> +++ b/drivers/media/platform/qcom/iris/iris_instance.h
> @@ -25,6 +25,8 @@ enum iris_fmt_type_out {
>   enum iris_fmt_type_cap {
>   	IRIS_FMT_NV12,
>   	IRIS_FMT_QC08C,
> +	IRIS_FMT_TP10,
> +	IRIS_FMT_QC10C,
>   };
>   
>   struct iris_fmt {
> diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c
> index 5da90d47f9c6..ceed4b5d96ca 100644
> --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c
> +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c
> @@ -56,9 +56,10 @@ static const struct platform_inst_fw_cap inst_fw_cap_sm8550_dec[] = {
>   	{
>   		.cap_id = PROFILE_HEVC,
>   		.min = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN,
> -		.max = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE,
> +		.max = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10,

what about gen1 platforms ?

>   		.step_or_mask = BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN) |
> -				BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE),
> +				BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE) |
> +				BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10),
>   		.value = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN,
>   		.hfi_id = HFI_PROP_PROFILE,
>   		.flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_MENU,
> @@ -287,7 +288,7 @@ static const struct platform_inst_fw_cap inst_fw_cap_sm8550_dec[] = {
>   	{
>   		.cap_id = BIT_DEPTH,
>   		.min = BIT_DEPTH_8,
> -		.max = BIT_DEPTH_8,
> +		.max = BIT_DEPTH_10,
>   		.step_or_mask = 1,
>   		.value = BIT_DEPTH_8,
>   		.hfi_id = HFI_PROP_LUMA_CHROMA_BIT_DEPTH,
> @@ -866,6 +867,7 @@ static const u32 sm8550_vdec_output_config_params[] = {
>   	HFI_PROP_OPB_ENABLE,
>   	HFI_PROP_COLOR_FORMAT,
>   	HFI_PROP_LINEAR_STRIDE_SCANLINE,
> +	HFI_PROP_UBWC_STRIDE_SCANLINE,
>   };
>   
>   static const u32 sm8550_venc_output_config_params[] = {
> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c
> index f4d9951ed04c..65cf509e4aef 100644
> --- a/drivers/media/platform/qcom/iris/iris_vdec.c
> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c
> @@ -70,6 +70,14 @@ static const struct iris_fmt iris_vdec_formats_cap[] = {
>   		.pixfmt = V4L2_PIX_FMT_QC08C,
>   		.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
>   	},
> +	[IRIS_FMT_TP10] = {
> +		.pixfmt = V4L2_PIX_FMT_P010,
> +		.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
> +	},
> +	[IRIS_FMT_QC10C] = {
> +		.pixfmt = V4L2_PIX_FMT_QC10C,
> +		.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
> +	},
>   };
>   
>   static const struct iris_fmt *
> 

Regards,
Vikash