[PATCH v2] media: platform: amd: isp4: drop stale list reinit before free

[PATCH v2] media: platform: amd: isp4: drop stale list reinit before free

[Bin Du]

Newer Smatch snapshots no longer report the false positive around
isp4if_send_fw_cmd(), so the extra list reinitialization before kfree()
is no longer needed.

Drop the stale list reinit and keep the cleanup path simpler.

Signed-off-by: Bin Du <Bin.Du@amd.com>
---
 drivers/media/platform/amd/isp4/isp4_interface.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/media/platform/amd/isp4/isp4_interface.c b/drivers/media/platform/amd/isp4/isp4_interface.c
index 15f14eddd683..8d73f66bb42c 100644
--- a/drivers/media/platform/amd/isp4/isp4_interface.c
+++ b/drivers/media/platform/amd/isp4/isp4_interface.c
@@ -459,12 +459,6 @@ static int isp4if_send_fw_cmd(struct isp4_interface *ispif, u32 cmd_id,
 		ele = NULL;
 
 free_ele:
-	/*
-	 * The response handler or the timeout/error path must dequeue the
-	 * command element before we own the final reference.
-	 */
-	if (ele)
-		INIT_LIST_HEAD(&ele->list);
 	kfree(ele);
 	return ret;
 }
-- 
2.54.0

Re: [v2] media: platform: amd: isp4: drop stale list reinit before free

[Bin Du]

Hi,

On 5/12/2026 12:55 PM, Patchwork Integration wrote:
> Dear Bin Du:
> 
> Thanks for your patches! Unfortunately the Media CI robot detected some
> issues:
> 
> 
> 
> Please fix your series, and upload a new version. If you have a patchwork
> account, do not forget to mark the current series as Superseded.
> 
> For more details, check the full report at:
> https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/99599428/artifacts/report.htm .
> 
> 

Thanks for the report.

I rechecked the v2 results. The patch-specific checks now pass:
- media-ci/checkpatch
- media-ci/media-patchstyle
- build-basic

The remaining failure appears to be media-ci/static:
https://gitlab.freedesktop.org/linux-media/users/patchwork/-/jobs/99602662

From the log, this looks like a GitLab runner/system failure rather than
an ISP4-specific issue. I do not see an ISP4-specific warning there; the
ISP4 files only appear as normal build/check steps.

If I missed a patch-related warning in that job, please let me know.

> 
> Best regards, and Happy Hacking!
> Media CI robot on behalf of the linux-media community.
> 
> ---
> Check the latest rules for contributing your patches at:
> https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
> 
> If you believe that the CI is wrong, kindly open an issue at
> https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
> to this message.
>