public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Akihiro TSUKADA <tskd08@gmail.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	Antti Palosaari <crope@iki.fi>, Sean Young <sean@mess.org>
Subject: Re: [PATCH] dvb-usb-v2/gl861: fix wrong memcpy
Date: Sat, 17 Aug 2019 22:22:14 +0900	[thread overview]
Message-ID: <df8060a6-9666-3dd1-e041-620891970e7c@gmail.com> (raw)
In-Reply-To: <20190815220811.6ba32749@coco.lan>

> Could you please test the patch and check if the return results are
> now consistent and that it won't break anything?

I have tested the patch and it worked without problems.

Testd-by: Akihiro Tsukada <tskd08@gmail.com>

I could not noticed the bug because
the device was registered without any error messages,
and it seemed to work even with the bug.
(Though actually I was wrong and missed that
 the device does not work after reboot or re-plugging).

After applying this patch, I have confirmed that the device
now works after reboot/re-plugging without any problems.

note:
The patched func: gl861_i2c_read_ex was used in device's early init,
called from d->props->power_ctrl (from dvb_usbv2_init).
But dvb_usbv2_init does not check the return value of it,
and if the device had been initialized previously
it can work even with the interrupted init process in power_ctrl().

--
Akihiro

  reply	other threads:[~2019-08-17 13:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-15 12:57 [PATCH] dvb-usb-v2/gl861: fix wrong memcpy Hans Verkuil
2019-08-16  1:04 ` Akihiro TSUKADA
2019-08-16  1:08   ` Mauro Carvalho Chehab
2019-08-17 13:22     ` Akihiro TSUKADA [this message]
2019-08-21 23:02       ` Antti Palosaari
2019-08-22  2:00         ` Akihiro TSUKADA
2019-08-22  3:54           ` Antti Palosaari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df8060a6-9666-3dd1-e041-620891970e7c@gmail.com \
    --to=tskd08@gmail.com \
    --cc=crope@iki.fi \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sean@mess.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox