From: Akihiro TSUKADA <tskd08@gmail.com>
To: Antti Palosaari <crope@iki.fi>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Sean Young <sean@mess.org>
Subject: Re: [PATCH] dvb-usb-v2/gl861: fix wrong memcpy
Date: Thu, 22 Aug 2019 11:00:51 +0900 [thread overview]
Message-ID: <ea96de1a-0f40-c044-ef2b-63de77da0412@gmail.com> (raw)
In-Reply-To: <fe4da71a-c562-e58e-9b1c-acb6853d9005@iki.fi>
Hi,
> I suspect all whole friio_reset() function is not needed as it has
> worked even I/O has been broken.
It worked because the old driver
(that I rmmod'ed before installing the testing driver)
properly init'ed the device.
If I re-plug it (or reboot), it does not work.
So it is needed.
> Also tuner I2C adapter is implemented wrong (I think I mentioned that
> earlier). As tuner sits behind demod I2C-adapter/gate that whole logic
> should be on demod driver.
But according to USB packet capture logs of the windows version,
it makes eccentric use of USB messages ('bRequest' field),
that (I believe) necessitates the current implementation,
as I mentioned in the past thread.
Regards,
Akihiro
next prev parent reply other threads:[~2019-08-22 2:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 12:57 [PATCH] dvb-usb-v2/gl861: fix wrong memcpy Hans Verkuil
2019-08-16 1:04 ` Akihiro TSUKADA
2019-08-16 1:08 ` Mauro Carvalho Chehab
2019-08-17 13:22 ` Akihiro TSUKADA
2019-08-21 23:02 ` Antti Palosaari
2019-08-22 2:00 ` Akihiro TSUKADA [this message]
2019-08-22 3:54 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea96de1a-0f40-c044-ef2b-63de77da0412@gmail.com \
--to=tskd08@gmail.com \
--cc=crope@iki.fi \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox