* [PATCH v2 0/3] media: iris: add LTR and hierarchical coding support for ar50lt
@ 2026-07-21 1:36 Vishnu Reddy
2026-07-21 1:36 ` [PATCH v2 1/3] media: iris: add Long-Term Reference control support for ar50lt encoder Vishnu Reddy
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Vishnu Reddy @ 2026-07-21 1:36 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel, Vishnu Reddy,
Gourav Kumar
This series adds support for Long-Term Reference (LTR), hierarchical
coding and request key frame controls for the AR50LT encoder by enabling
the required firmware capabilities in the iris driver.
Signed-off-by: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
---
Changes in v2:
- Added request key frame support
- Link to v1: https://patch.msgid.link/20260710-shikra_ltr_support-v1-0-458b587268ea@oss.qualcomm.com
To: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
To: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
To: Abhinav Kumar <abhinav.kumar@linux.dev>
To: Bryan O'Donoghue <bod@kernel.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
Gourav Kumar (2):
media: iris: add Long-Term Reference control support for ar50lt encoder
media: iris: add hierarchical coding support for ar50lt encoder
Vishnu Reddy (1):
media: qcom: iris: add request key frame support for ar50lt encoder
drivers/media/platform/qcom/iris/iris_hfi_gen2.c | 222 +++++++++++++++++++++++
1 file changed, 222 insertions(+)
---
base-commit: 34cf6dafc47441dfb6b356a095b89c3585a93714
change-id: 20260710-shikra_ltr_support-27bd9a496950
prerequisite-message-id: <20260709-iris-ar50lt-v7-0-76af9dd4d1f6@oss.qualcomm.com>
prerequisite-patch-id: 8b5a1be5778fb4c7feb069452ecb60e8b8dfc3f8
prerequisite-patch-id: e669517302297a7b315c9aa4f4189e4928091e0c
prerequisite-patch-id: 922bc325dbd9a499a3a209d2f8dbbce6a4166e60
prerequisite-patch-id: a5a49cda4e21d835558fa84f2f6bd25b8f7e72b4
prerequisite-patch-id: e62e8285bcbddade64c026379f23a8c5ae70fe52
prerequisite-patch-id: cac29b25348e2e791638a0286283109f2546f9a7
prerequisite-patch-id: 4dfaff2f9644d7a168b1b35fe947660b8f464af6
prerequisite-patch-id: a26fa49eefecf2b5ba6cf964be9327eb5ba5929a
prerequisite-patch-id: d97c79463fe1487fa7bc9eebd4cfb4610713f44a
prerequisite-patch-id: 76eafea8230160a3b5e6503c68a5c9c3c2d1497e
prerequisite-patch-id: ea9cd9a8e6561321cd9cf338a76da1382ff47e13
prerequisite-patch-id: 26e9083b709cc8f2f1184edf6b39fb89f365a9f1
prerequisite-patch-id: ce4576bd3d20880939a97a1cda9bb8678808ea65
prerequisite-patch-id: 8c94bec467b385c373bd98eb9ee5a5805fc4e6a6
prerequisite-patch-id: 6e258cd475b77927d6476704cbf91bf48a63aa0d
prerequisite-patch-id: 54c8855d0721ba8667d095e6ad6556c2021f89e9
prerequisite-patch-id: f5479d2ca6b850c0c750944a8e0b05a7df2cc5a8
prerequisite-patch-id: 96dfec1c2df69f748c1a4bd741628e946cb7bec1
prerequisite-message-id: <a2c02dce-b097-4f52-80d4-d63006ebd8c5@kernel.org>
prerequisite-patch-id: aae7aad665adb93ab0106c28420e34587ee82aba
prerequisite-patch-id: a2b7908b27a6308f9919c986f8bde5b902e5d6da
Best regards,
--
Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 1/3] media: iris: add Long-Term Reference control support for ar50lt encoder
2026-07-21 1:36 [PATCH v2 0/3] media: iris: add LTR and hierarchical coding support for ar50lt Vishnu Reddy
@ 2026-07-21 1:36 ` Vishnu Reddy
2026-07-21 15:41 ` Vikash Garodia
2026-07-21 1:36 ` [PATCH v2 2/3] media: iris: add hierarchical coding " Vishnu Reddy
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Vishnu Reddy @ 2026-07-21 1:36 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel, Vishnu Reddy,
Gourav Kumar
From: Gourav Kumar <gouravk@qti.qualcomm.com>
Add Long-Term Reference(LTR) frame support for ar50lt gen2 encoder by
enabling the following V4L2 controls:
V4L2_CID_MPEG_VIDEO_LTR_COUNT
V4L2_CID_MPEG_VIDEO_USE_LTR_FRAMES
V4L2_CID_MPEG_VIDEO_FRAME_LTR_INDEX
The ar50lt gen2 firmware supports the corresponding LTR HFI properties.
Signed-off-by: Gourav Kumar <gouravk@qti.qualcomm.com>
Signed-off-by: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
---
drivers/media/platform/qcom/iris/iris_hfi_gen2.c | 30 ++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2.c
index f2903af24cb1..3be77feed84c 100644
--- a/drivers/media/platform/qcom/iris/iris_hfi_gen2.c
+++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2.c
@@ -1679,6 +1679,36 @@ static const struct platform_inst_fw_cap inst_fw_cap_gen2_ar50lt_enc[] = {
CAP_FLAG_DYNAMIC_ALLOWED,
.set = iris_set_ir_period_gen2,
},
+ {
+ .cap_id = LTR_COUNT,
+ .min = 0,
+ .max = MAX_LTR_FRAME_COUNT_GEN2,
+ .step_or_mask = 1,
+ .value = 0,
+ .hfi_id = HFI_PROP_LTR_COUNT,
+ .flags = CAP_FLAG_OUTPUT_PORT,
+ .set = iris_set_ltr_count_gen2,
+ },
+ {
+ .cap_id = USE_LTR,
+ .min = 0,
+ .max = ((1 << MAX_LTR_FRAME_COUNT_GEN2) - 1),
+ .step_or_mask = 0,
+ .value = 0,
+ .hfi_id = HFI_PROP_LTR_USE,
+ .flags = CAP_FLAG_INPUT_PORT | CAP_FLAG_DYNAMIC_ALLOWED,
+ .set = iris_set_use_and_mark_ltr,
+ },
+ {
+ .cap_id = MARK_LTR,
+ .min = INVALID_DEFAULT_MARK_OR_USE_LTR,
+ .max = (MAX_LTR_FRAME_COUNT_GEN2 - 1),
+ .step_or_mask = 1,
+ .value = INVALID_DEFAULT_MARK_OR_USE_LTR,
+ .hfi_id = HFI_PROP_LTR_MARK,
+ .flags = CAP_FLAG_INPUT_PORT | CAP_FLAG_DYNAMIC_ALLOWED,
+ .set = iris_set_use_and_mark_ltr,
+ },
};
static const u32 iris_hfi_gen2_ar50lt_dec_ip_int_buf_tbl[] = {
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 2/3] media: iris: add hierarchical coding support for ar50lt encoder
2026-07-21 1:36 [PATCH v2 0/3] media: iris: add LTR and hierarchical coding support for ar50lt Vishnu Reddy
2026-07-21 1:36 ` [PATCH v2 1/3] media: iris: add Long-Term Reference control support for ar50lt encoder Vishnu Reddy
@ 2026-07-21 1:36 ` Vishnu Reddy
2026-07-21 15:47 ` Vikash Garodia
2026-07-21 1:36 ` [PATCH v2 3/3] media: qcom: iris: add request key frame " Vishnu Reddy
2026-07-21 21:15 ` [PATCH v2 0/3] media: iris: add LTR and hierarchical coding support for ar50lt Dmitry Baryshkov
3 siblings, 1 reply; 10+ messages in thread
From: Vishnu Reddy @ 2026-07-21 1:36 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel, Vishnu Reddy,
Gourav Kumar
From: Gourav Kumar <gouravk@qti.qualcomm.com>
Add LAYER_ENABLE, LAYER_TYPE_H264/HEVC, LAYER_COUNT_H264/HEVC and
per-layer bitrate fw_caps entries to inst_fw_cap_gen2_ar50lt_enc,
enabling V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING and related
hierarchical/layered encoding controls for ar50lt platforms.
Signed-off-by: Gourav Kumar <gouravk@qti.qualcomm.com>
Signed-off-by: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
---
drivers/media/platform/qcom/iris/iris_hfi_gen2.c | 182 +++++++++++++++++++++++
1 file changed, 182 insertions(+)
diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2.c
index 3be77feed84c..3f82c4b7c6f3 100644
--- a/drivers/media/platform/qcom/iris/iris_hfi_gen2.c
+++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2.c
@@ -1709,6 +1709,188 @@ static const struct platform_inst_fw_cap inst_fw_cap_gen2_ar50lt_enc[] = {
.flags = CAP_FLAG_INPUT_PORT | CAP_FLAG_DYNAMIC_ALLOWED,
.set = iris_set_use_and_mark_ltr,
},
+ {
+ .cap_id = LAYER_ENABLE,
+ .min = 0,
+ .max = 1,
+ .step_or_mask = 1,
+ .value = 0,
+ .flags = CAP_FLAG_OUTPUT_PORT,
+ },
+ {
+ .cap_id = LAYER_TYPE_H264,
+ .min = V4L2_MPEG_VIDEO_H264_HIERARCHICAL_CODING_B,
+ .max = V4L2_MPEG_VIDEO_H264_HIERARCHICAL_CODING_P,
+ .step_or_mask = BIT(V4L2_MPEG_VIDEO_H264_HIERARCHICAL_CODING_B) |
+ BIT(V4L2_MPEG_VIDEO_H264_HIERARCHICAL_CODING_P),
+ .value = V4L2_MPEG_VIDEO_H264_HIERARCHICAL_CODING_P,
+ .hfi_id = HFI_PROP_LAYER_ENCODING_TYPE,
+ .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_MENU,
+ .set = iris_set_layer_type,
+ },
+ {
+ .cap_id = LAYER_TYPE_HEVC,
+ .min = V4L2_MPEG_VIDEO_HEVC_HIERARCHICAL_CODING_B,
+ .max = V4L2_MPEG_VIDEO_HEVC_HIERARCHICAL_CODING_P,
+ .step_or_mask = BIT(V4L2_MPEG_VIDEO_HEVC_HIERARCHICAL_CODING_B) |
+ BIT(V4L2_MPEG_VIDEO_HEVC_HIERARCHICAL_CODING_P),
+ .value = V4L2_MPEG_VIDEO_HEVC_HIERARCHICAL_CODING_P,
+ .hfi_id = HFI_PROP_LAYER_ENCODING_TYPE,
+ .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_MENU,
+ .set = iris_set_layer_type,
+ },
+ {
+ .cap_id = LAYER_COUNT_H264,
+ .min = 0,
+ .max = 5,
+ .step_or_mask = 1,
+ .value = 0,
+ .hfi_id = HFI_PROP_LAYER_COUNT,
+ .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_DYNAMIC_ALLOWED,
+ .set = iris_set_layer_count_gen2,
+ },
+ {
+ .cap_id = LAYER_COUNT_HEVC,
+ .min = 0,
+ .max = 5,
+ .step_or_mask = 1,
+ .value = 0,
+ .hfi_id = HFI_PROP_LAYER_COUNT,
+ .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_DYNAMIC_ALLOWED,
+ .set = iris_set_layer_count_gen2,
+ },
+ {
+ .cap_id = LAYER0_BITRATE_H264,
+ .min = 1,
+ .max = BITRATE_MAX_AR50LT,
+ .step_or_mask = 1,
+ .value = BITRATE_DEFAULT_AR50LT,
+ .hfi_id = HFI_PROP_BITRATE_LAYER1,
+ .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_INPUT_PORT |
+ CAP_FLAG_DYNAMIC_ALLOWED,
+ .set = iris_set_layer_bitrate,
+ },
+ {
+ .cap_id = LAYER1_BITRATE_H264,
+ .min = 1,
+ .max = BITRATE_MAX_AR50LT,
+ .step_or_mask = 1,
+ .value = BITRATE_DEFAULT_AR50LT,
+ .hfi_id = HFI_PROP_BITRATE_LAYER2,
+ .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_INPUT_PORT |
+ CAP_FLAG_DYNAMIC_ALLOWED,
+ .set = iris_set_layer_bitrate,
+ },
+ {
+ .cap_id = LAYER2_BITRATE_H264,
+ .min = 1,
+ .max = BITRATE_MAX_AR50LT,
+ .step_or_mask = 1,
+ .value = BITRATE_DEFAULT_AR50LT,
+ .hfi_id = HFI_PROP_BITRATE_LAYER3,
+ .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_INPUT_PORT |
+ CAP_FLAG_DYNAMIC_ALLOWED,
+ .set = iris_set_layer_bitrate,
+ },
+ {
+ .cap_id = LAYER3_BITRATE_H264,
+ .min = 1,
+ .max = BITRATE_MAX_AR50LT,
+ .step_or_mask = 1,
+ .value = BITRATE_DEFAULT_AR50LT,
+ .hfi_id = HFI_PROP_BITRATE_LAYER4,
+ .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_INPUT_PORT |
+ CAP_FLAG_DYNAMIC_ALLOWED,
+ .set = iris_set_layer_bitrate,
+ },
+ {
+ .cap_id = LAYER4_BITRATE_H264,
+ .min = 1,
+ .max = BITRATE_MAX_AR50LT,
+ .step_or_mask = 1,
+ .value = BITRATE_DEFAULT_AR50LT,
+ .hfi_id = HFI_PROP_BITRATE_LAYER5,
+ .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_INPUT_PORT |
+ CAP_FLAG_DYNAMIC_ALLOWED,
+ .set = iris_set_layer_bitrate,
+ },
+ {
+ .cap_id = LAYER5_BITRATE_H264,
+ .min = 1,
+ .max = BITRATE_MAX_AR50LT,
+ .step_or_mask = 1,
+ .value = BITRATE_DEFAULT_AR50LT,
+ .hfi_id = HFI_PROP_BITRATE_LAYER6,
+ .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_INPUT_PORT |
+ CAP_FLAG_DYNAMIC_ALLOWED,
+ .set = iris_set_layer_bitrate,
+ },
+ {
+ .cap_id = LAYER0_BITRATE_HEVC,
+ .min = 1,
+ .max = BITRATE_MAX_AR50LT,
+ .step_or_mask = 1,
+ .value = BITRATE_DEFAULT_AR50LT,
+ .hfi_id = HFI_PROP_BITRATE_LAYER1,
+ .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_INPUT_PORT |
+ CAP_FLAG_DYNAMIC_ALLOWED,
+ .set = iris_set_layer_bitrate,
+ },
+ {
+ .cap_id = LAYER1_BITRATE_HEVC,
+ .min = 1,
+ .max = BITRATE_MAX_AR50LT,
+ .step_or_mask = 1,
+ .value = BITRATE_DEFAULT_AR50LT,
+ .hfi_id = HFI_PROP_BITRATE_LAYER2,
+ .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_INPUT_PORT |
+ CAP_FLAG_DYNAMIC_ALLOWED,
+ .set = iris_set_layer_bitrate,
+ },
+ {
+ .cap_id = LAYER2_BITRATE_HEVC,
+ .min = 1,
+ .max = BITRATE_MAX_AR50LT,
+ .step_or_mask = 1,
+ .value = BITRATE_DEFAULT_AR50LT,
+ .hfi_id = HFI_PROP_BITRATE_LAYER3,
+ .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_INPUT_PORT |
+ CAP_FLAG_DYNAMIC_ALLOWED,
+ .set = iris_set_layer_bitrate,
+ },
+ {
+ .cap_id = LAYER3_BITRATE_HEVC,
+ .min = 1,
+ .max = BITRATE_MAX_AR50LT,
+ .step_or_mask = 1,
+ .value = BITRATE_DEFAULT_AR50LT,
+ .hfi_id = HFI_PROP_BITRATE_LAYER4,
+ .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_INPUT_PORT |
+ CAP_FLAG_DYNAMIC_ALLOWED,
+ .set = iris_set_layer_bitrate,
+ },
+ {
+ .cap_id = LAYER4_BITRATE_HEVC,
+ .min = 1,
+ .max = BITRATE_MAX_AR50LT,
+ .step_or_mask = 1,
+ .value = BITRATE_DEFAULT_AR50LT,
+ .hfi_id = HFI_PROP_BITRATE_LAYER5,
+ .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_INPUT_PORT |
+ CAP_FLAG_DYNAMIC_ALLOWED,
+ .set = iris_set_layer_bitrate,
+ },
+ {
+ .cap_id = LAYER5_BITRATE_HEVC,
+ .min = 1,
+ .max = BITRATE_MAX_AR50LT,
+ .step_or_mask = 1,
+ .value = BITRATE_DEFAULT_AR50LT,
+ .hfi_id = HFI_PROP_BITRATE_LAYER6,
+ .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_INPUT_PORT |
+ CAP_FLAG_DYNAMIC_ALLOWED,
+ .set = iris_set_layer_bitrate,
+ },
};
static const u32 iris_hfi_gen2_ar50lt_dec_ip_int_buf_tbl[] = {
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 3/3] media: qcom: iris: add request key frame support for ar50lt encoder
2026-07-21 1:36 [PATCH v2 0/3] media: iris: add LTR and hierarchical coding support for ar50lt Vishnu Reddy
2026-07-21 1:36 ` [PATCH v2 1/3] media: iris: add Long-Term Reference control support for ar50lt encoder Vishnu Reddy
2026-07-21 1:36 ` [PATCH v2 2/3] media: iris: add hierarchical coding " Vishnu Reddy
@ 2026-07-21 1:36 ` Vishnu Reddy
2026-07-21 15:47 ` Vikash Garodia
2026-07-21 21:15 ` [PATCH v2 0/3] media: iris: add LTR and hierarchical coding support for ar50lt Dmitry Baryshkov
3 siblings, 1 reply; 10+ messages in thread
From: Vishnu Reddy @ 2026-07-21 1:36 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel, Vishnu Reddy
Enable V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME support for the ar50lt gen2
encoder.
Signed-off-by: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
---
drivers/media/platform/qcom/iris/iris_hfi_gen2.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2.c
index 3f82c4b7c6f3..39ad3fe2876d 100644
--- a/drivers/media/platform/qcom/iris/iris_hfi_gen2.c
+++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2.c
@@ -1891,6 +1891,16 @@ static const struct platform_inst_fw_cap inst_fw_cap_gen2_ar50lt_enc[] = {
CAP_FLAG_DYNAMIC_ALLOWED,
.set = iris_set_layer_bitrate,
},
+ {
+ .cap_id = REQUEST_SYNC_FRAME,
+ .min = 0,
+ .max = 1,
+ .step_or_mask = 1,
+ .value = 0,
+ .hfi_id = HFI_PROP_REQUEST_SYNC_FRAME,
+ .flags = CAP_FLAG_INPUT_PORT | CAP_FLAG_DYNAMIC_ALLOWED,
+ .set = iris_set_req_sync_frame,
+ },
};
static const u32 iris_hfi_gen2_ar50lt_dec_ip_int_buf_tbl[] = {
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/3] media: iris: add Long-Term Reference control support for ar50lt encoder
2026-07-21 1:36 ` [PATCH v2 1/3] media: iris: add Long-Term Reference control support for ar50lt encoder Vishnu Reddy
@ 2026-07-21 15:41 ` Vikash Garodia
0 siblings, 0 replies; 10+ messages in thread
From: Vikash Garodia @ 2026-07-21 15:41 UTC (permalink / raw)
To: Vishnu Reddy, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel, Gourav Kumar
On 7/21/2026 7:06 AM, Vishnu Reddy wrote:
> From: Gourav Kumar<gouravk@qti.qualcomm.com>
>
> Add Long-Term Reference(LTR) frame support for ar50lt gen2 encoder by
> enabling the following V4L2 controls:
> V4L2_CID_MPEG_VIDEO_LTR_COUNT
> V4L2_CID_MPEG_VIDEO_USE_LTR_FRAMES
> V4L2_CID_MPEG_VIDEO_FRAME_LTR_INDEX
> The ar50lt gen2 firmware supports the corresponding LTR HFI properties.
>
> Signed-off-by: Gourav Kumar<gouravk@qti.qualcomm.com>
> Signed-off-by: Vishnu Reddy<busanna.reddy@oss.qualcomm.com>
> ---
> drivers/media/platform/qcom/iris/iris_hfi_gen2.c | 30 ++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
Reviewed-by: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 2/3] media: iris: add hierarchical coding support for ar50lt encoder
2026-07-21 1:36 ` [PATCH v2 2/3] media: iris: add hierarchical coding " Vishnu Reddy
@ 2026-07-21 15:47 ` Vikash Garodia
0 siblings, 0 replies; 10+ messages in thread
From: Vikash Garodia @ 2026-07-21 15:47 UTC (permalink / raw)
To: Vishnu Reddy, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel, Gourav Kumar
On 7/21/2026 7:06 AM, Vishnu Reddy wrote:
> From: Gourav Kumar<gouravk@qti.qualcomm.com>
>
> Add LAYER_ENABLE, LAYER_TYPE_H264/HEVC, LAYER_COUNT_H264/HEVC and
> per-layer bitrate fw_caps entries to inst_fw_cap_gen2_ar50lt_enc,
> enabling V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING and related
> hierarchical/layered encoding controls for ar50lt platforms.
>
> Signed-off-by: Gourav Kumar<gouravk@qti.qualcomm.com>
> Signed-off-by: Vishnu Reddy<busanna.reddy@oss.qualcomm.com>
> ---
> drivers/media/platform/qcom/iris/iris_hfi_gen2.c | 182 +++++++++++++++++++++++
> 1 file changed, 182 insertions(+)
Reviewed-by: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 3/3] media: qcom: iris: add request key frame support for ar50lt encoder
2026-07-21 1:36 ` [PATCH v2 3/3] media: qcom: iris: add request key frame " Vishnu Reddy
@ 2026-07-21 15:47 ` Vikash Garodia
0 siblings, 0 replies; 10+ messages in thread
From: Vikash Garodia @ 2026-07-21 15:47 UTC (permalink / raw)
To: Vishnu Reddy, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 7/21/2026 7:06 AM, Vishnu Reddy wrote:
> Enable V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME support for the ar50lt gen2
> encoder.
>
> Signed-off-by: Vishnu Reddy<busanna.reddy@oss.qualcomm.com>
> ---
> drivers/media/platform/qcom/iris/iris_hfi_gen2.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Reviewed-by: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 0/3] media: iris: add LTR and hierarchical coding support for ar50lt
2026-07-21 1:36 [PATCH v2 0/3] media: iris: add LTR and hierarchical coding support for ar50lt Vishnu Reddy
` (2 preceding siblings ...)
2026-07-21 1:36 ` [PATCH v2 3/3] media: qcom: iris: add request key frame " Vishnu Reddy
@ 2026-07-21 21:15 ` Dmitry Baryshkov
2026-07-22 12:24 ` Vishnu Reddy
3 siblings, 1 reply; 10+ messages in thread
From: Dmitry Baryshkov @ 2026-07-21 21:15 UTC (permalink / raw)
To: Vishnu Reddy
Cc: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, linux-media,
linux-arm-msm, linux-kernel, Gourav Kumar
On Tue, Jul 21, 2026 at 07:06:22AM +0530, Vishnu Reddy wrote:
> This series adds support for Long-Term Reference (LTR), hierarchical
> coding and request key frame controls for the AR50LT encoder by enabling
> the required firmware capabilities in the iris driver.
>
> Signed-off-by: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
> ---
> Changes in v2:
> - Added request key frame support
> - Link to v1: https://patch.msgid.link/20260710-shikra_ltr_support-v1-0-458b587268ea@oss.qualcomm.com
This should be coming as a review feedback rather than a separate
series. I'll incorporate those changes into the AR50LT series (together
with the similar changes to Gen1 firmware).
>
> To: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
> To: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
> To: Abhinav Kumar <abhinav.kumar@linux.dev>
> To: Bryan O'Donoghue <bod@kernel.org>
> To: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: linux-media@vger.kernel.org
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
>
> ---
> Gourav Kumar (2):
> media: iris: add Long-Term Reference control support for ar50lt encoder
> media: iris: add hierarchical coding support for ar50lt encoder
>
> Vishnu Reddy (1):
> media: qcom: iris: add request key frame support for ar50lt encoder
>
> drivers/media/platform/qcom/iris/iris_hfi_gen2.c | 222 +++++++++++++++++++++++
> 1 file changed, 222 insertions(+)
> ---
> base-commit: 34cf6dafc47441dfb6b356a095b89c3585a93714
> change-id: 20260710-shikra_ltr_support-27bd9a496950
> prerequisite-message-id: <20260709-iris-ar50lt-v7-0-76af9dd4d1f6@oss.qualcomm.com>
> prerequisite-patch-id: 8b5a1be5778fb4c7feb069452ecb60e8b8dfc3f8
> prerequisite-patch-id: e669517302297a7b315c9aa4f4189e4928091e0c
> prerequisite-patch-id: 922bc325dbd9a499a3a209d2f8dbbce6a4166e60
> prerequisite-patch-id: a5a49cda4e21d835558fa84f2f6bd25b8f7e72b4
> prerequisite-patch-id: e62e8285bcbddade64c026379f23a8c5ae70fe52
> prerequisite-patch-id: cac29b25348e2e791638a0286283109f2546f9a7
> prerequisite-patch-id: 4dfaff2f9644d7a168b1b35fe947660b8f464af6
> prerequisite-patch-id: a26fa49eefecf2b5ba6cf964be9327eb5ba5929a
> prerequisite-patch-id: d97c79463fe1487fa7bc9eebd4cfb4610713f44a
> prerequisite-patch-id: 76eafea8230160a3b5e6503c68a5c9c3c2d1497e
> prerequisite-patch-id: ea9cd9a8e6561321cd9cf338a76da1382ff47e13
> prerequisite-patch-id: 26e9083b709cc8f2f1184edf6b39fb89f365a9f1
> prerequisite-patch-id: ce4576bd3d20880939a97a1cda9bb8678808ea65
> prerequisite-patch-id: 8c94bec467b385c373bd98eb9ee5a5805fc4e6a6
> prerequisite-patch-id: 6e258cd475b77927d6476704cbf91bf48a63aa0d
> prerequisite-patch-id: 54c8855d0721ba8667d095e6ad6556c2021f89e9
> prerequisite-patch-id: f5479d2ca6b850c0c750944a8e0b05a7df2cc5a8
> prerequisite-patch-id: 96dfec1c2df69f748c1a4bd741628e946cb7bec1
> prerequisite-message-id: <a2c02dce-b097-4f52-80d4-d63006ebd8c5@kernel.org>
> prerequisite-patch-id: aae7aad665adb93ab0106c28420e34587ee82aba
> prerequisite-patch-id: a2b7908b27a6308f9919c986f8bde5b902e5d6da
>
> Best regards,
> --
> Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 0/3] media: iris: add LTR and hierarchical coding support for ar50lt
2026-07-21 21:15 ` [PATCH v2 0/3] media: iris: add LTR and hierarchical coding support for ar50lt Dmitry Baryshkov
@ 2026-07-22 12:24 ` Vishnu Reddy
2026-07-22 12:32 ` Dmitry Baryshkov
0 siblings, 1 reply; 10+ messages in thread
From: Vishnu Reddy @ 2026-07-22 12:24 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, linux-media,
linux-arm-msm, linux-kernel, Gourav Kumar
On 7/22/2026 2:45 AM, Dmitry Baryshkov wrote:
> On Tue, Jul 21, 2026 at 07:06:22AM +0530, Vishnu Reddy wrote:
>> This series adds support for Long-Term Reference (LTR), hierarchical
>> coding and request key frame controls for the AR50LT encoder by enabling
>> the required firmware capabilities in the iris driver.
>>
>> Signed-off-by: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
>> ---
>> Changes in v2:
>> - Added request key frame support
>> - Link to v1: https://patch.msgid.link/20260710-shikra_ltr_support-v1-0-458b587268ea@oss.qualcomm.com
> This should be coming as a review feedback rather than a separate
> series. I'll incorporate those changes into the AR50LT series (together
> with the similar changes to Gen1 firmware).
That works for me as well.
Regards,
Vishnu Reddy.
>> To: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
>> To: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
>> To: Abhinav Kumar <abhinav.kumar@linux.dev>
>> To: Bryan O'Donoghue <bod@kernel.org>
>> To: Mauro Carvalho Chehab <mchehab@kernel.org>
>> Cc: linux-media@vger.kernel.org
>> Cc: linux-arm-msm@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>>
>> ---
>> Gourav Kumar (2):
>> media: iris: add Long-Term Reference control support for ar50lt encoder
>> media: iris: add hierarchical coding support for ar50lt encoder
>>
>> Vishnu Reddy (1):
>> media: qcom: iris: add request key frame support for ar50lt encoder
>>
>> drivers/media/platform/qcom/iris/iris_hfi_gen2.c | 222 +++++++++++++++++++++++
>> 1 file changed, 222 insertions(+)
>> ---
>> base-commit: 34cf6dafc47441dfb6b356a095b89c3585a93714
>> change-id: 20260710-shikra_ltr_support-27bd9a496950
>> prerequisite-message-id: <20260709-iris-ar50lt-v7-0-76af9dd4d1f6@oss.qualcomm.com>
>> prerequisite-patch-id: 8b5a1be5778fb4c7feb069452ecb60e8b8dfc3f8
>> prerequisite-patch-id: e669517302297a7b315c9aa4f4189e4928091e0c
>> prerequisite-patch-id: 922bc325dbd9a499a3a209d2f8dbbce6a4166e60
>> prerequisite-patch-id: a5a49cda4e21d835558fa84f2f6bd25b8f7e72b4
>> prerequisite-patch-id: e62e8285bcbddade64c026379f23a8c5ae70fe52
>> prerequisite-patch-id: cac29b25348e2e791638a0286283109f2546f9a7
>> prerequisite-patch-id: 4dfaff2f9644d7a168b1b35fe947660b8f464af6
>> prerequisite-patch-id: a26fa49eefecf2b5ba6cf964be9327eb5ba5929a
>> prerequisite-patch-id: d97c79463fe1487fa7bc9eebd4cfb4610713f44a
>> prerequisite-patch-id: 76eafea8230160a3b5e6503c68a5c9c3c2d1497e
>> prerequisite-patch-id: ea9cd9a8e6561321cd9cf338a76da1382ff47e13
>> prerequisite-patch-id: 26e9083b709cc8f2f1184edf6b39fb89f365a9f1
>> prerequisite-patch-id: ce4576bd3d20880939a97a1cda9bb8678808ea65
>> prerequisite-patch-id: 8c94bec467b385c373bd98eb9ee5a5805fc4e6a6
>> prerequisite-patch-id: 6e258cd475b77927d6476704cbf91bf48a63aa0d
>> prerequisite-patch-id: 54c8855d0721ba8667d095e6ad6556c2021f89e9
>> prerequisite-patch-id: f5479d2ca6b850c0c750944a8e0b05a7df2cc5a8
>> prerequisite-patch-id: 96dfec1c2df69f748c1a4bd741628e946cb7bec1
>> prerequisite-message-id: <a2c02dce-b097-4f52-80d4-d63006ebd8c5@kernel.org>
>> prerequisite-patch-id: aae7aad665adb93ab0106c28420e34587ee82aba
>> prerequisite-patch-id: a2b7908b27a6308f9919c986f8bde5b902e5d6da
>>
>> Best regards,
>> --
>> Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
>>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 0/3] media: iris: add LTR and hierarchical coding support for ar50lt
2026-07-22 12:24 ` Vishnu Reddy
@ 2026-07-22 12:32 ` Dmitry Baryshkov
0 siblings, 0 replies; 10+ messages in thread
From: Dmitry Baryshkov @ 2026-07-22 12:32 UTC (permalink / raw)
To: Vishnu Reddy
Cc: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, linux-media,
linux-arm-msm, linux-kernel, Gourav Kumar
On Wed, Jul 22, 2026 at 05:54:03PM +0530, Vishnu Reddy wrote:
>
> On 7/22/2026 2:45 AM, Dmitry Baryshkov wrote:
> > On Tue, Jul 21, 2026 at 07:06:22AM +0530, Vishnu Reddy wrote:
> >> This series adds support for Long-Term Reference (LTR), hierarchical
> >> coding and request key frame controls for the AR50LT encoder by enabling
> >> the required firmware capabilities in the iris driver.
> >>
> >> Signed-off-by: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
> >> ---
> >> Changes in v2:
> >> - Added request key frame support
> >> - Link to v1: https://patch.msgid.link/20260710-shikra_ltr_support-v1-0-458b587268ea@oss.qualcomm.com
> > This should be coming as a review feedback rather than a separate
> > series. I'll incorporate those changes into the AR50LT series (together
> > with the similar changes to Gen1 firmware).
>
> That works for me as well.
The third patch will still need to be submitted, corresponding defines
are not yet merged.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2026-07-22 12:32 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-21 1:36 [PATCH v2 0/3] media: iris: add LTR and hierarchical coding support for ar50lt Vishnu Reddy
2026-07-21 1:36 ` [PATCH v2 1/3] media: iris: add Long-Term Reference control support for ar50lt encoder Vishnu Reddy
2026-07-21 15:41 ` Vikash Garodia
2026-07-21 1:36 ` [PATCH v2 2/3] media: iris: add hierarchical coding " Vishnu Reddy
2026-07-21 15:47 ` Vikash Garodia
2026-07-21 1:36 ` [PATCH v2 3/3] media: qcom: iris: add request key frame " Vishnu Reddy
2026-07-21 15:47 ` Vikash Garodia
2026-07-21 21:15 ` [PATCH v2 0/3] media: iris: add LTR and hierarchical coding support for ar50lt Dmitry Baryshkov
2026-07-22 12:24 ` Vishnu Reddy
2026-07-22 12:32 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox