[PATCH 0/1] v4lconvert: Add "PEGATRON CORPORATION" to asus_board_vendor

[PATCH 0/1] v4lconvert: Add "PEGATRON CORPORATION" to asus_board_vendor

[Hans de Goede]

Hi Gregor,

Here is a patch to add "PEGATRON CORPORATION" to asus_board_vendor,
to fix an upside down bug reported to Fedora:

https://bugzilla.redhat.com/show_bug.cgi?id=1311545

I'm not 100% sure this is a good idea, it might cause a bunch of false
positives, but looking at the existing static PEGATRON entries in the
v4l_control_flags list, it seems that it really is just another vendor
string for Asus and that adding it to asus_board_vendor is best, so
I'm say 95% sure :)

Anyways your input on this is much appreciated. In the mean time I'll
kick of a scratch-build of the Fedora v4l-utils pkg with this patch
applied for the reporter to test.

Regards,

Hans

[PATCH] v4lconvert: Add "PEGATRON CORPORATION" to asus_board_vendor

[Hans de Goede]

Some Asus laptops actually have "PEGATRON CORPORATION" in board_vendor,
add this to the list of strings used to recognize Asus as vendor.

This also allows us to remove a bunch of PEGATRON entries from the static
v4lcontrol_flags table.

Note that 2 PEGATRON entries remain in the static v4lcontrol_flags table,
one for a "H54" board_name entry since "H54" is not in the asus_board_name
array, and one "PEGATRON CORP." board which does not have a usable
board_name at all.

BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1311545
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 lib/libv4lconvert/control/libv4lcontrol.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/lib/libv4lconvert/control/libv4lcontrol.c b/lib/libv4lconvert/control/libv4lcontrol.c
index e1832a9..0c45a26 100644
--- a/lib/libv4lconvert/control/libv4lcontrol.c
+++ b/lib/libv4lconvert/control/libv4lcontrol.c
@@ -75,9 +75,6 @@ static const struct v4lcontrol_flags_info v4lcontrol_flags[] = {
 	/* A re-branded ASUS notebook */
 	{ 0x04f2, 0xb012, 0, "Founder PC", "T14MF",
 		V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
-	/* Note no whitespace padding for board vendor, this is not a typo */
-	{ 0x04f2, 0xb012, 0, "PEGATRON CORPORATION", "X71TL     ",
-		V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
 	/* These 3 PACKARD BELL's seem to be Asus notebook in disguise */
 	{ 0x04f2, 0xb012, 0, "Packard Bell BV", "T32A      ",
 		V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
@@ -152,10 +149,6 @@ static const struct v4lcontrol_flags_info v4lcontrol_flags[] = {
 	{ 0x064e, 0xa111, 0, "Acer, Inc.", "Prespa1         ", 
 		V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED, 0,
 		"Acer, inc.", "Aspire 5570     " },
-	{ 0x064e, 0xa111, 0, "PEGATRON CORPORATION         ", "F5C     ",
-		V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
-	{ 0x064e, 0xa111, 0, "PEGATRON CORPORATION         ", "F5SR    ",
-		V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
 	/* 2 reports:
 	   Unknown laptop model -> System Vendor: "  IDEALMAX"
 	   Síragon SL-6120      -> System Vendor: "PEGA PC"
@@ -165,8 +158,6 @@ static const struct v4lcontrol_flags_info v4lcontrol_flags[] = {
 		NULL, "H34" },
 	{ 0x064e, 0xa212, 0, "MEDIONAG", "WeTab ",
 		V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
-	{ 0x174f, 0x5a35, 0, "PEGATRON CORPORATION         ", "F5SL    ",
-		V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
 	{ 0x174f, 0x6a51, 0, NULL, "S96S",
 		V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED, 0,
 		"MicroLink", "S96S" },
@@ -270,6 +261,7 @@ static const char *asus_board_vendor[] = {
 	"ASUSTeK Computer Inc.",
 	"ASUSTeK Computer INC.",
 	"ASUS CORPORATION",
+	"PEGATRON CORPORATION",
 	NULL };
 
 static const char *asus_board_name[] = {
-- 
2.7.1

Re: [PATCH] v4lconvert: Add "PEGATRON CORPORATION" to asus_board_vendor

[Rudy Zijlstra]

Hi

On 27-02-16 14:40, Hans de Goede wrote:
> Some Asus laptops actually have "PEGATRON CORPORATION" in board_vendor,
> add this to the list of strings used to recognize Asus as vendor.
>
> This also allows us to remove a bunch of PEGATRON entries from the static
> v4lcontrol_flags table.
>
>

Do not know what the current ownership structure is, but pegatron used 
to be called Unihan, and is/was part of the Asus group

Cheers

Rudy

Re: [PATCH 0/1] v4lconvert: Add "PEGATRON CORPORATION" to asus_board_vendor

[Hans de Goede]

Hans de Goede <hdegoede <at> redhat.com> writes:

> 
> Hi Gregor,
> 
> Here is a patch to add "PEGATRON CORPORATION" to asus_board_vendor,
> to fix an upside down bug reported to Fedora:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1311545
> 
> I'm not 100% sure this is a good idea, it might cause a bunch of false
> positives, but looking at the existing static PEGATRON entries in the
> v4l_control_flags list, it seems that it really is just another vendor
> string for Asus and that adding it to asus_board_vendor is best, so
> I'm say 95% sure :)
> 
> Anyways your input on this is much appreciated. In the mean time I'll
> kick of a scratch-build of the Fedora v4l-utils pkg with this patch
> applied for the reporter to test.

After sleeping a few days on this, I've decided that this is indeed
the best way to deal with this, and given that I've not had any comments
on the patch I've just pushed it to v4l-utils master
 
Regards,
 
Hans