From: Rui Miguel Silva <rmfrfs@gmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org
Cc: Adam Ford <aford173@gmail.com>,
Martin Kepplinger <martin.kepplinger@puri.sm>,
Paul Elder <paul.elder@ideasonboard.com>,
kernel@pengutronix.de, linux-imx@nxp.com
Subject: Re: [PATCH v2 0/8] media: nxp: imx7-media-csi: Move to subdev active state
Date: Tue, 31 Jan 2023 09:30:39 +0000 [thread overview]
Message-ID: <m3leljcaps.fsf@gmail.com> (raw)
In-Reply-To: <20230129023429.22467-1-laurent.pinchart@ideasonboard.com>
Hi Laurent,
Also thanks for the work on updating this one.
Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:
> Hello,
>
> This small series moves the imx7-mipi-csi driver to use the subdev
> active state. Patches 1/8 to 7/8 are small preparatory cleanups, with
> the main change in 8/8.
>
> Compared to v1, I've now successfully tested the series on an i.MX8MM.
> The issues reported by Adam have been resolved by adding patch 7/8 and
> fixing a problem in 8/8.
>
> Laurent Pinchart (8):
> media: imx: imx7-media-csi: Drop imx7_csi.cc field
> media: imx: imx7-media-csi: Simplify imx7_csi_video_init_format()
> media: imx: imx7-media-csi: Drop unneeded check when starting
> streaming
> media: imx: imx7-media-csi: Drop unneeded src_sd check
> media: imx: imx7-media-csi: Drop unneeded pad checks
> media: imx: imx7-media-csi: Cleanup errors in
> imx7_csi_async_register()
> media: imx: imx7-media-csi: Zero format struct before calling
> .get_fmt()
> media: imx: imx7-media-csi: Use V4L2 subdev active state
LGTM, for the all series.
Acked-by: Rui Miguel Silva <rmfrfs@gmail.com>
Cheers,
Rui
>
> drivers/media/platform/nxp/imx7-media-csi.c | 235 ++++++--------------
> 1 file changed, 70 insertions(+), 165 deletions(-)
>
> --
> Regards,
>
> Laurent Pinchart
next prev parent reply other threads:[~2023-01-31 9:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 2:34 [PATCH v2 0/8] media: nxp: imx7-media-csi: Move to subdev active state Laurent Pinchart
2023-01-29 2:34 ` [PATCH v2 1/8] media: imx: imx7-media-csi: Drop imx7_csi.cc field Laurent Pinchart
2023-01-29 2:34 ` [PATCH v2 2/8] media: imx: imx7-media-csi: Simplify imx7_csi_video_init_format() Laurent Pinchart
2023-01-29 2:34 ` [PATCH v2 3/8] media: imx: imx7-media-csi: Drop unneeded check when starting streaming Laurent Pinchart
2023-01-29 2:34 ` [PATCH v2 4/8] media: imx: imx7-media-csi: Drop unneeded src_sd check Laurent Pinchart
2023-01-29 2:34 ` [PATCH v2 5/8] media: imx: imx7-media-csi: Drop unneeded pad checks Laurent Pinchart
2023-01-29 2:34 ` [PATCH v2 6/8] media: imx: imx7-media-csi: Cleanup errors in imx7_csi_async_register() Laurent Pinchart
2023-01-29 2:34 ` [PATCH v2 7/8] media: imx: imx7-media-csi: Zero format struct before calling .get_fmt() Laurent Pinchart
2023-01-29 2:34 ` [PATCH v2 8/8] media: imx: imx7-media-csi: Use V4L2 subdev active state Laurent Pinchart
2023-01-30 19:26 ` Jacopo Mondi
2023-01-30 20:14 ` Laurent Pinchart
2023-01-30 23:45 ` [PATCH v2 0/8] media: nxp: imx7-media-csi: Move to " Adam Ford
2023-01-31 9:30 ` Rui Miguel Silva [this message]
2023-01-31 10:17 ` Martin Kepplinger
2023-01-31 10:24 ` Laurent Pinchart
2023-01-31 11:18 ` Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3leljcaps.fsf@gmail.com \
--to=rmfrfs@gmail.com \
--cc=aford173@gmail.com \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-imx@nxp.com \
--cc=linux-media@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
--cc=paul.elder@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox