public inbox for linux-mediatek@lists.infradead.org
 help / color / mirror / Atom feed
From: Koro Chen <koro.chen@mediatek.com>
To: broonie@kernel.org, tiwai@suse.de, lgirdwood@gmail.com
Cc: alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org,
	Koro Chen <koro.chen@mediatek.com>,
	srv_heupstream@mediatek.com
Subject: [RFC PATCH (alsa-lib)] pcm: Modify check condition in snd_pcm_sw_params_set_avail_min
Date: Thu, 3 Sep 2015 11:20:54 +0800	[thread overview]
Message-ID: <1441250454-38271-1-git-send-email-koro.chen@mediatek.com> (raw)

When we use a ping-ping buffer in capture, and if hw_ptr reported
at IRQ is a little smaller than period_size:

|xxxxxxxxxxxxxxxxxxxxxxxxxxxx--|-----------------------------|
                            hw_ptr < period_size

This available buffer will not be read since its size is smaller than
avail_min (which is set to be period_size), and read thread continues
to sleep. If the next hw_ptr is just a little larger than buffer_size,
overrun occurs.

This could be resolved by setting a small avail_min to kernel,
for example, 1, so read thread wakes up and reads every data at IRQ.
But current alsa-lib only allows avail_min to be at least period_size.
Remove the constraint and only check for zero case.

Signed-off-by: Koro Chen <koro.chen@mediatek.com>
---
 src/pcm/pcm.c |    8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/pcm/pcm.c b/src/pcm/pcm.c
index f5fc728..8492689 100644
--- a/src/pcm/pcm.c
+++ b/src/pcm/pcm.c
@@ -5958,12 +5958,8 @@ int snd_pcm_sw_params_set_avail_min(snd_pcm_t *pcm, snd_pcm_sw_params_t *params,
 #endif
 {
 	assert(pcm && params);
-	/* Fix avail_min if it's below period size.  The period_size
-	 * defines the minimal wake-up timing accuracy, so it doesn't
-	 * make sense to set below that.
-	 */
-	if (val < pcm->period_size)
-		val = pcm->period_size;
+	if (!val)
+		val = 1;
 	params->avail_min = val;
 	return 0;
 }
-- 
1.7.9.5

             reply	other threads:[~2015-09-03  3:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-03  3:20 Koro Chen [this message]
2015-09-03  7:08 ` [RFC PATCH (alsa-lib)] pcm: Modify check condition in snd_pcm_sw_params_set_avail_min Takashi Iwai
2015-09-03  7:45   ` Koro Chen
2015-09-03  8:14     ` Clemens Ladisch
     [not found]       ` <55E8014B.8030800-P6GI/4k7KOmELgA04lAiVw@public.gmane.org>
2015-09-04  2:39         ` [alsa-devel] " Koro Chen
2015-09-03  9:38     ` Mark Brown
2015-09-04  2:49       ` Koro Chen
2015-09-04 15:15         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441250454-38271-1-git-send-email-koro.chen@mediatek.com \
    --to=koro.chen@mediatek.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=srv_heupstream@mediatek.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox