public inbox for linux-mediatek@lists.infradead.org
 help / color / mirror / Atom feed
From: Koro Chen <koro.chen@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org,
	lgirdwood@gmail.com, srv_heupstream@mediatek.com
Subject: Re: [RFC PATCH (alsa-lib)] pcm: Modify check condition in snd_pcm_sw_params_set_avail_min
Date: Fri, 4 Sep 2015 10:49:35 +0800	[thread overview]
Message-ID: <1441334975.32609.30.camel@mtksdaap41> (raw)
In-Reply-To: <20150903093810.GE5313@sirena.org.uk>

On Thu, 2015-09-03 at 10:38 +0100, Mark Brown wrote:
> On Thu, Sep 03, 2015 at 03:45:46PM +0800, Koro Chen wrote:
> > On Thu, 2015-09-03 at 09:08 +0200, Takashi Iwai wrote:
> 
> > > How this happens?  The period size is the size where irq (or wakeup)
> > > wakes up for read/write.  Why the driver wakes up even if there is no
> > > enough data?
> 
> > Yes it is odd to what we would normally expect. Due to our HW design,
> > when irq comes, audio HW actually has collected a full period of data,
> > but there is a buffer between the audio HW and memory, so at that moment
> > some samples are still in the buffer, not on the memory. Add a small
> > delay between triggering capture HW and enabling IRQ can also fix this,
> > although I think changing the avail_min should be better. 
> 
> This does sound like something that should be handled in the kernel -
> one thing we should be doing is providing a uniform interface to
> userspace.
Hmm, I thought those param settings are used to handle different HW
behavior like my case, but maybe I am wrong. It is more important to let
a single driver to be used under many different cases. I will find
solution in my driver, thank you!

  reply	other threads:[~2015-09-04  2:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-03  3:20 [RFC PATCH (alsa-lib)] pcm: Modify check condition in snd_pcm_sw_params_set_avail_min Koro Chen
2015-09-03  7:08 ` Takashi Iwai
2015-09-03  7:45   ` Koro Chen
2015-09-03  8:14     ` Clemens Ladisch
     [not found]       ` <55E8014B.8030800-P6GI/4k7KOmELgA04lAiVw@public.gmane.org>
2015-09-04  2:39         ` [alsa-devel] " Koro Chen
2015-09-03  9:38     ` Mark Brown
2015-09-04  2:49       ` Koro Chen [this message]
2015-09-04 15:15         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441334975.32609.30.camel@mtksdaap41 \
    --to=koro.chen@mediatek.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=srv_heupstream@mediatek.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox