* [PATCH] pinctrl: mediatek: fix handling return value of mtk_pmx_find_gpio_mode
@ 2016-02-11 14:34 Andrzej Hajda
[not found] ` <1455201248-4988-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-02-15 23:31 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Andrzej Hajda @ 2016-02-11 14:34 UTC (permalink / raw)
To: Linus Walleij, Biao Huang, open list:PIN CONTROL SUBSYSTEM
Cc: Bartlomiej Zolnierkiewicz, Hongzhou Yang, Andrzej Hajda,
moderated list:ARM/Mediatek SoC support, Matthias Brugger,
Yingjoe Chen, Marek Szyprowski
The function can return negative values, so its result should
be assigned to signed variable.
The problem has been detected using coccinelle semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci.
Fixes: 59ee9c9 ('pinctrl: mediatek: Add gpio_request_enable support')
Signed-off-by: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
index cbc2204..ddc9217 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
@@ -755,7 +755,7 @@ static int mtk_pmx_gpio_request_enable(struct pinctrl_dev *pctldev,
struct pinctrl_gpio_range *range,
unsigned offset)
{
- unsigned long muxval;
+ int muxval;
struct mtk_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev);
muxval = mtk_pmx_find_gpio_mode(pctl, offset);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1455201248-4988-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>]
* Re: [PATCH] pinctrl: mediatek: fix handling return value of mtk_pmx_find_gpio_mode
[not found] ` <1455201248-4988-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
@ 2016-02-12 2:59 ` Hongzhou Yang
0 siblings, 0 replies; 3+ messages in thread
From: Hongzhou Yang @ 2016-02-12 2:59 UTC (permalink / raw)
To: Andrzej Hajda
Cc: Bartlomiej Zolnierkiewicz, Biao Huang, Linus Walleij,
open list:PIN CONTROL SUBSYSTEM,
moderated list:ARM/Mediatek SoC support, Matthias Brugger,
Yingjoe Chen, Marek Szyprowski
On Thu, 2016-02-11 at 15:34 +0100, Andrzej Hajda wrote:
> The function can return negative values, so its result should
> be assigned to signed variable.
>
> The problem has been detected using coccinelle semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci.
>
> Fixes: 59ee9c9 ('pinctrl: mediatek: Add gpio_request_enable support')
> Signed-off-by: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
> drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> index cbc2204..ddc9217 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> @@ -755,7 +755,7 @@ static int mtk_pmx_gpio_request_enable(struct pinctrl_dev *pctldev,
> struct pinctrl_gpio_range *range,
> unsigned offset)
> {
> - unsigned long muxval;
> + int muxval;
> struct mtk_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev);
>
> muxval = mtk_pmx_find_gpio_mode(pctl, offset);
Thank you very much.
Acked-by: Hongzhou Yang <hongzhou.yang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Yours,
Hongzhou
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: mediatek: fix handling return value of mtk_pmx_find_gpio_mode
2016-02-11 14:34 [PATCH] pinctrl: mediatek: fix handling return value of mtk_pmx_find_gpio_mode Andrzej Hajda
[not found] ` <1455201248-4988-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
@ 2016-02-15 23:31 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2016-02-15 23:31 UTC (permalink / raw)
To: Andrzej Hajda
Cc: Biao Huang, open list:PIN CONTROL SUBSYSTEM,
Bartlomiej Zolnierkiewicz, Marek Szyprowski, Matthias Brugger,
Hongzhou Yang, Yingjoe Chen,
moderated list:ARM/Mediatek SoC support
On Thu, Feb 11, 2016 at 3:34 PM, Andrzej Hajda <a.hajda@samsung.com> wrote:
> The function can return negative values, so its result should
> be assigned to signed variable.
>
> The problem has been detected using coccinelle semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci.
>
> Fixes: 59ee9c9 ('pinctrl: mediatek: Add gpio_request_enable support')
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Patch applied with Hongzhou's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-15 23:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-11 14:34 [PATCH] pinctrl: mediatek: fix handling return value of mtk_pmx_find_gpio_mode Andrzej Hajda
[not found] ` <1455201248-4988-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-02-12 2:59 ` Hongzhou Yang
2016-02-15 23:31 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox